-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Check for missing reportActionID on threaded messages #21163
Conversation
@mananjadhav Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
Hm not sure why we didn't get an internal engineer... @mananjadhav this is a pretty tiny fix so let me find someone internal and see if they need your help to review or not! |
Sure @dangrous. Let me know if you need help. |
blargh that didn't do what I wanted. @mollfpr ignore this, sorry! |
EDIT TO MAKE THE PR CHECK PASS - THIS IS NOT THE FINAL CHECKLIST No Longer the Reviewer Checklist No Sir
Screenshots/VideosMobile Web - ChromeMobile Web - SafariDesktopiOSAndroid |
@mananjadhav I synced with @johnmlee101 - can you actually go ahead and review and checklist? That would be super helpful, thank you! |
Sure, give me 30 mins |
🎯 @mananjadhav, thanks for reviewing and testing this PR! 🎉 An E/App issue has been created to issue payment here: #21226. |
Reviewer Checklist
Screenshots/Videos |
@johnmlee101 @dangrous All done, tests well. Completed the checklist. |
FYI @johnmlee101 I edited your comment - apparently the PR Checklist check only looks for the FIRST checklist so I had to change yours so that it would see @mananjadhav's version. Merging! |
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
🚀 Deployed to staging by https://github.com/dangrous in version: 1.3.31-0 🚀
|
🚀 Deployed to production by https://github.com/luacmartins in version: 1.3.31-3 🚀
|
🚀 Deployed to production by https://github.com/luacmartins in version: 1.3.31-3 🚀
|
Details
We had previously checked for threaded messages with a check for if the reportAction didn't actually exist, but there are certain situations where the reportAction exists, but doesn't have a reportActionID (only a message), causing a problem. This occurs when the parent message of a thread has been deleted. It can still be pulled from the parent report, which this sets up.
Fixed Issues
$ https://github.com/Expensify/Expensify/issues/292202
Tests
Offline tests
QA Steps
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)myBool && <MyComponent />
.src/languages/*
files and using the translation methodWaiting for Copy
label for a copy review on the original GH to get the correct copy.STYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)/** comment above it */
this
properly so there are no scoping issues (i.e. foronClick={this.submit}
the methodthis.submit
should be bound tothis
in the constructor)this
are necessary to be bound (i.e. avoidthis.submit = this.submit.bind(this);
ifthis.submit
is never passed to a component event handler likeonClick
)StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Web
Mobile Web - Chrome
Mobile Web - Safari
Desktop
iOS
Android