Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[$1000] Unexpected error while splitting money- After task history- mobile number #22031

Closed
1 of 6 tasks
kavimuru opened this issue Jul 2, 2023 · 56 comments
Closed
1 of 6 tasks
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Engineering Internal Requires API changes or must be handled by Expensify staff Weekly KSv2

Comments

@kavimuru
Copy link

kavimuru commented Jul 2, 2023

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

Pre-requisite: There must be a task history over user A and user B. Please assign task from User A to User B and send some messages. User B must be a phone number.
1 Login as User A and click on + button and click on split money
2 Set amount and description and select User B
3. Split money and verify if you get error

Expected Result:

There should be no error in splitting money with registered users.

Actual Result:

Got these errors : “There is a previously existing chat between these users.”
“Auth GetEmailByAccountID returned an error” and “Unexpected error requesting money, please try again later”
I got error with both registered and unregistered mobile numbers

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android / native
  • Android / Chrome
  • iOS / native
  • iOS / Safari
  • MacOS / Chrome / Safari
  • MacOS / Desktop

Version Number: 1.3.35-5
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Recording.2288.mp4
reply-kavi.muru.1.mp4

Expensify/Expensify Issue URL:
Issue reported by: @avi-shek-jha
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1688104145295479

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~016b1c3dd2f7daeaad
  • Upwork Job ID: 1676297367694114816
  • Last Price Increase: 2023-07-25
@kavimuru kavimuru added Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Jul 2, 2023
@melvin-bot
Copy link

melvin-bot bot commented Jul 2, 2023

Triggered auto assignment to @mallenexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

@melvin-bot
Copy link

melvin-bot bot commented Jul 2, 2023

Bug0 Triage Checklist (Main S/O)

  • This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
  • This bug is not a duplicate report (check E/App issues and #expensify-bugs)
    • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
  • This bug is reproducible using the reproduction steps in the OP. S/O
    • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
    • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
  • This issue is filled out as thoroughly and clearly as possible
    • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
  • I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

@melvin-bot melvin-bot bot added the Overdue label Jul 4, 2023
@mallenexpensify mallenexpensify added the Internal Requires API changes or must be handled by Expensify staff label Jul 4, 2023
@melvin-bot
Copy link

melvin-bot bot commented Jul 4, 2023

Job added to Upwork: https://www.upwork.com/jobs/~016b1c3dd2f7daeaad

@melvin-bot
Copy link

melvin-bot bot commented Jul 4, 2023

Triggered auto assignment to Contributor Plus for review of internal employee PR - @abdulrahuman5196 (Internal)

@mallenexpensify
Copy link
Contributor

Updated OP to make it clear at the beginning that User B needs to be a phone number. I was able to reproduce,
image

@abdulrahuman5196 , can you also test to see if you're able to reproduce then propose if this should be internal or external? thx

@melvin-bot melvin-bot bot added Overdue and removed Overdue labels Jul 4, 2023
@melvin-bot
Copy link

melvin-bot bot commented Jul 7, 2023

@mallenexpensify, @abdulrahuman5196 Whoops! This issue is 2 days overdue. Let's get this updated quick!

@abdulrahuman5196
Copy link
Contributor

Will check and update in the morning

@melvin-bot melvin-bot bot removed the Overdue label Jul 7, 2023
@abdulrahuman5196
Copy link
Contributor

@mallenexpensify I was able to reproduce this issue. I think there should be some issue in what report Id we are using for split in frontend, since it is not expected to create a new report since we already have a chat with the user created by the task.
We can open it for external, there could be some internal work. But the investigation place to start is in frontend.

@bernhardoj
Copy link
Contributor

Same root cause with #22433

@melvin-bot melvin-bot bot added the Overdue label Jul 10, 2023
@mallenexpensify mallenexpensify added External Added to denote the issue can be worked on by a contributor and removed Internal Requires API changes or must be handled by Expensify staff labels Jul 11, 2023
@melvin-bot melvin-bot bot changed the title Unexpected error while splitting money- After task history- mobile number [$1000] Unexpected error while splitting money- After task history- mobile number Jul 11, 2023
@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Jul 11, 2023
@melvin-bot
Copy link

melvin-bot bot commented Jul 11, 2023

Current assignee @mallenexpensify is eligible for the External assigner, not assigning anyone new.

@melvin-bot
Copy link

melvin-bot bot commented Jul 11, 2023

Current assignee @abdulrahuman5196 is eligible for the External assigner, not assigning anyone new.

@mallenexpensify
Copy link
Contributor

Made External, dropped a comment on #22433 for Kadie to keep tabs on this, thanks for the comment @bernhardoj

@melvin-bot melvin-bot bot added Overdue and removed Overdue labels Jul 11, 2023
@abdulrahuman5196
Copy link
Contributor

I think both the issues are related from the root cause from @bernhardoj. I will review the proposal here and re-check if the solution solves both the issues and update back.
Meanwhile, @bernhardoj could you kindly post your proposal here as well specific to this issue?

@melvin-bot melvin-bot bot removed the Overdue label Aug 23, 2023
@abdulrahuman5196
Copy link
Contributor

abdulrahuman5196 commented Aug 23, 2023

I had already posted in open source channel days back, missed to paste the reference here https://expensify.slack.com/archives/C01GTK53T8Q/p1692383613454819

But still no update @mallenexpensify

@melvin-bot melvin-bot bot added the Overdue label Aug 28, 2023
@melvin-bot
Copy link

melvin-bot bot commented Aug 29, 2023

@mallenexpensify, @abdulrahuman5196 Eep! 4 days overdue now. Issues have feelings too...

@mallenexpensify
Copy link
Contributor

Thanks @abdulrahuman5196 , I posted again and tagged the @engineering-team, to see if that helps. I'm guessing you're unable to. Let's see if we get some 🎣

@melvin-bot melvin-bot bot added Overdue and removed Overdue labels Aug 30, 2023
@abdulrahuman5196
Copy link
Contributor

@melvin-bot melvin-bot bot removed the Overdue label Sep 4, 2023
@mallenexpensify mallenexpensify added Weekly KSv2 and removed Daily KSv2 labels Sep 5, 2023
@mallenexpensify
Copy link
Contributor

Put on Hold, will add issue number once it's dropped in the thread. https://expensify.slack.com/archives/C01GTK53T8Q/p1693818288598599?thread_ts=1692383613.454819&cid=C01GTK53T8Q

@mallenexpensify
Copy link
Contributor

@mallenexpensify mallenexpensify changed the title [$1000] Unexpected error while splitting money- After task history- mobile number [HOLD #22480] [$1000] Unexpected error while splitting money- After task history- mobile number Sep 11, 2023
@mallenexpensify
Copy link
Contributor

mallenexpensify commented Sep 11, 2023

@melvin-bot melvin-bot bot added the Overdue label Sep 19, 2023
@mallenexpensify
Copy link
Contributor

@melvin-bot melvin-bot bot removed the Overdue label Sep 21, 2023
@melvin-bot melvin-bot bot added the Overdue label Sep 29, 2023
@mallenexpensify mallenexpensify changed the title [HOLD #22480] [$1000] Unexpected error while splitting money- After task history- mobile number [$1000] Unexpected error while splitting money- After task history- mobile number Oct 4, 2023
@mallenexpensify
Copy link
Contributor

Off hold, @kavimuru can you see if you can still reproduce?
Thx

@mallenexpensify
Copy link
Contributor

@kavimuru , are you able to reproduce? Thx

@melvin-bot melvin-bot bot removed the Overdue label Oct 14, 2023
@kavimuru
Copy link
Author

@mallenexpensify I am not able to reproduce

Recording.1629.mp4

@mallenexpensify
Copy link
Contributor

Closing, unable to reproduce and a lot of shit's changed with split and associated flow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Engineering Internal Requires API changes or must be handled by Expensify staff Weekly KSv2
Projects
None yet
Development

No branches or pull requests

5 participants