[HOLD for payment 2023-07-17] [HOLD for payment 2023-07-14] Not able to split money on back button #22302

kavimuru · 2023-07-05T19:50:27Z

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Action Performed:

On chrome staging website > FAB icon > Split Bill > Enter amount > Click Next >Select any user > Click Next to open up the split bill page ( Do NOT click split button)
Now click on the user > Click back and see that the split money page is gone

Expected Result:

Back button should not end the split bill page

Actual Result:

Back button ends the split bill page

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

Version Number: 1.3.37-1
Reproducible in staging?: y
Reproducible in production?: n
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

split.mp4

Recording.1174.mp4

Expensify/Expensify Issue URL:
Issue reported by: @Santhosh-Sellavel
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1688586118022729

View all open jobs on GitHub

melvin-bot · 2023-07-05T19:50:33Z

Triggered auto assignment to @puneetlath (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

melvin-bot · 2023-07-05T19:50:35Z

Bug0 Triage Checklist (Main S/O)

This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
This bug is not a duplicate report (check E/App issues and #expensify-bugs)
- If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
This bug is reproducible using the reproduction steps in the OP. S/O
- If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
- If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
This issue is filled out as thoroughly and clearly as possible
- Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

OSBotify · 2023-07-05T19:52:34Z

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

Identify the pull request that introduced this issue and revert it.
Find someone who can quickly fix the issue.
Fix the issue yourself.

melvin-bot · 2023-07-05T19:52:35Z

Current assignee @puneetlath is eligible for the Engineering assigner, not assigning anyone new.

StevenKKC · 2023-07-06T09:45:12Z

Proposal

Please re-state the problem that we are trying to solve in this issue.

Back button ends the split bill page after open user detail page.

What is the root cause of that problem?

The following code is called if clicks the user on the split bill confirmation page.

App/src/components/MoneyRequestConfirmationList.js

Lines 199 to 204 in a2a521d

    
           const navigateToUserDetail = (option) => { 
        
               if (!option.accountID) { 
        
                   return; 
        
               } 
        
               Navigation.navigate(ROUTES.getProfileRoute(option.accountID)); 
        
           };

The Money Request page and the Profile page are separate screens, seperate RHP flows.
As a result, the following code will replace navigation routes. and the money request flow will be removed after navigating to the user profile page.

App/src/libs/Navigation/linkTo.js

Lines 80 to 90 in a2a521d

    
           if (action.payload.name === NAVIGATORS.RIGHT_MODAL_NAVIGATOR) { 
        
               const {minimalAction, targetName} = getMinimalAction(action, navigation.getRootState()); 
        
               if (minimalAction) { 
        
                   // If the target name is RHP that means this action is responsible for changing flow within the RHP e.g. from settings to search. In that case we want to use REPLACE. 
        
                   if (targetName === NAVIGATORS.RIGHT_MODAL_NAVIGATOR) { 
        
                       minimalAction.type = 'REPLACE'; 
        
                   } 
        
                   root.dispatch(minimalAction); 
        
                   return; 
        
               } 
        
           }

Therefore clicking back will close the modal and end the split bill process.

What changes do you think we should make in order to solve the problem?

According to the above code comments, replacing routes when changing flow is intended.
However, I think navigating from split bill or money request to user detail page should follow the same flow and not replace routes.
We can change this line as below.

-   if (targetName === NAVIGATORS.RIGHT_MODAL_NAVIGATOR) {
+   if (targetName === NAVIGATORS.RIGHT_MODAL_NAVIGATOR && minimalAction.payload.name !== 'Profile') {

What alternative solutions did you explore? (Optional)

None.

melvin-bot · 2023-07-06T09:45:16Z

Looks like something related to react-navigation may have been mentioned in this issue discussion.

As a reminder, please make sure that all proposals are not workarounds and that any and all attempt to fix the issue holistically have been made before proceeding with a solution. Proposals to change our DeprecatedCustomActions.js files should not be accepted.

Feel free to drop a note in #expensify-open-source with any questions.

Julesssss · 2023-07-06T12:55:27Z

Same underlying cause as this issue. I'm going to close this and add this additional case to the issue description

Santhosh-Sellavel · 2023-07-06T15:01:37Z

@Julesssss But I reported this issue before the other one please check https://expensify.slack.com/archives/C049HHMV9SM/p1688507121082889

Julesssss · 2023-07-06T16:21:10Z

@Santhosh-Sellavel I documented this here on the other issue

Julesssss · 2023-07-06T16:29:13Z

My mistake. This is a slightly different issue and is still occurring 😖

Julesssss · 2023-07-06T16:34:13Z

Hi @StevenKKC, thanks for your proposal. Checking for a specific profile page name is flakey and doesn't seem to solve the underlying issue though.

melvin-bot · 2023-07-07T10:15:35Z

Reviewing label has been removed, please complete the "BugZero Checklist".

melvin-bot · 2023-07-07T10:15:36Z

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.37-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

Do not use the replace in case of RHP as its fixing edge case #22355

If no regressions arise, payment will be issued on 2023-07-14. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

External issue reporter
Contributor that fixed the issue
Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

Merged PR within 3 business days of assignment - 50% bonus
Merged PR more than 9 business days after assignment - 50% penalty

melvin-bot · 2023-07-07T10:15:37Z

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

[@Santhosh-Sellavel] The PR that introduced the bug has been identified. Link to the PR:
[@Santhosh-Sellavel] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[@Santhosh-Sellavel] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[@Santhosh-Sellavel] Determine if we should create a regression test for this bug.
[@Santhosh-Sellavel] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

Santhosh-Sellavel · 2023-07-09T19:48:42Z

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

[@Santhosh-Sellavel] The PR that introduced the bug has been identified. Link to the PR: [navigation-refactor] Use minimal action to navigate inside RHP #21067

[@Santhosh-Sellavel] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: https://github.com/Expensify/App/pull/21067/files#r1257532582

[@Santhosh-Sellavel] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: Here

[@Santhosh-Sellavel] Determine if we should create a regression test for this bug. Yes

[@Santhosh-Sellavel] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again. [HOLD for payment 2023-07-17] [HOLD for payment 2023-07-14] Not able to split money on back button #22302 (comment)

[] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

cc: @mountiny Let me know if you differ on any of the above.

Santhosh-Sellavel · 2023-07-09T19:49:32Z

Regression Steps

From PR looks good

From Global create, select Split Bill
Go through the flow until the confirmation page
click on the user details (do not create the split)
Click Back (UP action) in left top corner of RHP
Verify the screen navigated back to the confirmation page

👍 or 👎

melvin-bot · 2023-07-10T23:47:02Z

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.38-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

Do not use the replace in case of RHP as its fixing edge case #22355

If no regressions arise, payment will be issued on 2023-07-17. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

External issue reporter
Contributor that fixed the issue
Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

Merged PR within 3 business days of assignment - 50% bonus
Merged PR more than 9 business days after assignment - 50% penalty

melvin-bot · 2023-07-10T23:47:04Z

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

[@Santhosh-Sellavel] The PR that introduced the bug has been identified. Link to the PR:
[@Santhosh-Sellavel] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[@Santhosh-Sellavel] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[@Santhosh-Sellavel] Determine if we should create a regression test for this bug.
[@Santhosh-Sellavel] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

melvin-bot · 2023-07-17T10:48:49Z

Triggered auto assignment to @tjferriss (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

melvin-bot · 2023-07-17T10:48:51Z

Bug0 Triage Checklist (Main S/O)

This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
This bug is not a duplicate report (check E/App issues and #expensify-bugs)
- If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
This bug is reproducible using the reproduction steps in the OP. S/O
- If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
- If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
This issue is filled out as thoroughly and clearly as possible
- Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

mountiny · 2023-07-17T10:49:23Z

Reassinging the Bug label to get someone to pay this out

@Santhosh-Sellavel should get $1250 for the review and reporting the bug

Santhosh-Sellavel · 2023-07-17T17:33:50Z

Requested payment on ND

tjferriss · 2023-07-19T05:16:30Z

@Santhosh-Sellavel have you been paid via NewDot?

Santhosh-Sellavel · 2023-07-20T18:40:24Z

Yeah got paid! Good to close this!

melvin-bot · 2023-08-21T08:55:57Z

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

kavimuru added DeployBlockerCash This issue or pull request should block deployment Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Jul 5, 2023

melvin-bot bot assigned puneetlath Jul 5, 2023

github-actions bot added Engineering Hourly KSv2 and removed Daily KSv2 labels Jul 5, 2023

OSBotify mentioned this issue Jul 5, 2023

Deploy Checklist: New Expensify 2023-07-05 #22282

Closed

58 tasks

melvin-bot bot added Daily KSv2 and removed Hourly KSv2 labels Jul 6, 2023

Julesssss closed this as completed Jul 6, 2023

melvin-bot bot mentioned this issue Jul 6, 2023

[HOLD for payment 2023-07-17] [HOLD for payment 2023-07-14] [HOLD FOR PAYMENT - 13th July] User is taken to the first step after changing currency when splitting a bill #22289

Closed

6 tasks

Julesssss reopened this Jul 6, 2023

Julesssss added Hourly KSv2 and removed Daily KSv2 labels Jul 6, 2023

mountiny mentioned this issue Jul 6, 2023

Do not use the replace in case of RHP as its fixing edge case #22355

Merged

58 tasks

melvin-bot bot added the Reviewing Has a PR in review label Jul 6, 2023

mountiny assigned mountiny and unassigned puneetlath Jul 6, 2023

melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Daily KSv2 labels Jul 7, 2023

melvin-bot bot changed the title ~~Not able to split money on back button~~ [HOLD for payment 2023-07-14] Not able to split money on back button Jul 7, 2023

melvin-bot bot removed the Reviewing Has a PR in review label Jul 7, 2023

melvin-bot bot added Weekly KSv2 and removed Weekly KSv2 labels Jul 10, 2023

melvin-bot bot changed the title ~~[HOLD for payment 2023-07-14] Not able to split money on back button~~ [HOLD for payment 2023-07-17] [HOLD for payment 2023-07-14] Not able to split money on back button Jul 10, 2023

melvin-bot bot added Daily KSv2 Overdue and removed Weekly KSv2 labels Jul 13, 2023

mountiny added Bug Something is broken. Auto assigns a BugZero manager. and removed Bug Something is broken. Auto assigns a BugZero manager. labels Jul 17, 2023

melvin-bot bot assigned tjferriss Jul 17, 2023

melvin-bot bot removed the Overdue label Jul 17, 2023

mountiny closed this as completed Jul 20, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[HOLD for payment 2023-07-17] [HOLD for payment 2023-07-14] Not able to split money on back button #22302

[HOLD for payment 2023-07-17] [HOLD for payment 2023-07-14] Not able to split money on back button #22302

kavimuru commented Jul 5, 2023 •

edited by Julesssss

Loading

melvin-bot bot commented Jul 5, 2023

melvin-bot bot commented Jul 5, 2023

OSBotify commented Jul 5, 2023

melvin-bot bot commented Jul 5, 2023

StevenKKC commented Jul 6, 2023

melvin-bot bot commented Jul 6, 2023

Julesssss commented Jul 6, 2023

Santhosh-Sellavel commented Jul 6, 2023

Julesssss commented Jul 6, 2023

Julesssss commented Jul 6, 2023 •

edited

Loading

Julesssss commented Jul 6, 2023 •

edited

Loading

melvin-bot bot commented Jul 7, 2023

melvin-bot bot commented Jul 7, 2023

melvin-bot bot commented Jul 7, 2023

Santhosh-Sellavel commented Jul 9, 2023 •

edited

Loading

Santhosh-Sellavel commented Jul 9, 2023

melvin-bot bot commented Jul 10, 2023

melvin-bot bot commented Jul 10, 2023

melvin-bot bot commented Jul 17, 2023

melvin-bot bot commented Jul 17, 2023

mountiny commented Jul 17, 2023

Santhosh-Sellavel commented Jul 17, 2023

tjferriss commented Jul 19, 2023

Santhosh-Sellavel commented Jul 20, 2023

melvin-bot bot commented Aug 21, 2023

[HOLD for payment 2023-07-17] [HOLD for payment 2023-07-14] Not able to split money on back button #22302

[HOLD for payment 2023-07-17] [HOLD for payment 2023-07-14] Not able to split money on back button #22302

Comments

kavimuru commented Jul 5, 2023 • edited by Julesssss Loading

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

melvin-bot bot commented Jul 5, 2023

melvin-bot bot commented Jul 5, 2023

Bug0 Triage Checklist (Main S/O)

OSBotify commented Jul 5, 2023

melvin-bot bot commented Jul 5, 2023

StevenKKC commented Jul 6, 2023

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

melvin-bot bot commented Jul 6, 2023

Julesssss commented Jul 6, 2023

Santhosh-Sellavel commented Jul 6, 2023

Julesssss commented Jul 6, 2023

Julesssss commented Jul 6, 2023 • edited Loading

Julesssss commented Jul 6, 2023 • edited Loading

melvin-bot bot commented Jul 7, 2023

melvin-bot bot commented Jul 7, 2023

melvin-bot bot commented Jul 7, 2023

Santhosh-Sellavel commented Jul 9, 2023 • edited Loading

Santhosh-Sellavel commented Jul 9, 2023

Regression Steps

melvin-bot bot commented Jul 10, 2023

melvin-bot bot commented Jul 10, 2023

melvin-bot bot commented Jul 17, 2023

melvin-bot bot commented Jul 17, 2023

Bug0 Triage Checklist (Main S/O)

mountiny commented Jul 17, 2023

Santhosh-Sellavel commented Jul 17, 2023

tjferriss commented Jul 19, 2023

Santhosh-Sellavel commented Jul 20, 2023

melvin-bot bot commented Aug 21, 2023

kavimuru commented Jul 5, 2023 •

edited by Julesssss

Loading

Julesssss commented Jul 6, 2023 •

edited

Loading

Julesssss commented Jul 6, 2023 •

edited

Loading

Santhosh-Sellavel commented Jul 9, 2023 •

edited

Loading