-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[HOLD for payment 2023-08-16] [$1000] Web - The green line appear immediately only after comments are added to a task #23004
Comments
Triggered auto assignment to @bfitzexpensify ( |
Triggered auto assignment to @anmurali ( |
Bug0 Triage Checklist (Main S/O)
|
Triggered auto assignment to Design team member for new feature review - @shawnborton ( |
ProposalPlease re-state the problem that we are trying to solve in this issue.Web - The green line appear immediately only after comments are added to a task What is the root cause of that problem?We are conditionally rendering green line
What changes do you think we should make in order to solve the problem?We should remove this check here and show green line without any check and remove unused props.
Solution 2 App/src/pages/home/report/ReportActionItem.js Line 423 in f638162
What alternative solutions did you explore? (Optional) |
Not sure if this is a bug. The line separates the details with the conversation. Let's take opinion expensify team. |
ProposalPlease re-state the problem that we are trying to solve in this issue.Green line does not appear immediately for the task report and only appears if it has any comment What is the root cause of that problem?We are showing the line here conditionally where it only shows when we it is not only a ReportAction. App/src/pages/home/report/ReportActionItem.js Lines 421 to 423 in f638162
What changes do you think we should make in order to solve the problem?Remove |
Job added to Upwork: https://www.upwork.com/jobs/~01179280ad6cadbb04 |
Current assignees @anmurali and @bfitzexpensify are eligible for the External assigner, not assigning anyone new. |
Triggered auto assignment to Contributor-plus team member for initial proposal review - @narefyev91 ( |
@MonilBhavsar @narefyev91 In my proposal I suggested to simply use "shouldShowHorizontalRule". It makes more sense. #23004 (comment) |
@MonilBhavsar I don't think this is problem. If we decide to move TaskView and MoneyReportView to ReportActionItemParentAction, we also pass the isOnlyReportAction prop to both MoneyReportView to ReportActionItemParentAction
It also makes sense because MoneyRequestView and TaskView only appear if App/src/pages/home/report/ReportActionItem.js Lines 426 to 451 in 74ae95c
to ReportActionItemParentAction |
Thanks! just wanted to know how we were planning to approach. We can pass a new prop, no worries. And I think, let's use use either of |
@narefyev91 any though on this fisrt proposal to completely remove the condition, as we decided to display line in all cases |
@MonilBhavsar My main solution is mentioned here can do that.
The first proposal doesn't cover the case user mark as unread as mentioned here |
@dukenv0307's right. I was not aware of the case where we have to hide the green line. |
@dukenv0307 thanks for clarifying! |
📣 @dukenv0307 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app! Offer link |
@narefyev91 The PR is ready for review: #23154 |
Based on my calculations, the pull request did not get merged within 3 working days of assignment. Please, check out my computations here:
On to the next one 🚀 |
|
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.51-2 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue: If no regressions arise, payment will be issued on 2023-08-16. 🎊 After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.
For reference, here are some details about the assignees on this issue:
As a reminder, here are the bonuses/penalties that should be applied for any External issue:
|
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
|
Payment summary: reporting bonus $0 - reported by internal Expensify employee @dukenv0307 you've been paid so closing this one out! |
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Action Performed:
Expected Result:
The green line should appear immediately after creating the task
Actual Result:
The green line appear immediately only after comments are added to a task
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
Version Number: 1.3.41.0
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
Recording.3695.mp4
Expensify/Expensify Issue URL:
Issue reported by: @quinthar
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1689466341316849
View all open jobs on GitHub
Upwork Automation - Do Not Edit
The text was updated successfully, but these errors were encountered: