[HOLD for payment 2023-08-16] [$1000] Web - The green line appear immediately only after comments are added to a task

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Go to staging.new.exensify.com](https://staging.new.expensify.com/)
2. log in with your account
3. Create a task
4. Send a message

Expected Result:

The green line should appear immediately after creating the task

Actual Result:

The green line appear immediately only after comments are added to a task

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.41.0
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Recording.3695.mp4

Expensify/Expensify Issue URL:
Issue reported by: @quinthar
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1689466341316849

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01179280ad6cadbb04
• Upwork Job ID: 1681076844552364032
2023-07-17
• Automatic offers:
• dukenv0307 | Contributor | 25783892

[melvin-bot]

Triggered auto assignment to @bfitzexpensify (NewFeature), see https://stackoverflowteams.com/c/expensify/questions/14418#:~:text=BugZero%20process%20steps%20for%20feature%20requests for more details.

[melvin-bot]

Triggered auto assignment to @anmurali (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[melvin-bot]

Triggered auto assignment to Design team member for new feature review - @shawnborton (NewFeature)

[Nodebrute]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Web - The green line appear immediately only after comments are added to a task

What is the root cause of that problem?

We are conditionally rendering green line

App/src/components/ReportActionItem/TaskView.js

Line 139 in 25c8ae5

{props.shouldShowHorizontalRule && <View style={styles.reportHorizontalRule} />}

What changes do you think we should make in order to solve the problem?

We should remove this check here and show green line without any check and remove unused props.

       <View style={styles.reportHorizontalRule} />

Solution 2
If we want to conditionally render it then we can pass true here

App/src/pages/home/report/ReportActionItem.js

Line 423 in f638162

shouldShowHorizontalRule={!props.isOnlyReportAction}

 <TaskView
                    report={props.report}
                    shouldShowHorizontalRule
                />

What alternative solutions did you explore? (Optional)

[BhuvaneshPatil]

Not sure if this is a bug.

The line separates the details with the conversation. Let's take opinion expensify team.

[Pujan92]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Green line does not appear immediately for the task report and only appears if it has any comment

What is the root cause of that problem?

We are showing the line here conditionally where it only shows when we it is not only a ReportAction.

App/src/pages/home/report/ReportActionItem.js

Lines 421 to 423 in f638162

	<TaskView
	report={props.report}
	shouldShowHorizontalRule={!props.isOnlyReportAction}

What changes do you think we should make in order to solve the problem?

Remove shouldShowHorizontalRule prop from the TaskView component and remove the pass from the ReportActionItem as it is not required considering this change.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01179280ad6cadbb04

[melvin-bot]

Current assignees @anmurali and @bfitzexpensify are eligible for the External assigner, not assigning anyone new.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @narefyev91 (External)

[Nodebrute]

 <TaskView
                    report={props.report}
                    shouldShowHorizontalRule
                />

@MonilBhavsar @narefyev91 In my proposal I suggested to simply use "shouldShowHorizontalRule". It makes more sense. #23004 (comment)

[dukenv0307]

I'm little bit sideways for providing same prop with same condition and logic to two different components

@MonilBhavsar I don't think this is problem. If we decide to move TaskView and MoneyReportView to ReportActionItemParentAction, we also pass the isOnlyReportAction prop to both MoneyReportView to ReportActionItemParentAction

If we don't want to create new props in ReportActionItem. We can consider moving TaskView and MoneyReportView to ReportActionItemParentAction instead of ReportActionItem

It also makes sense because MoneyRequestView and TaskView only appear if actionName === CONST.REPORT.ACTIONS.TYPE.CREATED. So It is more consistent If we move this code

App/src/pages/home/report/ReportActionItem.js

Lines 426 to 451 in 74ae95c

	if (props.action.actionName === CONST.REPORT.ACTIONS.TYPE.CREATED) {
	const parentReport = ReportActionsUtils.getParentReportAction(props.report);
	if (ReportActionsUtils.isTransactionThread(parentReport)) {
	return (
	<MoneyRequestView
	report={props.report}
	shouldShowHorizontalRule={!props.isOnlyReportAction}
	/>
	);
	}
	if (ReportUtils.isTaskReport(props.report)) {
	return (
	<TaskView
	report={props.report}
	shouldShowHorizontalRule={!props.isOnlyReportAction}
	/>
	);
	}
	if (ReportUtils.isExpenseReport(props.report) || ReportUtils.isIOUReport(props.report)) {
	return (
	<MoneyReportView
	report={props.report}
	shouldShowHorizontalRule={!props.isOnlyReportAction}
	/>
	);
	}

to ReportActionItemParentAction

[MonilBhavsar]

I don't think this is problem. If we decide to move TaskView and MoneyReportView to ReportActionItemParentAction, we also pass the isOnlyReportAction prop to both MoneyReportView to ReportActionItemParentAction

Thanks! just wanted to know how we were planning to approach. We can pass a new prop, no worries. And I think, let's use use either of shouldShowHorizontalRule={!props.isOnlyReportAction} or shouldShowHorizontalRule={!props.shouldHideThreadDividerLine} for all components - Task, Thread, MoneyRequest, and to have consistency?

[MonilBhavsar]

@narefyev91 any though on this fisrt proposal to completely remove the condition, as we decided to display line in all cases

[dukenv0307]

And I think, let's use use either of shouldShowHorizontalRule={!props.isOnlyReportAction} or shouldShowHorizontalRule={!props.shouldHideThreadDividerLine} for all components - Task, Thread, MoneyRequest, and to have consistency?

@MonilBhavsar My main solution is mentioned here can do that.

any though on #23004 (comment) fisrt proposal to completely remove the condition, as we decided to display line in all cases

The first proposal doesn't cover the case user mark as unread as mentioned here

[Nodebrute]

@dukenv0307's right. I was not aware of the case where we have to hide the green line.

[MonilBhavsar]

@dukenv0307 thanks for clarifying!
I was looking at this draft PR https://github.com/Expensify/App/pull/23055/files and the prop value for shouldShowHorizontalRule was passed differently only for TaskView. I believe we can pass the same for all different types of report views.

[melvin-bot]

📣 @dukenv0307 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[dukenv0307]

@narefyev91 The PR is ready for review: #23154

[melvin-bot]

Based on my calculations, the pull request did not get merged within 3 working days of assignment. Please, check out my computations here:

• when @dukenv0307 got assigned: 2023-07-27 09:27:10 Z
• when the PR got merged: 2023-08-04 07:37:49 UTC
• days elapsed: 5

On to the next one 🚀

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.51-2 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• fix: The green line appear immediately only after comments are added to a task #23154

If no regressions arise, payment will be issued on 2023-08-16. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

• @narefyev91 does not require payment (Contractor)
• @dukenv0307 requires payment offer (Contributor)

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@narefyev91] The PR that introduced the bug has been identified. Link to the PR:
• [@narefyev91] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@narefyev91] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@narefyev91] Determine if we should create a regression test for this bug.
• [@narefyev91] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@zanyrenney] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[zanyrenney]

Payment summary:

reporting bonus $0 - reported by internal Expensify employee
C+ payout: @narefyev91 (expert agency paid outside upwork)
C payout: $1000 no urgency bonus

@dukenv0307 you've been paid so closing this one out!