-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: The green line appear immediately only after comments are added to a task #23154
Conversation
@sobitneupane Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
@MonilBhavsar It seems that @MelvinBot have a mistake when assigning c+ contributor to this PR |
@MonilBhavsar Could you help to check above comment? |
@@ -430,15 +434,15 @@ function ReportActionItem(props) { | |||
return ( | |||
<TaskView | |||
report={props.report} | |||
shouldShowHorizontalRule={!props.isOnlyReportAction} | |||
shouldShowHorizontalRule={!props.shouldHideThreadDividerLine} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In above on L427 also, shouldShowHorizontalRule prop is passed. Should we also update that?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@MonilBhavsar updated, please help review again.
I had a look. @narefyev91 is ooo and I'll be handling this |
@MonilBhavsar Bump |
@MonilBhavsar ICYMI. Please help review the PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, looks good to me!
@narefyev91 looks like you're back. Could you please give it a review, if fine. Thanks! 🙏 |
Hey - not really - will be back on Friday :-) |
@MonilBhavsar Do we need to wait for him until Friday to give the second approval? |
@narefyev91 @MonilBhavsar The PR is reviewed for the long time, Is any update on this PR |
Hey review will be done today - on it |
Reviewer Checklist
Screenshots/VideosWebweb.movMobile Web - Chromeandroid-web.movMobile Web - Safariios-web.movDesktopdesktop.moviOSios.movAndroidandroid.mov |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
🎀 👀 🎀 C+ reviewed
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
🚀 Deployed to staging by https://github.com/MonilBhavsar in version: 1.3.51-0 🚀
|
🚀 Deployed to production by https://github.com/Julesssss in version: 1.3.51-2 🚀
|
🚀 Deployed to staging by https://github.com/MonilBhavsar in version: 1.3.52-0 🚀
|
🚀 Deployed to staging by https://github.com/MonilBhavsar in version: 1.3.52-0 🚀
|
🚀 Deployed to production by https://github.com/puneetlath in version: 1.3.52-5 🚀
|
Details
The green line appear immediately only after comments are added to a task
Fixed Issues
$ #23004
PROPOSAL: #23004 (comment)
Tests
Offline tests
QA Steps
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)myBool && <MyComponent />
.src/languages/*
files and using the translation methodWaiting for Copy
label for a copy review on the original GH to get the correct copy.STYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)/** comment above it */
this
properly so there are no scoping issues (i.e. foronClick={this.submit}
the methodthis.submit
should be bound tothis
in the constructor)this
are necessary to be bound (i.e. avoidthis.submit = this.submit.bind(this);
ifthis.submit
is never passed to a component event handler likeonClick
)StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Web
web-rmk.mp4
Mobile Web - Chrome
chrome_rmk.mp4
Mobile Web - Safari
safari_rmk.mp4
Desktop
desktop_rmk.mp4
iOS
ios_rmk.mp4
Android
android.mp4