[Awaiting C+ payment confirmation] [HOLD for payment 2023-08-16] [$1000] IOS - Getting console warning on Contact methods page

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Open App and Go to Settings
2. Go to Profile > Press Contact Method

Expected Result:

There should be no console error on navigating to Contact Methods Page.

Actual Result:

On the Contact Methods Page Getting this console warning, *Warning: Failed prop type: The prop innerRef is marked as required in PressableWithDelayToggle, but its value is null

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: Dev 1.3.42-6
Reproducible in staging?: n/a
Reproducible in production?: n/a
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

contact-method-console-error.mov

Expensify/Expensify Issue URL:
Issue reported by: @jayeshmangwani
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1689664358693289

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01a7dbc8ab0e657b1c
• Upwork Job ID: 1681447597214900224
2023-07-18
• Automatic offers:
• | | 0
• jayeshmangwani | Reporter | 25676805

[melvin-bot]

Triggered auto assignment to @trjExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[jayeshmangwani]

Proposal

Please re-state the problem that we are trying to solve in this issue.

IOS - Getting console warning on Contact methods page

What is the root cause of that problem?

In PressableWithDelayToggle Component we passed the innerRef as required prop and when forwardRef pass the null ref then we get the console warning

App/src/components/Pressable/PressableWithDelayToggle.js

Lines 14 to 16 in 4e49206

	const propTypes = {
	/** Ref passed to the component by React.forwardRef (do not pass from parent) */
	innerRef: PropTypes.oneOfType([PropTypes.func, PropTypes.shape({current: PropTypes.instanceOf(React.Component)})]).isRequired,

What changes do you think we should make in order to solve the problem?

1. Here at defaultProps we should add the fallback value of innerRef

App/src/components/Pressable/PressableWithDelayToggle.js

Lines 59 to 69 in 4e49206

	const defaultProps = {
	text: '',
	textChecked: '',
	tooltipText: '',
	tooltipTextChecked: '',
	styles: [],
	textStyles: [],
	iconStyles: [],
	icon: null,
	inline: true,
	iconChecked: Expensicons.Checkmark,

    innerRef: () => {},

2. And innerRef prop does not have to be the required param, as here in BaseMiniContextMenuItem we are passing the ref to Pressable and it is not the required, and here in PressableWithDelayToggle Component also we are passing ref to Pressable

App/src/components/BaseMiniContextMenuItem.js

Lines 33 to 36 in f74512d

	/**
	* A ref to forward to the Pressable
	*/
	innerRef: PropTypes.oneOfType([PropTypes.func, PropTypes.object]),

We should remove the isRequired from the innerRef propTypes on PressableWithDelayToggle

What alternative solutions did you explore? (Optional)

none

[trjExpensify]

I don't have a dev environment to check for console logs on iOS. @aimane-chnaif I suspect maybe something to do with this migration of the component: #20601

Will move this on for a proposal review and input from C+!

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01a7dbc8ab0e657b1c

[melvin-bot]

Current assignee @trjExpensify is eligible for the External assigner, not assigning anyone new.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @thesahindia (External)

[Nodebrute]

Proposal

Please re-state the problem that we are trying to solve in this issue.

IOS - Getting console warning on Contact methods page

What is the root cause of that problem?

Here innerRef is required but it's value is null.

App/src/components/Pressable/PressableWithDelayToggle.js

Line 16 in edfea4b

innerRef: PropTypes.oneOfType([PropTypes.func, PropTypes.shape({current: PropTypes.instanceOf(React.Component)})]).isRequired,

We are using PressableWithDelayToggle here

App/src/components/CopyTextToClipboard.js

Line 29 in edfea4b

<PressableWithDelayToggle

and then CopyTextToClipboard is used on following pages

• ‎src/pages/settings/Profile/Contacts/ContactMethodsPage.js
• ‎src/pages/workspace/reimburse/WorkspaceReimburseView.js
• src/pages/workspace/bills/WorkspaceBillsFirstSection.js

here's another page where we are using PressableWithDelayToggle
‎src/pages/settings/Security/TwoFactorAuth/CodesPage.js

You can check in all of the pages the props.innerRef will be null.

What changes do you think we should make in order to solve the problem?

1. Remove this line. We don't need to check innerRef Proptype.
   

   App/src/components/Pressable/PressableWithDelayToggle.js

   Line 16 in edfea4b

   innerRef: PropTypes.oneOfType([PropTypes.func, PropTypes.shape({current: PropTypes.instanceOf(React.Component)})]).isRequired,

   
   2.Also we can safely remove innerRef from here. What's the point of passing null after all.
   

   App/src/components/Pressable/PressableWithDelayToggle.js

   Line 91 in edfea4b

   ref={props.innerRef}

   
   3 Also remove innerRef from here
   

   App/src/components/Pressable/PressableWithDelayToggle.js

   Line 140 in edfea4b

   innerRef={ref}

What alternative solutions did you explore? (Optional)

If we don't want to remove innerRef we can assign a value here of null

App/src/components/Pressable/PressableWithDelayToggle.js

Line 16 in edfea4b

innerRef: PropTypes.oneOfType([PropTypes.func, PropTypes.shape({current: PropTypes.instanceOf(React.Component)})]).isRequired,

like this

  innerRef: PropTypes.oneOfType([PropTypes.func,  PropTypes.oneOf([null]),PropTypes.shape({current: PropTypes.instanceOf(React.Component)})]).isRequired,

[rushatgabhane]

hi, I'll be reviewing this

[aimane-chnaif]

I don't have a dev environment to check for console logs on iOS. @aimane-chnaif I suspect maybe something to do with this migration of the component: #20601

Will move this on for a proposal review and input from C+!

@trjExpensify this came from #21852, not related to #20601

[aimane-chnaif]

I got confirmation from offending PR - #21852 (comment).
It's fine to make innerRef prop optional and @jayeshmangwani's proposal is solid.

[melvin-bot]

📣 @rushatgabhane Please request via NewDot manual requests for the Contributor role ($1000)

[melvin-bot]

📣 @jayeshmangwani 🎉 An offer has been automatically sent to your Upwork account for the Reporter role 🎉 Thanks for contributing to the Expensify app!

Upwork job

[trjExpensify]

Thanks @aimane-chnaif! @rushatgabhane am I missing some context here? We moving forward here?

[rushatgabhane]

i think @jayeshmangwani has the root cause and a solution for it #23093 (comment)

[rushatgabhane]

🎀 👀 🎀

[melvin-bot]

📣 @rushatgabhane Please request via NewDot manual requests for the Reviewer role ($1000)

[trjExpensify]

Cool, assigned @jayeshmangwani!

[jayeshmangwani]

@rushatgabhane PR is ready for review

[jayeshmangwani]

@rushatgabhane bump for review, Please!

[melvin-bot]

Based on my calculations, the pull request did not get merged within 3 working days of assignment. Please, check out my computations here:

• when @jayeshmangwani got assigned: 2023-07-21 15:19:51 Z
• when the PR got merged: 2023-08-03 19:00:22 UTC
• days elapsed: 9

On to the next one 🚀

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.51-2 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [NoQA] Fix: console warning by making innerRef optional to PressableWithDelayToggle  #23717

If no regressions arise, payment will be issued on 2023-08-16. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

• @rushatgabhane does not require payment (Eligable for Manual Requests)
• @jayeshmangwani requires payment offer (Reporter)

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@rushatgabhane] The PR that introduced the bug has been identified. Link to the PR:
• [@rushatgabhane] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@rushatgabhane] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@rushatgabhane] Determine if we should create a regression test for this bug.
• [@rushatgabhane] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@trjExpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[rushatgabhane]

1. The PR that introduced the bug has been identified. Link to the PR: New preferences page layout #21852

2. The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: New preferences page layout #21852 (comment)

3. A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: N.A.

4. Determine if we should create a regression test for this bug. No

5. If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again - N.A.

[rushatgabhane]

Created a manual request - https://staging.new.expensify.com/r/2686162480672467

[JmillsExpensify]

@trjExpensify I imagine you're on this tomorrow, just noting I need that payment summary to approve the payment in NewDot.

[trjExpensify]

Yuuuup! Confirming payments as follows:

$1,000 to @rushatgabhane for C+
$1,250 to @jayeshmangwani for the bug fix and bug report. (Paid)

No #urgency bonus being applied as per this.

[rushatgabhane]

@trjExpensify i think we can close the issue.
payment is being tracked in new dot

[trjExpensify]

Cool, if @JmillsExpensify hasn't approved payment reopen it!