-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[HOLD for payment 2023-08-21] [$1000] Offline - Can't leave public room after send message #23572
Comments
Triggered auto assignment to @laurenreidexpensify ( |
Bug0 Triage Checklist (Main S/O)
|
When going online again, OpenReport is called followed by LeaveRoom. |
ProposalPlease re-state the problem that we are trying to solve in this issue.Although the public room was left in offline mode, it appears again on LHN after switching to online. What is the root cause of that problem?When we leave the room in offline mode, the room's report data was optimistically all cleared including its named and only left with When we switched to online, Since the merge did not return the report name, the room's report name is App/src/libs/actions/Report.js Lines 853 to 857 in 2beee7b
What changes do you think we should make in order to solve the problem?This is a known and tricky issue in Onyx and as concluded in the attached thread, there's not so much we can do to completely fix the root cause in Onyx. The key point is we should not use Inside successData: [
{
onyxMethod: Onyx.METHOD.MERGE,
key: `${ONYXKEYS.COLLECTION.REPORT}${reportID}`,
value: _.object(reportKeys, Array(reportKeys.length).fill(null)),
},
], |
@samh-nl You should not post your proposal in this way. You have previously posted a comment yesterday but that was not a proposal. If you have a new proposal, please post it in a new and separate comment. Btw, your proposal looks somewhat similar to mine so be clear about that. |
@tienifr I'd have no problem with posting it in a new comment and reverting my previous post for clarity. |
ProposalPlease re-state the problem that we are trying to solve in this issue.Can't leave public room after send message while offline. What is the root cause of that problem?The cause is that when the user becomes online,
This leads to incorrect behavior, where the set is ignored in favor of the merge (reported before #22064 and #5930). Therefore leaving the room intact. What changes do you think we should make in order to solve the problem?Option 1. Onyx must correctly process merge and set, where set should take precedence if it's called later. What alternative solutions did you explore? (Optional)N/A |
Job added to Upwork: https://www.upwork.com/jobs/~01c85f976eb6d66e14 |
Current assignee @laurenreidexpensify is eligible for the External assigner, not assigning anyone new. |
Triggered auto assignment to Contributor-plus team member for initial proposal review - @mollfpr ( |
Not overdue |
@mollfpr bump for review on these proposals thanks |
Reviewing |
@mollfpr can you confirm if either of the solutions are 👍 |
Triggered auto assignment to @MariaHCD, see https://stackoverflow.com/c/expensify/questions/7972 for more details. |
@tienifr's proposal looks good to me too. |
📣 @mollfpr 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app! |
📣 @tienifr 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app! Offer link |
📣 @namhihi237 🎉 An offer has been automatically sent to your Upwork account for the Reporter role 🎉 Thanks for contributing to the Expensify app! |
PR ready for review #24039 |
Based on my calculations, the pull request did not get merged within 3 working days of assignment. Please, check out my computations here:
On to the next one 🚀 |
@laurenreidexpensify, the PR was merged late because I missed assigning another engineer here before I went OOO on Aug 3rd. @tienifr should still be eligible for the bonus since the PR was ready for review and approved by @mollfpr within 3 working days. |
|
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.53-2 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue: If no regressions arise, payment will be issued on 2023-08-21. 🎊 After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.
For reference, here are some details about the assignees on this issue: As a reminder, here are the bonuses/penalties that should be applied for any External issue:
|
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
|
Payment Summary:
|
all payments have been issued in Upwork @mollfpr can you please confirm checklist steps above thanks |
Thanks, @laurenreidexpensify I'll complete the checklist ASAP. |
No offending PR.
This is a one-time bug, so a regression test should be enough.
|
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Action Performed:
6, B click header => leave room
Expected Result:
public room does not reappear in LHN does not reappear after leaving the room
Actual Result:
public room reappeared in LHN does not reappear after leaving the room
Workaround:
Can the user still use Expensify without this being fixed? Have you informed them of the workaround?
Platforms:
Which of our officially supported platforms is this issue occurring on?
Version Number: 1.3.45-3
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
Screen.Recording.2023-07-25.at.12.25.08.mov
Recording.1337.mp4
Expensify/Expensify Issue URL:
Issue reported by: @namhihi237
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1690263033683239
View all open jobs on GitHub
Upwork Automation - Do Not Edit
The text was updated successfully, but these errors were encountered: