-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: Cannot leave room in offline mode after adding comment #24039
Fix: Cannot leave room in offline mode after adding comment #24039
Conversation
Reviewer Checklist
Screenshots/VideosWeb24039.Web.mp4Mobile Web - Chrome24039.mWeb-Chrome.mp4Mobile Web - Safari24039.mWeb-Safari.mp4Desktop24039.Desktop.mp4iOS24039.iOS.mp4Android24039.Android.mp4 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM and tests well 👍
@MariaHCD Can you help take a look at my PR? Thanks |
@MariaHCD This PR is not merged within 3 days, can you help take a look at it? Thanks |
@mollfpr I found out that Maria was OOO and we don't know when she would get back. Thus I wonder if you can assign another CME so that this could get proceed quickly. |
Apologies for the delay here! |
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
🚀 Deployed to staging by https://github.com/MariaHCD in version: 1.3.53-0 🚀
|
🚀 Deployed to production by https://github.com/yuwenmemon in version: 1.3.53-2 🚀
|
Details
In offline mode, if we added a comment then left a public room, it would be re-joined when we get back online. This PR fixes that.
Fixed Issues
$ #23572
PROPOSAL: #23572 (comment)
Tests
Offline tests
NA
QA Steps
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)myBool && <MyComponent />
.src/languages/*
files and using the translation methodWaiting for Copy
label for a copy review on the original GH to get the correct copy.STYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)/** comment above it */
this
properly so there are no scoping issues (i.e. foronClick={this.submit}
the methodthis.submit
should be bound tothis
in the constructor)this
are necessary to be bound (i.e. avoidthis.submit = this.submit.bind(this);
ifthis.submit
is never passed to a component event handler likeonClick
)StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Web
leaveroom-compressed.mov
Mobile Web - Chrome
video_2023-08-02_19-33-48.mp4
Mobile Web - Safari
leaveroom-safari-compressed.mov
Desktop
leaveroom-desktop-compressed.mov
iOS
leaveroom-ios-compressed.mov
Android
leaveroom-android-compressed.mov