[HOLD for payment 2023-09-27] [$500] Web - The delete confirmation modal fails to close when removing a member from another tab

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Navigate to Settings > Workspace > New workspace.
2. Go to the Members section.
3. Invite a member to the workspace.
4. Select the member and click on "Remove."
5. Copy the URL and paste it into another tab.
6. In the new tab, remove the member.
7. Return to the previous tab.
8. The delete confirmation modal does not close, and the member is removed.

Expected Result:

The delete confirmation modal should close when a member is removed from another tab

Actual Result:

The delete confirmation modal does not close when removing a member from another tab

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.60.1
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

screen-recording-2023-08-25-at-21217-am_rzKSe8Rl.mp4

Recording.4126.mp4

Expensify/Expensify Issue URL:
Issue reported by: @ayazhussain79
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1692912070414399

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01f4dfb3829fccd609
• Upwork Job ID: 1699049489764618240
• Last Price Increase: 2023-09-12
• Automatic offers:
• mollfpr | Reviewer | 26664911
• DylanDylann | Contributor | 26664913

[GItGudRatio]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Delete Confirmation message does not disappear when a member is removed from another tab

What is the root cause of that problem?

In WorkspaceMembersPage, in ConfirmModal, we use the removeMembersConfirmModalVisible state to determine if the confirmation should be shown.

When the modal is open and a user is removed, we do not update this state.

What changes do you think we should make in order to solve the problem?

We need to update the state value of removeMembersConfirmModalVisible to false whenever a user is removed from the workspace.

In my opinion, if any member of a workspace is removed and the modal is open, it should close so that the user can re consider. To implement this, we need to add setRemoveMembersConfirmModalVisible(false); here:

App/src/pages/workspace/WorkspaceMembersPage.js

Lines 111 to 119 in 3e69406

	useEffect(() => {
	setSelectedEmployees((prevSelected) =>
	_.intersection(
	prevSelected,
	_.map(_.values(PolicyUtils.getMemberAccountIDsForWorkspace(props.policyMembers, props.personalDetails)), (accountID) => Number(accountID)),
	),
	);
	// eslint-disable-next-line react-hooks/exhaustive-deps
	}, [props.policyMembers]);

What alternative solutions did you explore? (Optional)

If we only want to dismiss the modal if the selected users have changed, we can modify the callback used in setSelectedEmployees so that the modal only dismissed if selected employees change.

[melvin-bot]

Triggered auto assignment to @bfitzexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[melvin-bot]

@bfitzexpensify Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[bfitzexpensify]

Sending this external

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01f4dfb3829fccd609

[melvin-bot]

Current assignee @bfitzexpensify is eligible for the External assigner, not assigning anyone new.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @mollfpr (External)

[mollfpr]

I think the modal should be dismissed whenever the list member is changed (added or removed member).

@bfitzexpensify What do you think?

[bfitzexpensify]

I agree, that behaviour makes sense to me

[DylanDylann]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Web - The delete confirmation modal fails to close when removing a member from another tab

What is the root cause of that problem?

We don't call setRemoveMembersConfirmModalVisible(false) when accountIDs list changes

1. Add new accountID
2. Remove AccountID
3. Update accountID (in case inviting the new user (not exist yet) explain below)

What changes do you think we should make in order to solve the problem?

we can use usePrevious to save the accountIDs and dismiss modal when the accountIDs changed like this

const accountIDs = useMemo(() => _.keys(props.policyMembers), [props.policyMembers])
   const prevAccountIDs = usePrevious(accountIDs);
   useEffect(() => {
       if (removeMembersConfirmModalVisible && !_.isEqual(accountIDs, prevAccountIDs)) {
           setRemoveMembersConfirmModalVisible(false);
       }    
       setSelectedEmployees((prevSelected) =>
           _.intersection(
               prevSelected,
               _.map(_.values(PolicyUtils.getMemberAccountIDsForWorkspace(props.policyMembers, props.personalDetails)), (accountID) => Number(accountID)),
           ),
       );
       // eslint-disable-next-line react-hooks/exhaustive-deps
   }, [props.policyMembers]);

With this approach,

1. Adding new user (not exist yet) will dismiss the modal
2. Adding existing user will not dismiss the modal
3. Remove any member will dismiss the modal
   In point 1, we will dismiss modal because when invite new user offline (not exist yet) we will create optimistic accountID and when coming back online the BE will return another accountID for that user (you also see that the avatar of that user changed). It looks like that we remove the optimistic accountID and add new accountID for that user

[mollfpr]

In my opinion, if any member of a workspace is removed and the modal is open, it should close so that the user can re consider. To implement this, we need to add setRemoveMembersConfirmModalVisible(false); here:

@GItGudRatio Could you be more specific, is it inside the useEffect or the useState callback?

---

@DylanDylann May I ask why we're not using the props.policyMembers instead for the dependencies?

[GItGudRatio]

@mollfpr it's inside the useEffect, above the useState callback.

[bfitzexpensify]

@mollfpr how are things looking here? Seems like we're still working on finding the right proposal?

[mollfpr]

Sorry for the delay! Testing the proposals now.

[DylanDylann]

@mollfpr we can use props.personaldetail.length or data.length as dependency but i think we shouldn't use personalDetail or data because we only want dismiss modal if the number of member change

[mollfpr]

@mollfpr we can use props.personaldetail.length or data.length as dependency but i think we shouldn't use personalDetail or data because we only want dismiss modal if the number of member change

@DylanDylann I'm not sure I understand your point here. Your proposal is using data.length.

@GItGudRatio Could you update your RCA for this expected behavior here? Your solution works for removed users and when new users are added. Just to clarify that you're RCA is correct with the new expected.

[DylanDylann]

@mollfpr We don't want to dismiss the modal if the display name of a member changes, right? So that, we only should put data.length or props.policyMembers.length as dependency of useEfffect

[DylanDylann]

Updated proposal: #26409 (comment) with alternative solution

[melvin-bot]

Triggered auto assignment to @johnmlee101, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[melvin-bot]

📣 @mollfpr 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job

[melvin-bot]

📣 @DylanDylann 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[melvin-bot]

📣 @ayazhussain79 We're missing your Upwork ID to automatically send you an offer for the Reporter role.
Once you apply to the Upwork job, your Upwork ID will be stored and you will be automatically hired for future jobs!

[melvin-bot]

@johnmlee101 @mollfpr @bfitzexpensify @DylanDylann this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

[DylanDylann]

@mollfpr The PR is ready for review

[melvin-bot]

🎯 ⚡️ Woah @mollfpr / @DylanDylann, great job pushing this forwards! ⚡️

The pull request got merged within 3 working days of assignment, so this job is eligible for a 50% #urgency bonus 🎉

• when @DylanDylann got assigned: 2023-09-14 02:15:10 Z
• when the PR got merged: 2023-09-18 03:00:09 UTC

On to the next one 🚀

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.71-12 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Fix/26409: Reset confirmation modal if accountIDs changed #27411

If no regressions arise, payment will be issued on 2023-09-27. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

• @mollfpr requires payment offer (Reviewer)
• @DylanDylann requires payment offer (Contributor)
• @ayazhussain79 requires payment

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@mollfpr] The PR that introduced the bug has been identified. Link to the PR:
• [@mollfpr] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@mollfpr] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@mollfpr] Determine if we should create a regression test for this bug.
• [@mollfpr] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@bfitzexpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[mollfpr]

[@mollfpr] The PR that introduced the bug has been identified. Link to the PR:
[@mollfpr] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:

No offending PRs. This improvement is to close the modal whenever the list is changed.

[@mollfpr] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:

The regression step should be enough.

[@mollfpr] Determine if we should create a regression test for this bug.
[@mollfpr] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.

1. Navigate to Settings > Workspace > New workspace.
2. Go to the Members section.

The confirmation modal should be closed when a new member is added in another tab/device

3. Invite a member to the workspace.
4. Select the member and click on "Remove."
5. Copy the URL and paste it into another tab.
6. In the new tab, remove the member.
7. Return to the previous tab.
8. Verify that the delete confirmation modal is closed

The confirmation modal should be closed when a new user is added from offline

3. Go offline
4. Invite a member (not exist yet like "qweqwe@gmail.com") to the workspace.
5. Select the member and click on "Remove."
6. Go online
7. Verify that the delete confirmation modal is closed

The confirmation modal remains when existed user is added from offline

3. Go offline
4. Invite a member (who we chatted before) to the workspace.
5. Select the member and click on "Remove."
6. Go online
7. Verify that the delete confirmation modal still remained

[melvin-bot]

@johnmlee101, @mollfpr, @bfitzexpensify, @DylanDylann Eep! 4 days overdue now. Issues have feelings too...

[bfitzexpensify]

All payments complete, issue opened for the regression test, we're good to close this one out. Thanks for the work, everyone!