-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[$500] Request - Participant deep link opens Participant page briefly and keyboard opens in Scan #30127
Comments
Triggered auto assignment to @anmurali ( |
Job added to Upwork: https://www.upwork.com/jobs/~014061867ab191f52d |
Bug0 Triage Checklist (Main S/O)
|
Triggered auto assignment to Contributor-plus team member for initial proposal review - @abdulrahuman5196 ( |
We already have #26538 to remove support for money request deep links. |
can you check if the refactoring issue is really removing the deep link? If I remember correctly, I think @tgolen is making change in a way that still supports deep linking to money-request related pages |
You are right, looks like we are doubling down on supporting money requests as I read discussion further. my bad. |
ProposalPlease re-state the problem that we are trying to solve in this issue.If Scan option is originally selected (where the keyboard is not normally needed), coming there using a Participant deep link opens the keyboard briefly. What is the root cause of that problem?With the introduction of the What changes do you think we should make in order to solve the problem?The same platform specific constraint ( What alternative solutions did you explore? (Optional)NA Additional noteNote that Also note that I could not reproduce the part where the participant list appeared briefly first, but I do believe this solution should resolve the issue of the keyboard unnecessarily opening in that case as well, otherwise it should probably be investigated as a separate issue. |
📣 @benomatis! 📣
|
✅ Contributor details stored successfully. Thank you for contributing to Expensify! |
ProposalPlease re-state the problem that we are trying to solve in this issue.Participant deep link opens Participant page briefly and keyboard opens in Scan What is root cause of that problem?When a user opens participant page from deeplink we render App/src/pages/iou/steps/MoneyRequstParticipantsPage/MoneyRequestParticipantsPage.js Lines 97 to 99 in 3f32b7d
The problem is that we don’t wait for the checks inside the This is the first root cause. The other problem happens when we try to access an index property that is undefined What Changes do you think we should make in order to solve the problem?We first need to know whether we will navigate back or not before rendering the App/src/pages/iou/steps/MoneyRequstParticipantsPage/MoneyRequestParticipantsPage.js Line 106 in 844b3b9
then set App/src/pages/iou/steps/MoneyRequstParticipantsPage/MoneyRequestParticipantsPage.js Lines 97 to 99 in 3f32b7d
For the second issue, we need to add an What alternative solutions did you explore? (Optional) |
|
Reviewing now. Sorry for the delay. |
📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸 |
Working on the review today. If not complete by today, will re-assign to fast up the issue. |
Checking now |
@benomatis I am able to understand the root cause and solution mentioned here #30127 (comment). Could you provide more update on the same? |
@HezekielT I was testing out the proposal here #30127 (comment) It is working if the app is in quit state, but if we have the app open/background state the fix is not working. |
AFAIK, when we have a draft request like Request -> fill something -> participants page, quit app. Now if you deeplink to the participants page it should stay there and open the keyboard. So I am not sure if hiding is the keyboard is the best way. |
Isn't the participant list hidden here because it's not needed? It's not even offered as an option, unless I'm missing something. If it does need to be hidden, the forced focus is redundant as the relevant input field would not be present. |
@abdulrahuman5196 Thanks for the feedback. I tested both cases and it's working for me. I have attached a video for both cases. Please let me know if I'm missing something. Thanks! Opening the deep link after quitting the appScreencast-keyboard-quit.movOpening the deep link while the app is in background stateScreencast-keyboard-background.mov |
Reviewing now |
@HezekielT Just now tested with latest main. I am not able to see the keyboard. But its doing double navigation. Screen.Recording.2023-11-02.at.11.18.26.PM.mp4 |
@abdulrahuman5196 I looked into the double navigation issue and it seems the while the second one is when we have In both cases, We can solve it by calling the
We can also improve the This double navigation issue is also reproducible on main by the way. Screencast.mov |
Hi! I was looking at this, and I think the problem is solved in my PR that refactors these components. This can probably be closed as |
@anmurali @abdulrahuman5196 this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks! |
📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸 |
Just back from weekend |
@anmurali, @abdulrahuman5196 Whoops! This issue is 2 days overdue. Let's get this updated quick! |
1 similar comment
@anmurali, @abdulrahuman5196 Whoops! This issue is 2 days overdue. Let's get this updated quick! |
@anmurali @abdulrahuman5196 this issue is now 3 weeks old. There is one more week left before this issue breaks WAQ and will need to go internal. What needs to happen to get a PR in review this week? Please create a thread in #expensify-open-source to discuss. Thanks! |
📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸 |
📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸 |
@anmurali, @abdulrahuman5196 Still overdue 6 days?! Let's take care of this! |
Closing per #30127 (comment) |
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Version Number: 1.3.88-3
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:
Issue found when executing PR #26149
Action Performed:
Precondition: Make sure Scan tab is selected when Request money tab is opened
in chat
Expected Result:
User is redirected to Request money selector page without opening Participants page and keyboard
Actual Result:
The link opens Participants page briefly with keyboard showing up. Sometimes Participants page is not shown but keyboard still appears
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
Screenshots/Videos
Android: Native
Bug6245643_1697905602424.Screen_Recording_20231021_205927_New_Expensify__2_.mp4
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
MacOS: Desktop
View all open jobs on GitHub
Upwork Automation - Do Not Edit
The text was updated successfully, but these errors were encountered: