-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Web - App allows user to open request money link of other user and displays amount page twice #26149
Conversation
@sobitneupane Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
@dukenv0307 Let's add test steps for some other components which use |
@sobitneupane I updated the test step. Do you agree with this? And I will update the screenshots if you agree. |
@sobitneupane Any update here #26149 (comment). |
@dukenv0307 Yup. Test steps look good. |
@sobitneupane I updated all screenshots. For the case 3 in desktop, because this issue #27085 always happens in desktop, I will update this after this issue is merged. |
This issue is blocking me from testing. Fortunately, I am assigned to the issue. I will try to get it merged today. After that I will continue the review. Other than that, @dukenv0307 I'm encountering a 'Not Found' page when attempting to request money from FAB. |
@sobitneupane Can you share the test step? |
FAB > Request Money is basically what I did. I might have shared a link of Money Request confirmation page before that. |
@dukenv0307 As of now, this PR only solves the issue for Will the case of |
@sobitneupane It's not complex so I think we can handle this here. The root cause is invalid reportID makes
|
@sobitneupane This is fixed in latest main. |
@dukenv0307 This issue is still reproducible in my end. Did you get chance to look at it? Screen.Recording.2023-10-02.at.14.07.17.mov |
@sobitneupane This still works well in my end Screencast.from.02-10-2023.15.33.37.webm |
@dukenv0307 Bit surprising, but it's not working on my end. I'm not sure of the exact reason; maybe some beta feature enabled on my account is causing the crash. Could you try it with a highly trafficked account? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewer Checklist
- I have verified the author checklist is complete (all boxes are checked off).
- I verified the correct issue is linked in the
### Fixed Issues
section above - I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the
Tests
section - I verified the steps for Staging and/or Production testing are in the
QA steps
section - I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I verified the steps for local testing are in the
- I checked that screenshots or videos are included for tests on all platforms
- I included screenshots or videos for tests on all platforms
- I verified tests pass on all platforms & I tested again on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
- If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
- I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e.
toggleReport
and notonIconClick
). - I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g.
myBool && <MyComponent />
. - I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to
src/languages/*
files and using the translation method - I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the
Waiting for Copy
label for a copy review on the original GH to get the correct copy. - I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in
STYLE.md
) were followed
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e.
- If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
- I verified that this PR follows the guidelines as stated in the Review Guidelines
- I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like
Avatar
, I verified the components usingAvatar
have been tested & I retested again) - I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
- I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
- If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a
/** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to
this
properly so there are no scoping issues (i.e. foronClick={this.submit}
the methodthis.submit
should be bound tothis
in the constructor) - Any internal methods bound to
this
are necessary to be bound (i.e. avoidthis.submit = this.submit.bind(this);
ifthis.submit
is never passed to a component event handler likeonClick
) - All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
- If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
- If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e.
StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG
)
- If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
- If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like
Avatar
is modified, I verified thatAvatar
is working as expected in all cases) - If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
- If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
- If a new page is added, I verified it's using the
ScrollView
component to make it scrollable when more elements are added to the page. - If the
main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps. - I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.
@sobitneupane Just updated the code the fix the case in #27113 as well |
Hi! It looks like this has expanded just a little since the proposal, do you mind giving me a summary of the new ideas? I think the things I noticed are:
Nothing is standing out as bad, but I would love some of the context before doing a full review - thank you! |
This is another case that is introduced in #27113
Yes
Do you think about |
@dangrous any thought in my comment above. |
Hi! Sorry, still catching up on stuff. Should be able to look at this shortly. |
Okay, so apologies for all the questions. I have a couple more clarifications. Your explanations up there made sense though! So in the new logic:
I do prefer Tests okay, I'm just still struggling to make sure I understand the code. If you could add some comments in - for me and for future developers - that would be great! |
Yes, that will be the case for all components using the HOC now except
When
Yes if there is not a reportID in the route, it will just show the Wrapped Component. And in the |
@dangrous Update the variable, and add some comments. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the explanation! This looks good - one last variable change to make it a bit clearer and then I think we're good to merge!
Co-authored-by: Daniel Gale-Rosen <5487802+dangrous@users.noreply.github.com>
Co-authored-by: Daniel Gale-Rosen <5487802+dangrous@users.noreply.github.com>
@dangrous updated. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sweet!
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
🚀 Deployed to staging by https://github.com/dangrous in version: 1.3.88-0 🚀
|
🚀 Deployed to production by https://github.com/chiragsalian in version: 1.3.88-11 🚀
|
Details
Web - App allows user to open request money link of other user and displays amount page twice
Fixed Issues
$ #23755
PROPOSAL: #23755 (comment)
Tests
reportID
reportID
param to an invalid value, and send the messagereportID
param to a report that cannot create the request money. i.e. the ID of the group chat or announce room, and send the messageOffline tests
QA Steps
reportID
reportID
param to an invalid value, and send the messagereportID
param to a report that cannot create the request money. i.e. the ID of the group chat or announce room, and send the messagePR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)myBool && <MyComponent />
.src/languages/*
files and using the translation methodWaiting for Copy
label for a copy review on the original GH to get the correct copy.STYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)/** comment above it */
this
properly so there are no scoping issues (i.e. foronClick={this.submit}
the methodthis.submit
should be bound tothis
in the constructor)this
are necessary to be bound (i.e. avoidthis.submit = this.submit.bind(this);
ifthis.submit
is never passed to a component event handler likeonClick
)StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Web
reportID
web.3.mp4
Screencast.from.19-09-2023.15.18.08.webm
Screencast.from.19-09-2023.15.37.37.webm
Screencast.from.19-09-2023.15.44.24.webm
Mobile Web - Chrome
- Request money with invalid `reportID`chrome.mov
Record_2023-09-19-15-38-43.mp4
Record_2023-09-19-15-26-38.mp4
Record_2023-09-19-15-45-57.mp4
Mobile Web - Safari
- Request money with invalid `reportID`safari.mov
Screen.Recording.2023-09-19.at.15.32.08.mp4
Screen-Recording-2023-09-19-at-15.41.07.mp4
Screen-Recording-2023-09-19-at-15.47.01.mp4
Desktop
- Request money with invalid `reportID`desktop.mov
Screen.Recording.2023-09-19.at.15.59.39.mov
Request money with global FAB
Test the HOC for some other components
Screen-Recording-2023-09-19-at-16.44.31.mp4
iOS
- Request money with invalid `reportID`ios.mov
Screen.Recording.2023-09-19.at.15.50.35.mp4
Screen-Recording-2023-09-19-at-15.52.13.mp4
Screen.Recording.2023-09-19.at.15.52.55.mp4
Android
- Request money with invalid `reportID`android.mov
23755-1.webm
23755-2.mp4
223755-3.mp4