-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[HOLD for payment 2024-01-04] [HOLD for payment 2024-01-03] [$500] Scan Split - Entered amount is not saved in split scan details view #33587
Comments
Job added to Upwork: https://www.upwork.com/jobs/~012f97d51fb2a55a23 |
Triggered auto assignment to @anmurali ( |
Bug0 Triage Checklist (Main S/O)
|
Triggered auto assignment to Contributor-plus team member for initial proposal review - @allroundexperts ( |
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
|
Triggered auto assignment to @pecanoro ( |
Maybe #32533 is the PR |
ProposalPlease re-state the problem that we are trying to solve in this issue.The entered amount is not saved. What is the root cause of that problem?Regression from this PR #32533 Amount is NaN here when we convert
App/src/pages/EditSplitBillPage.js Line 109 in de5a943
What changes do you think we should make in order to solve the problem?Change this line to
App/src/pages/EditSplitBillPage.js Line 109 in de5a943
OPTIONAL: We can also return curreny as What alternative solutions did you explore? (Optional)NA |
@dukenv0307's proposal looks good to me. 🎀 👀 🎀 C+ reviewed |
Current assignee @pecanoro is eligible for the choreEngineerContributorManagement assigner, not assigning anyone new. |
📣 @dukenv0307 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app! Offer link |
Sounds good! Since this is deploy blocker, let's try to get this merged today! |
📣 @situchan 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app! Offer link |
Going to reassig to @situchan because this is a deploy blocker and we need to fix this with urgency and @allroundexperts is not available |
|
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.17-8 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue: If no regressions arise, payment will be issued on 2024-01-03. 🎊 After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.
For reference, here are some details about the assignees on this issue:
|
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
|
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.18-8 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue: If no regressions arise, payment will be issued on 2024-01-04. 🎊 After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.
For reference, here are some details about the assignees on this issue:
|
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
|
|
@anmurali Can you handle the payment whenever you have a moment? Thanks! |
@pecanoro, @anmurali, @situchan, @dukenv0307 Uh oh! This issue is overdue by 2 days. Don't forget to update your issues! |
Paid. |
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Version Number: v1.4.17-1
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause-Internal Team
Slack conversation: @
Action Performed:
3 .Create a scan split bill.
Expected Result:
The entered amount is saved.
Actual Result:
The entered amount is not saved.
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
Screenshots/Videos
Bug6326129_1703591286290.bandicam_2023-12-26_16-28-52-726.mp4
View all open jobs on GitHub
Upwork Automation - Do Not Edit
Issue Owner
Current Issue Owner: @anmuraliThe text was updated successfully, but these errors were encountered: