[HOLD for payment 2024-01-04] [HOLD for payment 2024-01-03] [$500] Scan Split - Entered amount is not saved in split scan details view

[izarutskaya]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: v1.4.17-1
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause-Internal Team
Slack conversation: @

Action Performed:

1. Go to workspace chat > + > Split bill.
2. Go to Scan.
   3 .Create a scan split bill.
3. Click on the bill split preview.
4. Click amount.
5. Enter amount and save it.

Expected Result:

The entered amount is saved.

Actual Result:

The entered amount is not saved.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6326129_1703591286290.bandicam_2023-12-26_16-28-52-726.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~012f97d51fb2a55a23
• Upwork Job ID: 1739640051172978688
• Last Price Increase: 2023-12-26
• Automatic offers:
• dukenv0307 | Contributor | 28070204
• situchan | Contributor | 28070454

Issue Owner

Current Issue Owner: @anmurali

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~012f97d51fb2a55a23

[melvin-bot]

Triggered auto assignment to @anmurali (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @allroundexperts (External)

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @pecanoro (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[shubham1206agra]

Maybe #32533 is the PR

[dukenv0307]

Proposal

Please re-state the problem that we are trying to solve in this issue.

The entered amount is not saved.

What is the root cause of that problem?

Regression from this PR #32533

Amount is NaN here when we convert transactionChanges to number because now it is an object.

App/src/pages/iou/steps/MoneyRequestAmountForm.js

Line 231 in de5a943

onSubmitButtonPress({amount: currentAmount, currency});

App/src/pages/EditSplitBillPage.js

Line 109 in de5a943

const amount = CurrencyUtils.convertToBackendAmount(Number.parseFloat(transactionChanges));

What changes do you think we should make in order to solve the problem?

Change this line to

const amount = CurrencyUtils.convertToBackendAmount(Number.parseFloat(transactionChanges.amount));

App/src/pages/EditSplitBillPage.js

Line 109 in de5a943

const amount = CurrencyUtils.convertToBackendAmount(Number.parseFloat(transactionChanges));

OPTIONAL: We can also return curreny as transactionChanges.currency instead of return currency

What alternative solutions did you explore? (Optional)

NA

[allroundexperts]

@dukenv0307's proposal looks good to me. 🎀 👀 🎀 C+ reviewed

[melvin-bot]

Current assignee @pecanoro is eligible for the choreEngineerContributorManagement assigner, not assigning anyone new.

[melvin-bot]

📣 @dukenv0307 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[pecanoro]

Sounds good! Since this is deploy blocker, let's try to get this merged today!

[melvin-bot]

📣 @situchan 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[mountiny]

Going to reassig to @situchan because this is a deploy blocker and we need to fix this with urgency and @allroundexperts is not available

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.17-8 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [CP Staging] Fix amount isn't saved when editting split scan request #33599

If no regressions arise, payment will be issued on 2024-01-03. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

• @situchan requires payment automatic offer (Contributor)
• @dukenv0307 requires payment automatic offer (Contributor)

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@situchan] The PR that introduced the bug has been identified. Link to the PR:
• [@situchan] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@situchan] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@situchan] Determine if we should create a regression test for this bug.
• [@situchan] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@anmurali] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.18-8 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [CP Staging] Fix amount isn't saved when editting split scan request #33599

If no regressions arise, payment will be issued on 2024-01-04. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

• @situchan requires payment automatic offer (Contributor)
• @dukenv0307 requires payment automatic offer (Contributor)

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@situchan] The PR that introduced the bug has been identified. Link to the PR:
• [@situchan] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@situchan] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@situchan] Determine if we should create a regression test for this bug.
• [@situchan] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@anmurali] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[situchan]

• The PR that introduced the bug has been identified. Link to the PR: Create updateMoneyRequestAmountOrCurrency #32533 which fixes [HOLD for payment 2024-01-03] [DISTANCE] LOW: UpdateDistanceRequest 1:1:1 - UpdateMoneyRequestAmount - Split out into its own command #32316
• The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: Create updateMoneyRequestAmountOrCurrency #32533 (comment)
• A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: N/A
• Determine if we should create a regression test for this bug. N/A as caught by QA team
• If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.

[pecanoro]

@anmurali Can you handle the payment whenever you have a moment? Thanks!

[melvin-bot]

@pecanoro, @anmurali, @situchan, @dukenv0307 Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[anmurali]

Paid.