Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deploy Checklist: New Expensify 2023-12-26 #33576

Closed
42 tasks done
github-actions bot opened this issue Dec 26, 2023 · 11 comments
Closed
42 tasks done

Deploy Checklist: New Expensify 2023-12-26 #33576

github-actions bot opened this issue Dec 26, 2023 · 11 comments
Assignees
Labels
Daily KSv2 🔐 LockCashDeploys 🔐 Prevent new code from being deployed to staging StagingDeployCash

Comments

@github-actions
Copy link
Contributor

github-actions bot commented Dec 26, 2023

Release Version: 1.4.17-8
Compare Changes: production...staging

This release contains changes from the following pull requests:

Deploy Blockers:

Deployer verifications:

  • I checked the App Timing Dashboard and verified this release does not cause a noticeable performance regression.
  • I checked Firebase Crashlytics and verified that this release does not introduce any new crashes. More detailed instructions on this verification can be found here.
  • I checked GitHub Status and verified there is no reported incident with Actions.

cc @Expensify/applauseleads

@mountiny
Copy link
Contributor

@rushatgabhane Should #33335 be noQA?

@mountiny mountiny added the 🔐 LockCashDeploys 🔐 Prevent new code from being deployed to staging label Dec 26, 2023
@mountiny mountiny self-assigned this Dec 26, 2023
@mountiny mountiny added the Daily KSv2 label Dec 26, 2023
@OSBotify
Copy link
Contributor

🚀 All staging deploys are complete, @Expensify/applauseleads please begin QA on version https://github.com/Expensify/App/releases/tag/1.4.17-1 🚀

@rushatgabhane
Copy link
Member

rushatgabhane commented Dec 26, 2023

@rushatgabhane Should #33335 be noQA?

@mountiny yes it should be No QA. Updated the title

@mountiny
Copy link
Contributor

Checking #31010 off as that was reverted in previous deploy

@kbecciv
Copy link

kbecciv commented Dec 26, 2023

Regression is 80% progress.

#31010 is failing with #30190, checked off per comment #33576 (comment)
#33347 is failing with #33611, repro on Prod - checking off
#33440 failing on Web with #33592, repro on Prod - checking off
#33516 failing on mWeb, Desktop and IOS app with #33512, repro on Prod - checking off.
#32267 is failing with #33628, repro on Prod - checking off

Deploy Blockers:
#33587
#33588
#33589
#33590
#33591
#33594
#33602
#33614
#33616

@kbecciv
Copy link

kbecciv commented Dec 27, 2023

Regression is completed.

#31010 is failing with #30190, checked off per comment #33576 (comment)
#33347 is failing with #33611, repro on Prod - checking off
#33440 failing on Web with #33592, repro on Prod - checking off
#33516 failing on mWeb, Desktop and IOS app with #33512, repro on Prod - checking off.
#32267 is failing with #33628, repro on Prod - checking off

Deploy Blocker:
#33626

@mountiny
Copy link
Contributor

#33599 fixed in staging
#33604 fixed in staging
#33629 fixed in staging
#33631 fixed in staging
#33634 fixed in staging
#33636 fixed in staging

@mountiny
Copy link
Contributor

:shipit:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Daily KSv2 🔐 LockCashDeploys 🔐 Prevent new code from being deployed to staging StagingDeployCash
Projects
None yet
Development

No branches or pull requests

5 participants