-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[$500] mWeb - Settings - Transitions not smooth in settings navigation #33628
Comments
Job added to Upwork: https://www.upwork.com/jobs/~015d4616de7bef61fc |
Triggered auto assignment to @bfitzexpensify ( |
Bug0 Triage Checklist (Main S/O)
|
Triggered auto assignment to Contributor-plus team member for initial proposal review - @thesahindia ( |
ProposalWhen workspace, Preferences, Security are clicked in settings, there is no stacking over animation from left side Root CauseDue to heavy lottie Illustrations, the transition animation is inturupted and there is noticable stuck of transition sometimes Changes
useEffect(() => {
InteractionManager.runAfterInteractions(() => {
animationRef.current.play();
});
}, []); or onEntryTransitionEnd={() => animationRef.current.play(); } |
ProposalPlease re-state the problem that we are trying to solve in this issue.Transitions not smooth in settings navigation What is the root cause of that problem?Because the Lottie component is so heavy, and it's rendered while RHP is moving -> transition is not smooth What changes do you think we should make in order to solve the problem?We should wait for transition end then render the Lottie component
What alternative solutions did you explore? (Optional)Instead of showing the empty placeholder we can create the thumbnail and just show it when ResultScreen.Recording.2023-12-27.at.17.51.27.mov |
Couple of proposals ready for review @thesahindia |
@bfitzexpensify, @thesahindia Whoops! This issue is 2 days overdue. Let's get this updated quick! |
I couldn't repro the issue - Screen.Recording.2024-01-02.at.1.22.58.AM.mov |
Likewise - things are fine when I've tried to reproduce. Let's close this out |
Issue is reproducible on Android/Chrome, build 1.4.23.0 Screen_Recording_20240109_222340_Chrome.2.mp4 |
📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸 |
@bfitzexpensify @thesahindia this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks! |
I still wasn't able to reproduce this on either 1.4.23.0 or 1.4.24.0: 2024-01-10_10-52-39.mp4@kbecciv is it happening on the latest build? I'm going to be mostly ooo until Jan 29, assigning a second BZ team member to keep an eye on this.
|
Issue is reproducible in Android mWeb version 1.4.24-7. az_recorder_20240112_155207.MP4 |
@bfitzexpensify, @thesahindia Uh oh! This issue is overdue by 2 days. Don't forget to update your issues! |
📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸 |
@bfitzexpensify @thesahindia this issue is now 3 weeks old. There is one more week left before this issue breaks WAQ and will need to go internal. What needs to happen to get a PR in review this week? Please create a thread in #expensify-open-source to discuss. Thanks! |
@bfitzexpensify, @thesahindia Huh... This is 4 days overdue. Who can take care of this? |
Hm, looks like my label adding didn't work last week. Re-adding a second BZ team member from my comment in #33628 (comment). |
Triggered auto assignment to @CortneyOfstad ( |
@CortneyOfstad and @thesahindia - are either of you able to reproduce this? |
Sorry for the delay here – no, I am unable to reproduce. @thesahindia are you able to? |
Same here. Not reproducible for me. |
Okay, let's close this 👍 |
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Version Number: 1.4.17.1
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal team
Slack conversation:
Issue found when executing PR #32267
Action Performed:
Expected Result:
Transaction should be smooth
Actual Result:
Transitions not smooth in settings navigation
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
Screenshots/Videos
Add any screenshot/video evidence
32267.Desktop.mp4
View all open jobs on GitHub
Upwork Automation - Do Not Edit
The text was updated successfully, but these errors were encountered: