[$500] mWeb - Settings - Transitions not smooth in settings navigation

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.17.1
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal team
Slack conversation:

Issue found when executing PR #32267

Action Performed:

1. Go to staging.new.expensify.com
2. Go to Go to Settings
3. Navigate to some pages

Expected Result:

Transaction should be smooth

Actual Result:

Transitions not smooth in settings navigation

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

32267.Desktop.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~015d4616de7bef61fc
• Upwork Job ID: 1739766508742758400
• Last Price Increase: 2024-01-16

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~015d4616de7bef61fc

[melvin-bot]

Triggered auto assignment to @bfitzexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @thesahindia (External)

[ishpaul777]

Proposal

When workspace, Preferences, Security are clicked in settings, there is no stacking over animation from left side

Root Cause

Due to heavy lottie Illustrations, the transition animation is inturupted and there is noticable stuck of transition sometimes

Changes

1. We need to remove autoplay from Lottie component and play after all interactions, we can either use InteractionManager.runAfterInteractions or onEntryTransitionEnd prop in ScrenWrapper by passing it in HeaderPageLayout in IllustratedHeaderPageLayout

useEffect(() => {
        InteractionManager.runAfterInteractions(() => {
            animationRef.current.play();
        });
    }, []);

or

  onEntryTransitionEnd={() =>  animationRef.current.play(); } 

[tienifr]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Transitions not smooth in settings navigation

What is the root cause of that problem?

Because the Lottie component is so heavy, and it's rendered while RHP is moving -> transition is not smooth

What changes do you think we should make in order to solve the problem?

We should wait for transition end then render the Lottie component

1. In Lottie, add new props showShowPlaceHolder, and if it's true, we will show the placeholder

    if (isError || showShowPlaceHolder) {
        return <View style={aspectRatioStyle} />;
    }

2. In IllustratedHeaderPageLayout, we change the headerContent to function

headerContent={
                (didScreenTransitionEnd)=>{
                    return <>
                    <Lottie
                        showShowPlaceHolder={!didScreenTransitionEnd}
...

3. In HeaderPageLayout, we will call headerContent if it's function

            {({safeAreaPaddingBottomStyle, didScreenTransitionEnd}) => (
...
            {_.isFunction(headerContent)? headerContent(didScreenTransitionEnd):headerContent}

What alternative solutions did you explore? (Optional)

Instead of showing the empty placeholder we can create the thumbnail and just show it when didScreenTransitionEnd is false

Result

Screen.Recording.2023-12-27.at.17.51.27.mov

[bfitzexpensify]

Couple of proposals ready for review @thesahindia

[melvin-bot]

@bfitzexpensify, @thesahindia Whoops! This issue is 2 days overdue. Let's get this updated quick!

[thesahindia]

I couldn't repro the issue -

Screen.Recording.2024-01-02.at.1.22.58.AM.mov

[bfitzexpensify]

Likewise - things are fine when I've tried to reproduce. Let's close this out

[kbecciv]

Issue is reproducible on Android/Chrome, build 1.4.23.0

Screen_Recording_20240109_222340_Chrome.2.mp4

[melvin-bot]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[melvin-bot]

@bfitzexpensify @thesahindia this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

[bfitzexpensify]

I still wasn't able to reproduce this on either 1.4.23.0 or 1.4.24.0:

2024-01-10_10-52-39.mp4

@kbecciv is it happening on the latest build?

I'm going to be mostly ooo until Jan 29, assigning a second BZ team member to keep an eye on this.

• this is recently reopened after being closed as non-reproducible, still figuring out if this is an issue we need to address

[kbecciv]

Issue is reproducible in Android mWeb version 1.4.24-7.

az_recorder_20240112_155207.MP4

[melvin-bot]

@bfitzexpensify, @thesahindia Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[melvin-bot]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[melvin-bot]

@bfitzexpensify @thesahindia this issue is now 3 weeks old. There is one more week left before this issue breaks WAQ and will need to go internal. What needs to happen to get a PR in review this week? Please create a thread in #expensify-open-source to discuss. Thanks!

[melvin-bot]

@bfitzexpensify, @thesahindia Huh... This is 4 days overdue. Who can take care of this?

[bfitzexpensify]

Hm, looks like my label adding didn't work last week. Re-adding a second BZ team member from my comment in #33628 (comment).

[melvin-bot]

Triggered auto assignment to @CortneyOfstad (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[bfitzexpensify]

@CortneyOfstad and @thesahindia - are either of you able to reproduce this?

[CortneyOfstad]

Sorry for the delay here – no, I am unable to reproduce. @thesahindia are you able to?

[thesahindia]

Same here. Not reproducible for me.

[CortneyOfstad]

Okay, let's close this 👍