-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Hold for payment - 2024-03-07] MEDIUM: Custom message sound not consistent on mobile #36579
Comments
Triggered auto assignment to @CortneyOfstad ( |
Thanks for bringing this up! As I have written that feature let me take some time trying to reproduce. I'll let you know if I found anything 👀 |
I can also help with backend changes. As you mentioned we may need to start sending a reportType variable -- though I also think we don't send IOU notifications currently |
@kirillzyusko and I discussed. We can drop the message received sound on mobile apps as this is being handled by the OS push notification itself. |
Assigning @abdulrahuman5196 based on this comment |
@Julesssss since the PR was merged - what should we do with that issue? Should we re-test and close it? |
Yeah, I'll try and find time tomorrow to do this. If you're able to verify iOS that would be very helpful. |
@Julesssss does the app publicly available or do I need to get the invite (to TestFlight, for example)? If everyone can test, then would you mind to share a link here? 👀 (sorry for being asking such simple questions, but it's a first time when I'm testing the app deployed to staging) |
No problem. You would need to get invited to Testflight to test staging, but the PR has already been deployed to production, so you can use the App Store app to verify 👍 |
I'm going to close this issue as fixed, but let's discuss the other bugs on their respective issues. |
Hi, @Julesssss C+ payment processing would be pending on this issue. Kindly re-open the issue. cc: @CortneyOfstad |
Awaiting C+ payment |
Not a regression. Update to existing implementation
Yes.
|
We're still making changes to the push notification logic so this test will soon be outdated. We'll create one seperately once the changes are complete. |
Sorry, was OoO last week — handling the payment now! |
@Julesssss in regards to the comment here, is a regression test needed here if there will be separate tests created after the logic is adjusted? Just trying to confirm — thank you! |
@abdulrahuman5196 I sent you a job offer here — https://www.upwork.com/jobs/~01d297cc64a730c705 Not sure why the job did not post originally, but please let me know once you accept and I'll get that paid ASAP. Thanks! |
@CortneyOfstad accepted the offer. Thank you |
Paid! Payment Summary@abdulrahuman5196 — paid $500 via Upwork! |
Hi @CortneyOfstad, no test needed here |
Perfect! This can be closed — thanks everyone! |
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Version Number: 1.4.42-0
Reproducible in staging?: Yes
Action Performed:
Expected Result:
Actual Result:
Workaround:
Can the user still use Expensify without this being fixed? Have you informed them of the workaround?
Platforms:
Which of our officially supported platforms is this issue occurring on?
Screenshots/Videos
Add any screenshot/video evidence
View all open jobs on GitHub
The text was updated successfully, but these errors were encountered: