Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[$250] Notification – Have no sound notification for message #45243

Closed
1 of 6 tasks
izarutskaya opened this issue Jul 11, 2024 · 25 comments
Closed
1 of 6 tasks

[$250] Notification – Have no sound notification for message #45243

izarutskaya opened this issue Jul 11, 2024 · 25 comments
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Engineering External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors retest-weekly Apply this label if you want this issue tested on a Weekly basis by Applause Weekly KSv2

Comments

@izarutskaya
Copy link

izarutskaya commented Jul 11, 2024

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: v9.0.6-0
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/4710904
Email or phone of affected tester (no customers): ponikarchuks+1010724@gmail.com
Logs: https://stackoverflow.com/c/expensify/questions/4856
Issue reported by: Applause-Internal team

Action Performed:

  1. Go to https://staging.new.expensify.com/
  2. Log in as user A
  3. Open chat with user B
  4. As user B send message to user A
  5. Notice that user A receive a notification

Expected Result:

Notification is with sound

Actual Result:

Notification is without sound

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6538637_1720679667689.Sound_notif.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~015271a1c4e784b95c
  • Upwork Job ID: 1813278476392211020
  • Last Price Increase: 2024-08-06
@izarutskaya izarutskaya added DeployBlockerCash This issue or pull request should block deployment Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. DeployBlocker Indicates it should block deploying the API labels Jul 11, 2024
Copy link

melvin-bot bot commented Jul 11, 2024

Triggered auto assignment to @adelekennedy (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

Copy link

melvin-bot bot commented Jul 11, 2024

Triggered auto assignment to @NikkiWines (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

@github-actions github-actions bot added Engineering Hourly KSv2 and removed Daily KSv2 labels Jul 11, 2024
Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@izarutskaya
Copy link
Author

@adelekennedy FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors.

@izarutskaya
Copy link
Author

We think this issue might be related to the #vip-vsb

@NikkiWines NikkiWines removed DeployBlockerCash This issue or pull request should block deployment DeployBlocker Indicates it should block deploying the API labels Jul 11, 2024
@NikkiWines
Copy link
Contributor

NikkiWines commented Jul 11, 2024

Just tested with @Julesssss and we weren't able to reproduce this issue with the app either fully killed or just backgrounded so this needs reproduction

@NikkiWines NikkiWines added Needs Reproduction Reproducible steps needed Daily KSv2 and removed Hourly KSv2 labels Jul 11, 2024
@NikkiWines NikkiWines removed their assignment Jul 11, 2024
@MelvinBot
Copy link

This has been labelled "Needs Reproduction". Follow the steps here: https://stackoverflowteams.com/c/expensify/questions/16989

@melvin-bot melvin-bot bot added the Overdue label Jul 15, 2024
@adelekennedy adelekennedy added the External Added to denote the issue can be worked on by a contributor label Jul 16, 2024
@melvin-bot melvin-bot bot changed the title Notification – Have no sound notification for message [$250] Notification – Have no sound notification for message Jul 16, 2024
Copy link

melvin-bot bot commented Jul 16, 2024

Job added to Upwork: https://www.upwork.com/jobs/~015271a1c4e784b95c

@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Jul 16, 2024
Copy link

melvin-bot bot commented Jul 16, 2024

Triggered auto assignment to Contributor-plus team member for initial proposal review - @brunovjk (External)

@melvin-bot melvin-bot bot added the Overdue label Jul 19, 2024
@adelekennedy
Copy link

still waiting for proposals

@melvin-bot melvin-bot bot added Overdue and removed Overdue labels Jul 19, 2024
@brunovjk
Copy link
Contributor

@melvin-bot melvin-bot bot removed the Overdue label Jul 22, 2024
@c3024
Copy link
Contributor

c3024 commented Jul 22, 2024

We are not playing sound exclusively for mobiles here

return playSoundExcludingMobile(SOUNDS.RECEIVE);

because it is coded in the native code in this PR #36807 but that works only for notifications like banners when the chat is not on the foreground. When a user is on the chat, there is no sound when a message is received for native devices. (It works well on web).

There were some discussions here in #36579 #36714 and #37434.

It might need to be confirmed first if this is the expected behaviour for native apps or not.

cc: @Julesssss

Copy link

melvin-bot bot commented Jul 23, 2024

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

@melvin-bot melvin-bot bot added the Overdue label Jul 24, 2024
@brunovjk
Copy link
Contributor

@Julesssss Did you have a chance to see this comment? Thanks.

@melvin-bot melvin-bot bot removed the Overdue label Jul 25, 2024
@Julesssss
Copy link
Contributor

Myself and @NikkiWines weren't able to reproduce, we'd need more test steps before moving forward here.

@Julesssss Julesssss added the retest-weekly Apply this label if you want this issue tested on a Weekly basis by Applause label Jul 25, 2024
Copy link

melvin-bot bot commented Jul 25, 2024

@adelekennedy @brunovjk this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

@melvin-bot melvin-bot bot added the Overdue label Jul 29, 2024
@brunovjk
Copy link
Contributor

Not overdue, waiting for re-test

@melvin-bot melvin-bot bot removed the Overdue label Jul 30, 2024
Copy link

melvin-bot bot commented Jul 30, 2024

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

@Julesssss
Copy link
Contributor

Awaiting retest

@melvin-bot melvin-bot bot added the Overdue label Aug 1, 2024
@adelekennedy
Copy link

still unable to reproduce - waiting for re-test

@melvin-bot melvin-bot bot added Overdue and removed Overdue labels Aug 1, 2024
Copy link

melvin-bot bot commented Aug 5, 2024

@adelekennedy, @brunovjk Whoops! This issue is 2 days overdue. Let's get this updated quick!

@adelekennedy
Copy link

still pending the retest

@melvin-bot melvin-bot bot removed the Overdue label Aug 5, 2024
@adelekennedy adelekennedy added Weekly KSv2 and removed Daily KSv2 labels Aug 5, 2024
Copy link

melvin-bot bot commented Aug 6, 2024

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Engineering External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors retest-weekly Apply this label if you want this issue tested on a Weekly basis by Applause Weekly KSv2
Projects
None yet
Development

No branches or pull requests

7 participants