-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[$250] Notification – Have no sound notification for message #45243
Comments
Triggered auto assignment to @adelekennedy ( |
Triggered auto assignment to @NikkiWines ( |
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
|
@adelekennedy FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors. |
We think this issue might be related to the #vip-vsb |
Just tested with @Julesssss and we weren't able to reproduce this issue with the app either fully killed or just backgrounded so this needs reproduction |
This has been labelled "Needs Reproduction". Follow the steps here: https://stackoverflowteams.com/c/expensify/questions/16989 |
Job added to Upwork: https://www.upwork.com/jobs/~015271a1c4e784b95c |
Triggered auto assignment to Contributor-plus team member for initial proposal review - @brunovjk ( |
still waiting for proposals |
We are not playing sound exclusively for mobiles here Line 571 in 854ea80
because it is coded in the native code in this PR #36807 but that works only for notifications like banners when the chat is not on the foreground. When a user is on the chat, there is no sound when a message is received for native devices. (It works well on web). There were some discussions here in #36579 #36714 and #37434. It might need to be confirmed first if this is the expected behaviour for native apps or not. cc: @Julesssss |
📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸 |
@Julesssss Did you have a chance to see this comment? Thanks. |
Myself and @NikkiWines weren't able to reproduce, we'd need more test steps before moving forward here. |
@adelekennedy @brunovjk this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks! |
Not overdue, waiting for re-test |
📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸 |
Awaiting retest |
still unable to reproduce - waiting for re-test |
@adelekennedy, @brunovjk Whoops! This issue is 2 days overdue. Let's get this updated quick! |
still pending the retest |
📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸 |
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Version Number: v9.0.6-0
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/4710904
Email or phone of affected tester (no customers): ponikarchuks+1010724@gmail.com
Logs: https://stackoverflow.com/c/expensify/questions/4856
Issue reported by: Applause-Internal team
Action Performed:
Expected Result:
Notification is with sound
Actual Result:
Notification is without sound
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
Screenshots/Videos
Bug6538637_1720679667689.Sound_notif.mp4
View all open jobs on GitHub
Upwork Automation - Do Not Edit
The text was updated successfully, but these errors were encountered: