-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[HOLD for payment 2024-03-20] [HOLD for payment 2024-03-19] [$500] Tag - Tag list shows old tag as selected when newer tag is selected in Split scan request #38042
Comments
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
|
Triggered auto assignment to @mountiny ( |
We think that this bug might be related to #wave6-collect-submitters |
Seems like this might be related to @FitseTLT @puneetlath @neil-marcellini @ishpaul777 #37879 |
looking into it... |
ProposalPlease re-state the problem that we are trying to solve in this issue.The edited tag isn't applied in split bill request What is the root cause of that problem?In split bill requests, we save the draft data in
What changes do you think we should make in order to solve the problem?We should use information from the
What alternative solutions did you explore? (Optional) |
@ishpaul777 This issue isn't caused by #37879 |
While migrating the logic to IOURequestStepPage in here, they missed this case |
@nkdengineer are you suggesting the issue is not a deploy blocker, means also repro on production ? |
Agree with @nkdengineer. I noticed this bug and reported here. Could I take over this issue as a C+ role? |
Actually i can handle this one if @mountiny agrees.. |
@mountiny The QA team is uncertain whether selecting one multilevel tag will deselect another. Should we treat this as the same issue, or do we need to create a new one? 20240311_213333.mp4 |
@mountiny For more information about this bug, I handled many bugs that relate to new money request refactoring:
In these issues, we need to use From the above information, @nkdengineer's proposal is a good solution |
This comment was marked as outdated.
This comment was marked as outdated.
About the additional bug, we also should handle here @nkdengineer For the tag section, we allow multiple tags so we also need to set the index for the tag in splitDraftTransaction and use |
Thanks, I am updating proposal to cover the additional bug |
Updated proposal to fix the additional case |
Look good. @nkdengineer's updated proposal fixes both issues cc @mountiny |
This is fixed in staging! |
|
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.50-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue: If no regressions arise, payment will be issued on 2024-03-19. 🎊 For reference, here are some details about the assignees on this issue:
|
Triggered auto assignment to @sakluger ( |
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.51-3 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue: If no regressions arise, payment will be issued on 2024-03-20. 🎊 For reference, here are some details about the assignees on this issue:
|
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
|
Hey @nkdengineer, could you please apply to the Upwork job (https://www.upwork.com/jobs/~017e2d605b4f1b0cbe), or alternatively, link to your Upwork profile here so that I can send you an offer? @DylanDylann could you please complete the BZ checklist? |
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed: [@DylanDylann] The PR that introduced the bug has been identified. Link to the PR Regression Test Proposal Precondition:: User is an employee of Collect workspace.
Do we agree 👍 or 👎 |
We'll add test steps once the feature is fully implemented. No need to add them now. |
Summarizing payment on this issue: Contributor: @nkdengineer $500, sent offer via Upwork (https://www.upwork.com/nx/wm/offer/101491657) @nkdengineer please let me know once you've accepted the offer. |
@sakluger I've accepted the offer, thanks. |
Thank you! All contracts have been paid out. |
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Version Number: 1.4.50-0
Reproducible in staging?: y
Reproducible in production?: n
Issue reported by: Applause - Internal Team
Action Performed:
Precondition:
Expected Result:
The Tag list will show the newly-selected tag on the top
Actual Result:
The Tag list shows the original tag selected in Step 4 on the top.
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
Screenshots/Videos
Add any screenshot/video evidence
Bug6409569_1710160072688.tag.mp4
View all open jobs on GitHub
Upwork Automation - Do Not Edit
The text was updated successfully, but these errors were encountered: