-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CP Staging] Fix/38042: Tag list show old tag #38073
[CP Staging] Fix/38042: Tag list show old tag #38073
Conversation
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
@DylanDylann Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
I have read the CLA Document and I hereby sign the CLA |
@mountiny @luacmartins Anyone help to run tests cc @DylanDylann |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The change looks good. Please help to run tests while I am completing the checklist
Reviewer Checklist
Screenshots/VideosAndroid: NativeScreen.Recording.2024-03-12.at.01.29.42.movAndroid: mWeb ChromeScreen.Recording.2024-03-12.at.01.26.07.moviOS: NativeScreen.Recording.2024-03-12.at.01.29.09.moviOS: mWeb SafariScreen.Recording.2024-03-12.at.01.22.11.movMacOS: Chrome / SafariScreen.Recording.2024-03-12.at.01.21.25.movMacOS: DesktopScreen.Recording.2024-03-12.at.01.20.44.mov |
Waiting for @nkdengineer to complete videos |
It seems the TS error is from the main branch |
@nkdengineer please merge main to fix the TS error |
I'm gonna merge this with failing TS checks, since they are unrelated to this PR and were already fixed on main. I'm doing this because this PR fixes a deploy blocker. |
@luacmartins looks like this was merged without a test passing. Please add a note explaining why this was done and remove the |
See above |
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
…d-tag Fix/38042: Tag list show old tag (cherry picked from commit 6eb0f71)
🚀 Cherry-picked to staging by https://github.com/luacmartins in version: 1.4.50-4 🚀
@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes. |
🚀 Deployed to production by https://github.com/luacmartins in version: 1.4.50-5 🚀
|
Details
Fixed Issues
$ #38042
PROPOSAL: #38042 (comment)
Tests
Precondition::
Offline tests
QA Steps
Precondition::
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)myBool && <MyComponent />
.src/languages/*
files and using the translation methodSTYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)Design
label so the design team can review the changes.ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
MacOS: Desktop