-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[HOLD for payment 2024-12-20] [HOLD for payment 2024-12-11] [$250] Move onboarding tasks into the #admins room for admins #51443
Comments
Uh oh! This issue is overdue by 2 days. Don't forget to update your issues! |
Updated the mock in the OP |
Job added to Upwork: https://www.upwork.com/jobs/~021851283917795612465 |
Triggered auto assignment to Contributor-plus team member for initial proposal review - @thesahindia ( |
📣 @c3024 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app! Offer link |
@c3024 Whoops! This issue is 2 days overdue. Let's get this updated quick! |
I'll be handling the internal end here. |
📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸 |
Discussing this at a planning level here: https://expensify.slack.com/archives/C07HPDRELLD/p1730844663049119?thread_ts=1730777288.450589&cid=C07HPDRELLD Curious for @deetergp @MonilBhavsar and @francoisl 's take on things as they have worked on this feature in the past. |
|
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.70-9 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue: If no regressions arise, payment will be issued on 2024-12-11. 🎊 For reference, here are some details about the assignees on this issue:
|
@jjcoffee Issue is not happens with an email that doesn't contain a + Screen_Recording_20241204_105836.mp4 |
@jjcoffee @yuwenmemon @c3024 we're seeing a few strange things with our FS session reviews, that I think might point to these changes. Duplicate tasks in both #admins and the DM with the Guide: A strange preview of a report action for assignment in a DM with the assigned guide, that nobody can understand where that's come from: Can ya'll help us investigate? |
@c3024 Did you end up creating a revert of the revert? |
@yuwenmemon Opened the PR here #53661. |
Issue is ready for payment but no BZ is assigned. @OfstadC you are the lucky winner! Please verify the payment summary looks correct and complete the checklist. Thanks! |
@yuwenmemon Sorry for my confusion but I see this is still being worked on. Do we still need to issue payment today and if so, is this accurate? |
|
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.75-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue: If no regressions arise, payment will be issued on 2024-12-20. 🎊 For reference, here are some details about the assignees on this issue:
|
I guess no checklist is needed here as this is a feature addition. Regression Test ProposalPrecondition:
Test:
Do we agree 👍 or 👎 |
$250 approved for @jjcoffee |
Problem
By placing onboarding steps in a Concierge DM, it limits the assigned onboarding specialist's ability to collaborate with the customer directly.
Solution
When a user selects
Manage my team's expenses
as their onboarding intent, let's update the assigned setup specialists' message to include onboarding Tasks, and post them in the #admins room. See below:Start your free trial
tooltip over to the #admins row in LHNIssue Checklist
CompleteGuidedSetup
to post tasks in the #admins room #52219CompleteGuidedSetup
#52220Upwork Automation - Do Not Edit
Issue Owner
Current Issue Owner: @OfstadCThe text was updated successfully, but these errors were encountered: