Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD for payment 2024-12-20] [HOLD for payment 2024-12-11] [$250] Move onboarding tasks into the #admins room for admins #51443

Closed
3 of 6 tasks
zsgreenwald opened this issue Oct 24, 2024 · 44 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production External Added to denote the issue can be worked on by a contributor Hot Pick Ready for an engineer to pick up and run with Internal Requires API changes or must be handled by Expensify staff Weekly KSv2

Comments

@zsgreenwald
Copy link
Contributor

zsgreenwald commented Oct 24, 2024

Problem

By placing onboarding steps in a Concierge DM, it limits the assigned onboarding specialist's ability to collaborate with the customer directly.

Solution

When a user selects Manage my team's expenses as their onboarding intent, let's update the assigned setup specialists' message to include onboarding Tasks, and post them in the #admins room. See below:

image

  1. Since the assigned onboarding specialist's message will get sent first, we'll provide onboarding steps in that same message so it doesn't seem disjointed.
  2. Let's update the assigned onboarding specialist's message to:

Hey there 👋 I'm your dedicated setup specialist. I look forward to helping you explore and configure Expensify. You can chat with me here anytime if you have any questions, or book a call with me directly at your convenience. I've shared some onboarding steps to help you get started below:

  • task 1
  • task 2
  • ....
  1. Let's keep the same GIF from the Concierge message and use it in the #admins post
  2. Let's move the Start your free trial tooltip over to the #admins row in LHN
  3. Let's keep the welcome message from Concierge, but not have it be pinned in LHN

Issue Checklist

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~021851283917795612465
  • Upwork Job ID: 1851283917795612465
  • Last Price Increase: 2024-11-05
  • Automatic offers:
    • c3024 | Contributor | 104646441
Issue OwnerCurrent Issue Owner: @OfstadC
@zsgreenwald zsgreenwald added Daily KSv2 Internal Requires API changes or must be handled by Expensify staff Planning Changes still in the thought process labels Oct 24, 2024
Copy link

melvin-bot bot commented Oct 28, 2024

Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

@melvin-bot melvin-bot bot added the Overdue label Oct 28, 2024
@zsgreenwald
Copy link
Contributor Author

Updated the mock in the OP

@melvin-bot melvin-bot bot removed the Overdue label Oct 29, 2024
@zsgreenwald zsgreenwald added Help Wanted Apply this label when an issue is open to proposals by contributors External Added to denote the issue can be worked on by a contributor and removed Planning Changes still in the thought process labels Oct 29, 2024
Copy link

melvin-bot bot commented Oct 29, 2024

Job added to Upwork: https://www.upwork.com/jobs/~021851283917795612465

@melvin-bot melvin-bot bot changed the title Move onboarding tasks into the #admins room for admins [$250] Move onboarding tasks into the #admins room for admins Oct 29, 2024
Copy link

melvin-bot bot commented Oct 29, 2024

Triggered auto assignment to Contributor-plus team member for initial proposal review - @thesahindia (External)

@melvin-bot melvin-bot bot removed the Help Wanted Apply this label when an issue is open to proposals by contributors label Oct 29, 2024
@zsgreenwald zsgreenwald added Help Wanted Apply this label when an issue is open to proposals by contributors Hot Pick Ready for an engineer to pick up and run with labels Oct 29, 2024
Copy link

melvin-bot bot commented Oct 29, 2024

📣 @c3024 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

Copy link

melvin-bot bot commented Nov 1, 2024

@c3024 Whoops! This issue is 2 days overdue. Let's get this updated quick!

@melvin-bot melvin-bot bot added the Overdue label Nov 1, 2024
@yuwenmemon yuwenmemon self-assigned this Nov 4, 2024
@melvin-bot melvin-bot bot removed the Overdue label Nov 4, 2024
@yuwenmemon
Copy link
Contributor

I'll be handling the internal end here.

Copy link

melvin-bot bot commented Nov 5, 2024

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

@yuwenmemon
Copy link
Contributor

Discussing this at a planning level here: https://expensify.slack.com/archives/C07HPDRELLD/p1730844663049119?thread_ts=1730777288.450589&cid=C07HPDRELLD

Curious for @deetergp @MonilBhavsar and @francoisl 's take on things as they have worked on this feature in the past.

@melvin-bot melvin-bot bot changed the title [$250] Move onboarding tasks into the #admins room for admins [HOLD for payment 2024-12-11] [$250] Move onboarding tasks into the #admins room for admins Dec 4, 2024
Copy link

melvin-bot bot commented Dec 4, 2024

Reviewing label has been removed, please complete the "BugZero Checklist".

@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label Dec 4, 2024
Copy link

melvin-bot bot commented Dec 4, 2024

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.70-9 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2024-12-11. 🎊

For reference, here are some details about the assignees on this issue:

@IuliiaHerets
Copy link

@jjcoffee Issue is not happens with an email that doesn't contain a +

Screen_Recording_20241204_105836.mp4

@trjExpensify
Copy link
Contributor

trjExpensify commented Dec 4, 2024

@jjcoffee @yuwenmemon @c3024 we're seeing a few strange things with our FS session reviews, that I think might point to these changes.

Duplicate tasks in both #admins and the DM with the Guide:

image

A strange preview of a report action for assignment in a DM with the assigned guide, that nobody can understand where that's come from:

image

Can ya'll help us investigate?

@trjExpensify
Copy link
Contributor

Here's another example with both bugs.

image

At this point, I think we should revert this PR and look into it.

@yuwenmemon
Copy link
Contributor

@c3024 Did you end up creating a revert of the revert?

@c3024
Copy link
Contributor

c3024 commented Dec 5, 2024

@yuwenmemon Opened the PR here #53661.

@melvin-bot melvin-bot bot added Daily KSv2 and removed Weekly KSv2 labels Dec 10, 2024
Copy link

melvin-bot bot commented Dec 11, 2024

Issue is ready for payment but no BZ is assigned. @OfstadC you are the lucky winner! Please verify the payment summary looks correct and complete the checklist. Thanks!

@OfstadC
Copy link
Contributor

OfstadC commented Dec 11, 2024

@yuwenmemon Sorry for my confusion but I see this is still being worked on.

Do we still need to issue payment today and if so, is this accurate?

@yuwenmemon
Copy link
Contributor

@OfstadC You'll want to follow the progress of this PR instead: #53661

@melvin-bot melvin-bot bot added Weekly KSv2 and removed Daily KSv2 labels Dec 13, 2024
@melvin-bot melvin-bot bot changed the title [HOLD for payment 2024-12-11] [$250] Move onboarding tasks into the #admins room for admins [HOLD for payment 2024-12-20] [HOLD for payment 2024-12-11] [$250] Move onboarding tasks into the #admins room for admins Dec 13, 2024
@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label Dec 13, 2024
Copy link

melvin-bot bot commented Dec 13, 2024

Reviewing label has been removed, please complete the "BugZero Checklist".

Copy link

melvin-bot bot commented Dec 13, 2024

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.75-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2024-12-20. 🎊

For reference, here are some details about the assignees on this issue:

@jjcoffee
Copy link
Contributor

I guess no checklist is needed here as this is a feature addition.

Regression Test Proposal

Precondition:

  • Have an email that doesn't have a '+' in it.

Test:

  1. Logon to ND with a new email without a '+' in it.
  2. Click on "Manage my team's expenses" on the onboarding flow and complete the onboarding.
  3. Verify that the onboarding tasks show up in the #admins room.

Do we agree 👍 or 👎

@OfstadC
Copy link
Contributor

OfstadC commented Dec 20, 2024

Payment Summary

@garrettmknight
Copy link
Contributor

$250 approved for @jjcoffee

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production External Added to denote the issue can be worked on by a contributor Hot Pick Ready for an engineer to pick up and run with Internal Requires API changes or must be handled by Expensify staff Weekly KSv2
Projects
Development

No branches or pull requests

10 participants