Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the reviewer checklist from the PR template #13090

Merged
merged 1 commit into from
Nov 30, 2022

Conversation

tgolen
Copy link
Contributor

@tgolen tgolen commented Nov 28, 2022

Fixed Issues

$ https://github.com/Expensify/Expensify/issues/239867

Tests

None. Can only be tested once merged

Offline tests

None - this doesn't affect the app at all

QA Steps

  1. Create a new PR for any simple file change
  2. Verify that the template no longer includes the reviewer checklist in the description
  3. Close out the PR

PR Author Checklist

Checklist and screenshots do not apply since this is not a change to the app code

@tgolen tgolen added the InternalQA This pull request required internal QA label Nov 28, 2022
@tgolen tgolen self-assigned this Nov 28, 2022
@tgolen tgolen requested a review from a team as a code owner November 28, 2022 17:55
@melvin-bot melvin-bot bot requested review from MonilBhavsar and parasharrajat and removed request for a team November 28, 2022 17:56
@melvin-bot
Copy link

melvin-bot bot commented Nov 28, 2022

@parasharrajat @MonilBhavsar One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@tgolen
Copy link
Contributor Author

tgolen commented Nov 28, 2022

@parasharrajat @MonilBhavsar you can disregard that previous ping and it's OK to merge this with the reviewer checklist failing since this doesn't touch any of the app code.

Copy link
Contributor

@MonilBhavsar MonilBhavsar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, Not sure why other unrelated tests are failing. Rerunning them...

@tgolen
Copy link
Contributor Author

tgolen commented Nov 30, 2022

I'm going to self merge this since @MonilBhavsar has approved it. The failing tests are known since having the author and reviewer checklists for this PR are not necessary.

@tgolen tgolen merged commit 1527fdc into main Nov 30, 2022
@tgolen tgolen deleted the tgolen-remove-reviewerchecklistfromprtemplate branch November 30, 2022 13:32
@melvin-bot
Copy link

melvin-bot bot commented Nov 30, 2022

Triggered auto assignment to @johnmlee101 (InternalQA), see https://stackoverflow.com/c/expensify/questions/5042 for more details.

@melvin-bot
Copy link

melvin-bot bot commented Nov 30, 2022

@tgolen looks like this was merged without a test passing. Please add a note explaining why this was done and remove the Emergency label if this is not an emergency.

@melvin-bot melvin-bot bot added the Emergency label Nov 30, 2022
@OSBotify
Copy link
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@luacmartins
Copy link
Contributor

Validated that this worked here!

@OSBotify
Copy link
Contributor

OSBotify commented Dec 1, 2022

🚀 Deployed to staging by @tgolen in version: 1.2.35-0 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify
Copy link
Contributor

OSBotify commented Dec 2, 2022

🚀 Deployed to production by @luacmartins in version: 1.2.35-0 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Emergency InternalQA This pull request required internal QA
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants