Fix blank page on archived room with messages #13124

hellohublot · 2022-11-29T07:42:29Z

Details

Use ReportUtils.isArchivedRoom fix blank page on archived room

Fixed Issues

$ #12045
PROPOSAL: #12045 (comment)

Tests

If you are in the development environment, first modify the Permissions.canUseDefaultRooms method

function canUseDefaultRooms(betas) {
+   return false
    return _.contains(betas, CONST.BETAS.DEFAULT_ROOMS) || canUseAllBetas(betas);
}

Create a workspace
Delete any assigned guides for this workspace
Delete the workspace
Search the admin room of this workspace
Make sure the admin room of this workspace can display

Verify that no errors appear in the JS console

Offline tests

Go offline
Go to settings > workspaces > Create workspace
Search announce room for the newly created workspace
Send a message > Pin the chat
Go to settings > workspaces > delete newly created workspace
Verify the announce room chat is visible

QA Steps

Create a workspace
Delete any assigned guides for this workspace
Delete the workspace
Search the admin room of this workspace
Make sure the admin room of this workspace can display

Verify that no errors appear in the JS console

PR Author Checklist

PR Reviewer Checklist

The reviewer will copy/paste it into a new comment and complete it after the author checklist is completed

Screenshots/Videos

Web

_web.mov

Mobile Web - Chrome

_mobile_chrome.mp4

Mobile Web - Safari

_mobile_safari.mp4

Desktop

_desktop.mov

iOS

_ios.mp4

Android

_android.mp4

melvin-bot · 2022-11-29T07:42:35Z

@dangrous @thesahindia One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

thesahindia · 2022-11-29T16:29:14Z

So I want to reuse ReportUtils.shouldReportBeInOptionList To decide whether to display the report on the ReportScreen, if you disagree, I will resubmit the original solution ReportUtils.isArchivedRoom, Thank you 🙏

@robertjchen @dangrous, what's your opinion? Should we reuse shouldReportBeInOptionList ?

App/src/libs/ReportUtils.js

Line 1045 in 5f89a98

    
           function shouldReportBeInOptionList(report, reportIDFromRoute, isInGSDMode, currentUserLogin, iouReports, betas, policies) {

dangrous · 2022-11-29T16:46:57Z

Hm, interesting. Are we sure using shouldReportBeInOptionList would cover all the other scenarios currently in ReportScreen? (Other than this particular situation, that is).

thesahindia · 2022-11-29T20:47:43Z

Hm, interesting. Are we sure using shouldReportBeInOptionList would cover all the other scenarios currently in ReportScreen? (Other than this particular situation, that is).

Yes, I think. But we have some if statements at shouldReportBeInOptionList that are unnecessary for ReportScreen and for which we are passing some unnecessary arguments, sometimes things gets complex because of it. So I think we should not reuse shouldReportBeInOptionList

thesahindia · 2022-11-29T20:51:41Z

Let us know what you think is best @dangrous.

dangrous · 2022-11-29T22:22:39Z

Yeah I think I agree, @thesahindia - best to keep it simple. @hellohublot , if you wouldn't mind swapping back to the original solution - ReportUtils.isArchivedRoom - that would be great! Really appreciate the investigation of the other method, though.

cead22

If we're going to go with this solution we should do the tests in both priority modes
Also, since we're modifying shouldReportBeInOptionList, should we add automated tests that cover the new cases?
I think the QA section should be updated since you can't modify the running code when doing QA on staging
In the future please write good titles for PRs explaining what its doing and capitalize the first word since it's a title

src/pages/home/ReportScreen.js

cead22 · 2022-11-30T00:37:39Z

Yeah I think I agree, @thesahindia - best to keep it simple. @hellohublot , if you wouldn't mind swapping back to the original solution - ReportUtils.isArchivedRoom - that would be great! Really appreciate the investigation of the other method, though.

I agree

hellohublot · 2022-11-30T09:32:08Z

@thesahindia Hi, I have submitted my original solution and tests in this PR. Thank you very much for your suggestions.

thesahindia · 2022-11-30T09:41:09Z

Thanks! I will test it in a few minutes.

thesahindia · 2022-11-30T10:07:07Z

src/pages/home/ReportScreen.js

@@ -195,10 +195,12 @@ class ReportScreen extends React.Component {
        // We create policy rooms for all policies, however we don't show them unless
        // - It's a free plan workspace
        // - The report includes guides participants (@team.expensify.com) for 1:1 Assigned
+        // - It has removed all guide participants before archiving


I think we don't need a comment for this. It's making it more confusing

Suggested change

// - It has removed all guide participants before archiving

Or maybe add this

Suggested change

// - It has removed all guide participants before archiving

// - It's an archived room

Thank you, it has been updated

src/pages/home/ReportScreen.js

thesahindia · 2022-11-30T11:02:20Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- iOS / native
- Android / native
- iOS / Safari
- Android / Chrome
- MacOS / Chrome
- MacOS / Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product was added in all src/languages/* files
- I verified any copy / text that was added to the app is correct English and approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

Screen.Recording.2022-11-30.at.3.53.37.PM.mov

Mobile Web - Chrome

Screen.Recording.2022-11-30.at.4.07.20.PM.mov

Mobile Web - Safari

Screen.Recording.2022-11-30.at.4.23.45.PM.mov

Desktop

Screen.Recording.2022-11-30.at.4.39.54.PM.mov

iOS

Screen.Recording.2022-11-30.at.4.28.54.PM.mov

Android

Screen.Recording.2022-11-30.at.4.11.40.PM.mov

thesahindia · 2022-11-30T11:14:48Z

@hellohublot, please remove the first step from QA steps.

hellohublot · 2022-11-30T11:18:40Z

@thesahindia Sure, it has been removed

thesahindia · 2022-11-30T11:25:02Z

@hellohublot, please also add these steps to offline steps -

Go offline
Go to settings > workspaces > Create workspace
Search announce room for the newly created workspace
Send a message > Pin the chat
Go to settings > workspaces > delete newly created workspace
Verify the announce room chat is visible

hellohublot · 2022-11-30T11:29:53Z

@thesahindia Yes, it has been added

thesahindia

All yours @dangrous

dangrous

Looks great!

dangrous · 2022-11-30T16:57:18Z

@cead22 re-requested review from you to clear out the changes you requested (for the old version of code), so I can merge.

thesahindia · 2022-12-01T06:53:49Z

Bump @cead22

Changes requested on old version of code

dangrous · 2022-12-01T14:56:27Z

I went ahead and dismissed the requested changes (since no longer relevant) so we can merge this

OSBotify · 2022-12-01T15:01:01Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2022-12-01T17:08:44Z

🚀 Deployed to staging by @dangrous in version: 1.2.35-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2022-12-02T18:58:51Z

🚀 Deployed to production by @luacmartins in version: 1.2.35-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

hellohublot requested a review from a team as a code owner November 29, 2022 07:42

melvin-bot bot requested review from dangrous and thesahindia and removed request for a team November 29, 2022 07:42

hellohublot mentioned this pull request Nov 29, 2022

[Hold for Payment: 2022-12-09] [$2000] Bug: Blank page is shown for archived room with a message reported by @Puneet-here #12045

Closed

cead22 changed the title ~~12045_fix_blank_page_use_shouldReportBeInOptionList~~ Fix blank page on archived room with messages Nov 30, 2022

cead22 previously requested changes Nov 30, 2022

View reviewed changes

src/pages/home/ReportScreen.js Outdated Show resolved Hide resolved

Fix blank page on archived room

f6ca014

hellohublot force-pushed the 12045_fix_blank_page_use_shouldReportBeInOptionList branch from 58607ee to f6ca014 Compare November 30, 2022 04:28

thesahindia reviewed Nov 30, 2022

View reviewed changes

src/pages/home/ReportScreen.js Outdated Show resolved Hide resolved

Update ReportScreen archived room comment

86fd5c3

thesahindia approved these changes Nov 30, 2022

View reviewed changes

dangrous approved these changes Nov 30, 2022

View reviewed changes

dangrous requested a review from cead22 November 30, 2022 16:56

dangrous merged commit c10d5fb into Expensify:main Dec 1, 2022

OSBotify mentioned this pull request Dec 1, 2022

Deploy Checklist: New Expensify 2022-12-01 #13240

Closed

11 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix blank page on archived room with messages #13124

Fix blank page on archived room with messages #13124

hellohublot commented Nov 29, 2022 •

edited by dangrous

Loading

melvin-bot bot commented Nov 29, 2022

thesahindia commented Nov 29, 2022

dangrous commented Nov 29, 2022

thesahindia commented Nov 29, 2022 •

edited

Loading

thesahindia commented Nov 29, 2022

dangrous commented Nov 29, 2022

cead22 left a comment

cead22 commented Nov 30, 2022

hellohublot commented Nov 30, 2022

thesahindia commented Nov 30, 2022

thesahindia Nov 30, 2022 •

edited

Loading

hellohublot Nov 30, 2022

thesahindia commented Nov 30, 2022 •

edited

Loading

thesahindia commented Nov 30, 2022

hellohublot commented Nov 30, 2022

thesahindia commented Nov 30, 2022 •

edited

Loading

hellohublot commented Nov 30, 2022

thesahindia left a comment

dangrous left a comment

dangrous commented Nov 30, 2022

thesahindia commented Dec 1, 2022

dangrous commented Dec 1, 2022

OSBotify commented Dec 1, 2022

OSBotify commented Dec 1, 2022

OSBotify commented Dec 2, 2022

	// - It has removed all guide participants before archiving
	// - It's an archived room

Fix blank page on archived room with messages #13124

Fix blank page on archived room with messages #13124

Conversation

hellohublot commented Nov 29, 2022 • edited by dangrous Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

PR Reviewer Checklist

Screenshots/Videos

melvin-bot bot commented Nov 29, 2022

thesahindia commented Nov 29, 2022

dangrous commented Nov 29, 2022

thesahindia commented Nov 29, 2022 • edited Loading

thesahindia commented Nov 29, 2022

dangrous commented Nov 29, 2022

cead22 left a comment

Choose a reason for hiding this comment

cead22 commented Nov 30, 2022

hellohublot commented Nov 30, 2022

thesahindia commented Nov 30, 2022

thesahindia Nov 30, 2022 • edited Loading

Choose a reason for hiding this comment

hellohublot Nov 30, 2022

Choose a reason for hiding this comment

thesahindia commented Nov 30, 2022 • edited Loading

Reviewer Checklist

Screenshots/Videos

thesahindia commented Nov 30, 2022

hellohublot commented Nov 30, 2022

thesahindia commented Nov 30, 2022 • edited Loading

hellohublot commented Nov 30, 2022

thesahindia left a comment

Choose a reason for hiding this comment

dangrous left a comment

Choose a reason for hiding this comment

dangrous commented Nov 30, 2022

thesahindia commented Dec 1, 2022

dangrous commented Dec 1, 2022

OSBotify commented Dec 1, 2022

OSBotify commented Dec 1, 2022

OSBotify commented Dec 2, 2022

hellohublot commented Nov 29, 2022 •

edited by dangrous

Loading

thesahindia commented Nov 29, 2022 •

edited

Loading

thesahindia Nov 30, 2022 •

edited

Loading

thesahindia commented Nov 30, 2022 •

edited

Loading

thesahindia commented Nov 30, 2022 •

edited

Loading