Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix blank page on archived room with messages #13124

Merged
merged 2 commits into from
Dec 1, 2022
Merged

Fix blank page on archived room with messages #13124

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f6ca014
Fix blank page on archived room
hellohublot Nov 30, 2022
86fd5c3
Update ReportScreen archived room comment
hellohublot Nov 30, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/pages/home/ReportScreen.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -195,10 +195,12 @@ class ReportScreen extends React.Component {
// We create policy rooms for all policies, however we don't show them unless
// - It's a free plan workspace
// - The report includes guides participants (@team.expensify.com) for 1:1 Assigned
// - It has removed all guide participants before archiving
Copy link
Member

@thesahindia thesahindia Nov 30, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we don't need a comment for this. It's making it more confusing

Suggested change
// - It has removed all guide participants before archiving

Or maybe add this

Suggested change
// - It has removed all guide participants before archiving
// - It's an archived room

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, it has been updated

hellohublot marked this conversation as resolved.
Show resolved Hide resolved
if (!Permissions.canUseDefaultRooms(this.props.betas)
&& ReportUtils.isDefaultRoom(this.props.report)
&& ReportUtils.getPolicyType(this.props.report, this.props.policies) !== CONST.POLICY.TYPE.FREE
&& !ReportUtils.hasExpensifyGuidesEmails(lodashGet(this.props.report, ['participants'], []))
&& !ReportUtils.isArchivedRoom(this.props.report)
) {
return null;
}
Expand Down