[User Settings] Implement Settings Menu Selectors

[Maftalion]

Details

Original PR #1630

Fixed Issues

Fixes https://github.com//issues/1493

Tests

• Click into Settings page from HomePage
• Click each menu item and confirm subroute renders

Tested On

• Web
• Mobile Web
• Desktop
• iOS
• Android

Screenshots

Web

Mobile Web

Desktop

iOS

Android

[Maftalion]

um not sure how i broke things while merging master with the original pr #1630 😅 , but i just cherry picked my commits over and opened a fresh pr
@NikkiWines @cead22 @marcaaron

Screen.Recording.2021-03-08.at.6.49.52.PM.mov

[jasperhuangg]

Hey @Maftalion! I was randomly assigned by PullerBear and I don't think I have enough context to be reviewing this PR, especially considering how things were broken before.

It looks like @cead22 @shawnborton @NikkiWines and @marcaaron were reviewing the PR that this one was made from. I think they should probably be the ones reviewing this. I'll remove myself from the assignment.

As a note though it looks like you're failing the JSX style tests, but these seem to have been fixed in this PR: #1674.

Thanks!

[shawnborton]

The video you posted looks great to me, but I'd also love more screenshots in the original comment as well.

[marcaaron]

LGTM

[NikkiWines]

Tested and works well

[shawnborton]

Tested and this looks great. The only slight weirdness I see is that if you navigate to a subpage of Settings (like Preferences) and then tap on the "X" in the top right corner, you see the parent Settings page flash for a split second as the rightDocked sidepane exits.

[NikkiWines]

@shawnborton I think the view weirdness will probably be handled when we change the whole navigation system in marc's react-navigation PR #1559

[marcaaron]

Merged master into my branch there and the animation does the flashy thing. However, I think we should next merge the react-nav stuff and iron out these details later.