[No QA] [TS migration] Migrate 'cropOrRotateImage' lib to TypeScript #27419
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thiagobrez
reviewed
Sep 14, 2023
| /** | ||
| * Crops and rotates the image on ios/android | ||
| */ | ||
| const cropOrRotateImage: CropOrRotateImage = (uri, actions, options) => |
There was a problem hiding this comment.
This seems a little weird to me. Any reason not to declare the types inline?
function cropOrRotateImage(uri: string, actions: Action[], options: CropOrRotateImageOptions): Promise<FileWithUri | RNManipulator > {
...
}There was a problem hiding this comment.
@thiagobrez when we have platform specific files we need to follow this pattern. Thats why its like that
There was a problem hiding this comment.
@kubabutkiewicz Cool! 👍🏻
thiagobrez
reviewed
Sep 14, 2023
thiagobrez
reviewed
Sep 14, 2023
fabioh8010
reviewed
Sep 14, 2023
src/libs/cropOrRotateImage/index.ts
Outdated
Comment on lines
80
to
83
| const file = new File([blob], options.name || 'fileName.jpeg', {type: options.type || 'image/jpeg'}); | ||
| file.uri = URL.createObjectURL(file); | ||
| resolve(file); | ||
| const fileWithUri = Object.assign(file, {uri: URL.createObjectURL(file)}); | ||
|
|
||
| resolve(fileWithUri); |
There was a problem hiding this comment.
const file = new File([blob], options.name || 'fileName.jpeg', {type: options.type || 'image/jpeg'}) as FileWithUri;
file.uri = URL.createObjectURL(file);
resolve(file);In this way you don't need to use Object.assign
There was a problem hiding this comment.
Fixed @fabioh8010
src/libs/cropOrRotateImage/types.ts
Outdated
| uri: string; | ||
| }; | ||
|
|
||
| type RNManipulator = RNImageManipulatorResult & {size: number; type: string; name: string}; |
There was a problem hiding this comment.
Suggested change
| type RNManipulator = RNImageManipulatorResult & {size: number; type: string; name: string}; | |
| type CustomRNImageManipulatorResult = RNImageManipulatorResult & {size: number; type: string; name: string}; |
There was a problem hiding this comment.
Fixed @fabioh8010
Comment on lines
12
to
13
| const file = Object.assign(result, {size, type: options.type || 'image/jpeg', name: options.name || 'fileName.jpg'}); | ||
| resolve(file); |
There was a problem hiding this comment.
Suggested change
| const file = Object.assign(result, {size, type: options.type || 'image/jpeg', name: options.name || 'fileName.jpg'}); | |
| resolve(file); | |
| resolve({ | |
| ...result, | |
| size, | |
| type: options.type || 'image/jpeg', | |
| name: options.name || 'fileName.jpg', | |
| }); |
The old way still works, isn't?
There was a problem hiding this comment.
Yeah, fixed @fabioh8010
melvin-bot
bot
requested review from
srikarparsi
and removed request for
a team
|
@srikarparsi Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
Reviewer Checklist
Screenshots/VideosWebclipFlipRecording.movMobile Web - ChromeMobile Web - SafariDesktopiOSAndroid |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚀 Deployed to staging by https://github.com/srikarparsi in version: 1.3.72-0 🚀
|
|
🚀 Deployed to production by https://github.com/thienlnam in version: 1.3.72-11 🚀
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
Fixed Issues
$ 24839
Tests
Offline tests
QA Steps
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)myBool && <MyComponent />.src/languages/*files and using the translation methodWaiting for Copylabel for a copy review on the original GH to get the correct copy.STYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)/** comment above it */thisproperly so there are no scoping issues (i.e. foronClick={this.submit}the methodthis.submitshould be bound tothisin the constructor)thisare necessary to be bound (i.e. avoidthis.submit = this.submit.bind(this);ifthis.submitis never passed to a component event handler likeonClick)StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))Avataris modified, I verified thatAvataris working as expected in all cases)ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Web
web.mp4
Mobile Web - Chrome
Mobile Web - Safari
Desktop
desktop.mp4
iOS
ios.mp4
Android
android.mp4