-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[No QA] [TS migration] Migrate 'cropOrRotateImage' lib to TypeScript #27419
Merged
srikarparsi
merged 4 commits into
Expensify:main
from
kubabutkiewicz:ts-migration/cropOrRotateImage-lib
Sep 19, 2023
Merged
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
060876a
ref: move cropOrRotateImage index to TS
kubabutkiewicz 5c15ebb
ref: move native file to ts
kubabutkiewicz 0cc9181
fix: wrap context with if statment instead using optional chaining
kubabutkiewicz fd3e146
fix: resolve comments
kubabutkiewicz File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,29 @@ | ||
import {RNImageManipulatorResult} from '@oguzhnatly/react-native-image-manipulator'; | ||
|
||
type CropOrRotateImageOptions = { | ||
type: string; | ||
name: string; | ||
compress: number; | ||
}; | ||
|
||
type CropOptions = { | ||
kubabutkiewicz marked this conversation as resolved.
Show resolved
Hide resolved
|
||
originX: number; | ||
originY: number; | ||
width: number; | ||
height: number; | ||
}; | ||
|
||
type Action = { | ||
kubabutkiewicz marked this conversation as resolved.
Show resolved
Hide resolved
|
||
crop?: CropOptions; | ||
rotate?: number; | ||
}; | ||
|
||
type FileWithUri = File & { | ||
kubabutkiewicz marked this conversation as resolved.
Show resolved
Hide resolved
|
||
uri: string; | ||
}; | ||
|
||
type CustomRNImageManipulatorResult = RNImageManipulatorResult & {size: number; type: string; name: string}; | ||
|
||
type CropOrRotateImage = (uri: string, actions: Action[], options: CropOrRotateImageOptions) => Promise<FileWithUri | CustomRNImageManipulatorResult>; | ||
|
||
export type {CropOrRotateImage, CropOptions, Action, FileWithUri, CropOrRotateImageOptions}; |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems a little weird to me. Any reason not to declare the types inline?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@thiagobrez when we have platform specific files we need to follow this pattern. Thats why its like that
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kubabutkiewicz Cool! 👍🏻