-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove duplicate back icon in "# Room" tab for "Send Message" when there is no workspace #27983
remove duplicate back icon in "# Room" tab for "Send Message" when there is no workspace #27983
Conversation
@eVoloshchak Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
I used option 3 of this comment for the not found page. Please review and suggest changes if any @eVoloshchak |
Reviewer Checklist
Screenshots/VideosWebScreen.Recording.2023-09-23.at.11.34.17.movMobile Web - Chromescreen-20230923-115511.mp4Mobile Web - SafariScreen.Recording.2023-09-23.at.11.48.18.movDesktopScreen.Recording.2023-09-23.at.11.50.18.moviOSScreen.Recording.2023-09-23.at.11.44.59.movAndroidscreen-20230923-115725.mp4 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Not sure why lint check is failing, doesn't seem to be related to these changes
@c3024, typo in Tests section
Should be |
Done. |
lint is failing 😕 |
Lint failing due to a different PR |
What do you mean? Did we merge a failing PR to main? 😕 |
Lint works fine locally. |
Maybe it'll fix itself if you merge main? |
Maybe it will. Since this lint error for sure is not due to this PR, we may try that. |
I just checked again fetching main. No lint error locally. |
So can you merge main here so it ends up passing? 🙏 |
Done. All succeeded. @flodnv |
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
🚀 Deployed to staging by https://github.com/flodnv in version: 1.3.75-0 🚀
|
🚀 Deployed to production by https://github.com/mountiny in version: 1.3.75-12 🚀
|
🚀 Deployed to staging by https://github.com/flodnv in version: 1.3.76-0 🚀
|
🚀 Deployed to production by https://github.com/mountiny in version: 1.3.76-6 🚀
|
Details
Fixed Issues
$ #27603
PROPOSAL: #27603 (comment)
Tests
Offline tests
QA Steps
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)myBool && <MyComponent />
.src/languages/*
files and using the translation methodWaiting for Copy
label for a copy review on the original GH to get the correct copy.STYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)/** comment above it */
this
properly so there are no scoping issues (i.e. foronClick={this.submit}
the methodthis.submit
should be bound tothis
in the constructor)this
are necessary to be bound (i.e. avoidthis.submit = this.submit.bind(this);
ifthis.submit
is never passed to a component event handler likeonClick
)StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Web
duplicateBackIconsWeb.mov
Mobile Web - Chrome
duplicateBackIconsAndroidChrome.mp4
Mobile Web - Safari
duplicateBackIconsiOSSafari.mov
Desktop
duplicateBackIconsDesktop.mov
iOS
duplicateBackIconsiOSNative.mov
Android
Screen.Recording.2023-09-23.at.3.20.11.PM.mov