Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deploy Checklist: New Expensify 2023-10-02 #28635

Closed
OSBotify opened this issue Oct 2, 2023 · 15 comments
Closed

Deploy Checklist: New Expensify 2023-10-02 #28635

OSBotify opened this issue Oct 2, 2023 · 15 comments
Assignees
@mountiny @applausebot
Labels
Daily KSv2 🔐 LockCashDeploys 🔐 Prevent new code from being deployed to staging StagingDeployCash

Comments

@OSBotify
Copy link
Contributor

OSBotify commented Oct 2, 2023 •
edited by mountiny
Loading

Release Version: 1.3.76-6
Compare Changes: production...staging

This release contains changes from the following pull requests:

Internal QA:

Deploy Blockers:

Deployer verifications:

  • I checked the App Timing Dashboard and verified this release does not cause a noticeable performance regression.
  • I checked Firebase Crashlytics and verified that this release does not introduce any new crashes. More detailed instructions on this verification can be found here.
  • I checked GitHub Status and verified there is no reported incident with Actions.

cc @Expensify/applauseleads
@mountiny mountiny added 🔐 LockCashDeploys 🔐 Prevent new code from being deployed to staging Daily KSv2 labels Oct 2, 2023
@mountiny mountiny self-assigned this Oct 2, 2023
@mountiny
Copy link
Contributor

mountiny commented Oct 2, 2023

checking off the PRs which already were in staging

@OSBotify
Copy link
Contributor Author

OSBotify commented Oct 2, 2023

🚀 All staging deploys are complete, @Expensify/applauseleads please begin QA on version https://github.com/Expensify/App/releases/tag/1.3.76-0 🚀

@mountiny
Copy link
Contributor

mountiny commented Oct 2, 2023 •
edited
Loading

@mountiny
Copy link
Contributor

mountiny commented Oct 2, 2023

There is more to be checked off

@mountiny
Copy link
Contributor

mountiny commented Oct 2, 2023

I have checked off more, I think it should be all of them which were in previous deploys. Also I checked off the help site updates

@mountiny
Copy link
Contributor

mountiny commented Oct 2, 2023

Found a few more, I thin now it should be all

@kavimuru
Copy link

kavimuru commented Oct 3, 2023 •
edited
Loading

@mountiny Regression TR is left with 3%. Team is working on CPs and on couple PRs

#25557 failing with #28654
#28165 failing with #28069
#28219 failing with #28014 ( not fixed in Desktop)
#28273 failing with #27598 (comment)
#28533 failing with #26940 which is a known issue, ok to checking it off?
#28686 This cp has no QA steps. Okay to check it off?
#28404 failing with #27814 (city not popoulated)

@mountiny
Copy link
Contributor

mountiny commented Oct 3, 2023

I believe this was a pass internally #28236

Checked off couple of the deploy blockers which were confirmed fixed in staging

@mountiny
Copy link
Contributor

mountiny commented Oct 3, 2023

Checking off:

@shubham1206agra
Copy link
Contributor

@kavimuru Can you recheck #28533
I have rechecked this against the latest main. Working fine for me

@mountiny
Copy link
Contributor

mountiny commented Oct 3, 2023

@mountiny
Copy link
Contributor

mountiny commented Oct 3, 2023

image

graphs good and no new crashes

@mountiny
Copy link
Contributor

mountiny commented Oct 3, 2023

:shipit:

@mountiny mountiny closed this as completed Oct 3, 2023
@OSBotify OSBotify reopened this Oct 3, 2023
@OSBotify
Copy link
Contributor Author

OSBotify commented Oct 3, 2023

This issue either has unchecked items or has not yet been marked with the :shipit: emoji of approval.
Reopening!

@mountiny
Copy link
Contributor

mountiny commented Oct 3, 2023

:shipit:

@mountiny mountiny closed this as completed Oct 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mountiny mountiny

@applausebot applausebot

Labels
Daily KSv2 🔐 LockCashDeploys 🔐 Prevent new code from being deployed to staging StagingDeployCash
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@mountiny @applausebot @kavimuru @shubham1206agra @OSBotify and others