update get contract method from url when open deep link #28125

namhihi237 · 2023-09-25T10:08:20Z

Details

Fixed Issues

$ #27582
PROPOSAL: #27582 (comment)

Tests

Open the app
Open settings->profile->contact method-> add and open any contact method (eg: nanana@gmail.com)
Copy and paste the URL on any report then press "Enter" depending on the platform.
For apps running in emulators, the following commands can be used:

Android: adb devices to get device ID and adb -s '<INSERT_DEVICE_ID_HERE>' shell am start -W -a android.intent.action.VIEW -d "<INSERT_DEEPLINK_URL_HERE>" (eg: adb -s emulator-5554 shell am start -W -a android.intent.action.VIEW -d "new-expensify:////settings/profile/contact-methods/nanana%2540gmail.com/details")

Desktop: Electron: Navigate to the deep link URL from a browser and a popup will appear asking if you want to open it in the desktop app. URL example: new-expensify:////settings/profile/contact-methods/nanana%2540gmail.com/details
Verify that the contact method is open conrrectly

Verify that no errors appear in the JS console

Offline tests

The same test

QA Steps

Open the app
Open settings->profile->contact method-> add and open any contact method (eg: nanana@gmail.com)
Copy and paste the URL on any report then click open the link

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Web

web.mov

Mobile Web - Chrome

mwb.mov

Mobile Web - Safari

safari.mov

Desktop

desktop.mov

iOS

ios.mov

Android

android.mov

melvin-bot · 2023-09-25T11:23:42Z

@narefyev91 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

narefyev91 · 2023-09-26T16:53:03Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

web1.mov

Mobile Web - Chrome

android-web1.mov

Mobile Web - Safari

ios-web1.mov

Desktop

desktop1.mov

iOS

ios1.mov

Android

android1.mov

narefyev91

LGTM!
🎀 👀 🎀 C+ reviewed

narefyev91 · 2023-09-28T07:11:50Z

friendly bump @pecanoro :-)

pecanoro · 2023-09-28T08:05:51Z

The QA steps seem wrong, don't you have to paste the URL first and then click on it?

namhihi237 · 2023-09-28T08:17:02Z

@pecanoro I tried to copy the link and open it on the desktop it is something like this:
http://localhost:8083/settings/profile/contact-methods/nanana%40gmail.com/details

=> but It opens the browser

namhihi237 · 2023-09-28T08:46:20Z

Maybe due I'm open on dev. I try to download app staging. We only need to click open the link on the message. I updated step for QA

pecanoro · 2023-09-28T09:53:25Z

src/CONST.ts

@@ -1252,6 +1252,8 @@ const CONST = {
        DATE_TIME_FORMAT: /^\d{2}-\d{2} \d{2}:\d{2} [AP]M$/,
        ATTACHMENT_ROUTE: /\/r\/(\d*)\/attachment/,
        ILLEGAL_FILENAME_CHARACTERS: /\/|<|>|\*|"|:|\?|\\|\|/g,
+
+        ENCODE_PERCENT_CHARACTER: /%(25)+/g,


This will match things like %252525 is that correct?

Yes, correct

Hmm, I see why now, a bit of an edge case but why not lol

OSBotify · 2023-09-29T04:41:49Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2023-10-02T17:47:52Z

🚀 Deployed to staging by https://github.com/pecanoro in version: 1.3.76-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-10-03T15:48:49Z

🚀 Deployed to production by https://github.com/mountiny in version: 1.3.76-6 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

OSBotify · 2023-10-03T16:13:33Z

🚀 Deployed to staging by https://github.com/pecanoro in version: 1.3.77-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-10-05T00:20:23Z

🚀 Deployed to production by https://github.com/mountiny in version: 1.3.77-7 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

update get contract method from url when open deep link

049cccd

namhihi237 marked this pull request as ready for review September 25, 2023 11:23

namhihi237 requested a review from a team as a code owner September 25, 2023 11:23

melvin-bot bot removed the request for review from a team September 25, 2023 11:23

melvin-bot bot requested a review from narefyev91 September 25, 2023 11:23

narefyev91 approved these changes Sep 26, 2023

View reviewed changes

melvin-bot bot requested a review from pecanoro September 26, 2023 16:53

pecanoro approved these changes Sep 28, 2023

View reviewed changes

pecanoro reviewed Sep 28, 2023

View reviewed changes

pecanoro approved these changes Sep 29, 2023

View reviewed changes

pecanoro merged commit b94c32c into Expensify:main Sep 29, 2023
23 of 24 checks passed

OSBotify mentioned this pull request Oct 2, 2023

Deploy Checklist: New Expensify 2023-10-02 #28635

Closed

lanitochka17 mentioned this pull request Oct 2, 2023

[$500] Chat - Messages sent in offline mode appear above the chat history #28651

Closed

6 tasks

melvin-bot bot mentioned this pull request Oct 3, 2023

[PAID] [$500] Web - Hmm its not here page is displayed on visiting contact method by deep link and reload #27582

Closed

6 tasks

OSBotify mentioned this pull request Oct 3, 2023

Deploy Checklist: New Expensify 2023-10-03 #28727

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

update get contract method from url when open deep link #28125

update get contract method from url when open deep link #28125

namhihi237 commented Sep 25, 2023 •

edited

Loading

melvin-bot bot commented Sep 25, 2023

narefyev91 commented Sep 26, 2023

narefyev91 left a comment

narefyev91 commented Sep 28, 2023

pecanoro commented Sep 28, 2023

namhihi237 commented Sep 28, 2023

namhihi237 commented Sep 28, 2023

pecanoro Sep 28, 2023

namhihi237 Sep 28, 2023

pecanoro Sep 29, 2023

OSBotify commented Sep 29, 2023

OSBotify commented Oct 2, 2023

OSBotify commented Oct 3, 2023

OSBotify commented Oct 3, 2023

OSBotify commented Oct 5, 2023

update get contract method from url when open deep link #28125

update get contract method from url when open deep link #28125

Conversation

namhihi237 commented Sep 25, 2023 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Sep 25, 2023

narefyev91 commented Sep 26, 2023

Reviewer Checklist

Screenshots/Videos

narefyev91 left a comment

Choose a reason for hiding this comment

narefyev91 commented Sep 28, 2023

pecanoro commented Sep 28, 2023

namhihi237 commented Sep 28, 2023

namhihi237 commented Sep 28, 2023

pecanoro Sep 28, 2023

Choose a reason for hiding this comment

namhihi237 Sep 28, 2023

Choose a reason for hiding this comment

pecanoro Sep 29, 2023

Choose a reason for hiding this comment

OSBotify commented Sep 29, 2023

OSBotify commented Oct 2, 2023

OSBotify commented Oct 3, 2023

OSBotify commented Oct 3, 2023

OSBotify commented Oct 5, 2023

namhihi237 commented Sep 25, 2023 •

edited

Loading