Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Internal QA] Add enable wallet state button if the submitter hasn't completed the kyc #29430

Merged
merged 14 commits into from
Oct 19, 2023

Conversation

techievivek
Copy link
Contributor

@techievivek techievivek commented Oct 12, 2023

Details

If there are queued reimbursements for the user and if they are on silver wallet then let's show an enable wallet button that will allow the user to add the wallet to receive the reimbursements.

Fixed Issues

$ https://github.com/Expensify/Expensify/issues/324579
PROPOSAL:

Tests

  1. Login to newDot as a gold wallet user member.
  2. Randomly send money to any other user who is on a silver wallet.
  3. Confirm that you are able to send the money without any issue and the chat report, IOU report and transaction report are all created and rendered correctly.
  4. Login to newDot as silver wallet user and go to the chat report with gold wallet user.
  5. Confirm you can see a preview of the IOU report.
  6. Click on it and it will take you to the IOU report where you can see the enable wallet button.
  7. Confirm the IOU action preview is rendered correctly.
  8. Click on enable wallet button and it should open the enable-payment page.
  • Verify that no errors appear in the JS console

Offline tests

QA Steps

Same as tests.

  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
    • MacOS: Desktop
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I followed proper code patterns (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
    • I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
      • If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
    • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
    • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
    • I verified the JSDocs style guidelines (in STYLE.md) were followed
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
  • I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
  • I verified that if a function's arguments changed that all usages have also been updated correctly
  • If a new component is created I verified that:
    • A similar component doesn't exist in the codebase
    • All props are defined accurately and each prop has a /** comment above it */
    • The file is named correctly
    • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
    • The only data being stored in the state is data necessary for rendering and nothing else
    • If we are not using the full Onyx data that we loaded, I've added the proper selector in order to ensure the component only re-renders when the data it is using changes
    • For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
    • Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
    • All JSX used for rendering exists in the render method
    • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
  • I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

MacOS: Chrome / Safari
Screen.Recording.2023-10-17.at.10.52.27.PM.mov
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Desktop

@techievivek techievivek self-assigned this Oct 12, 2023
@techievivek techievivek changed the title added enable wallet state Add enable wallet state button if the submitter hasn't completed the kyc Oct 12, 2023
@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Oct 12, 2023

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 3fdc0df
Status: ✅  Deploy successful!
Preview URL: https://6478cbcd.helpdot.pages.dev
Branch Preview URL: https://techievivek-add-waiting-wall.helpdot.pages.dev

View logs

@techievivek techievivek marked this pull request as ready for review October 17, 2023 17:23
@techievivek techievivek requested a review from a team as a code owner October 17, 2023 17:23
@melvin-bot melvin-bot bot requested review from fedirjh and removed request for a team October 17, 2023 17:23
@melvin-bot
Copy link

melvin-bot bot commented Oct 17, 2023

@fedirjh Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

Copy link
Contributor

@MariaHCD MariaHCD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good so far! Some minor comments.

@fedirjh, we'd appreciate a code review from you as well. This one is critical for an upcoming conference.

I can handle testing on all platforms since this requires a Gold wallet.

src/languages/en.ts Outdated Show resolved Hide resolved
src/pages/home/report/ReportActionItem.js Outdated Show resolved Hide resolved
Copy link
Contributor

@fedirjh fedirjh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code looks good, but it still should be tested. Is there a beta for the gold wallet?

src/pages/home/report/ReportActionItem.js Outdated Show resolved Hide resolved
@MariaHCD
Copy link
Contributor

@techievivek can you also merge main into this branch?

@MariaHCD
Copy link
Contributor

but it still should be tested. Is there a beta for the gold wallet?

I'm testing now. Everyone is on the wallet beta (with a silver wallet) but we do not have the ability to create test gold wallets at the moment.

@MariaHCD
Copy link
Contributor

@techievivek I notice that the send money flow keeps redirecting the payer to the KYC flow even if the payer's wallet is activated:

Screen.Recording.2023-10-18.at.3.58.17.PM.mov

Copy link
Contributor

@MariaHCD MariaHCD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Noticed a few things:

  1. We need to direct the user to add a PBA first if they don't have one, this logic is handled by the KYCWall component, I think we should be able to use it here.
  2. I'm seeing the report action twice and with incorrect messaging:

Payer with gold wallet sees this:

Screenshot 2023-10-18 at 4 35 44 PM

Payee with silver wallet sees this:

Screenshot 2023-10-18 at 4 35 56 PM

src/pages/home/report/ReportActionItem.js Outdated Show resolved Hide resolved
@MariaHCD
Copy link
Contributor

In the interest of saving time, I've DRY'd some code and added the use of the KYCWall

@MariaHCD
Copy link
Contributor

MariaHCD commented Oct 18, 2023

We still need to:

  1. Figure out why the queued action is being displayed twice
  2. Figure out why a payer can't get past the KYC flow when sending money

@MariaHCD
Copy link
Contributor

Okay, fixed the incorrect message for the payer:

Screenshot 2023-10-18 at 5 11 38 PM

But the action is still showing twice...

) : null}
)}
{shouldShowEnableWalletButton && (
<KYCWall
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe there may be a console error due to using KYCWall in ReportActionItemBasicMessage. IIRC that was the case when I attempted the same change.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you referring to this error? I think wrapping the button inside a fragment should fix this warning. I will suggest the changes.

Screenshot 2023-10-18 at 6 19 25 PM

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Testing it, thanks.

Copy link
Contributor Author

@techievivek techievivek Oct 19, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That worked 🎉, but I am curious to learn how it fixed that error? Because there is just a single element right? KYCWall so why do we need a fragment here?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As ReportActionItemBasicMessage expects only one element, it is necessary to wrap both the "Add Bank" button and the KYCWall with a fragment. Without this fragment, React will treat both elements (the first button and the KYCWall) as an array. It's important to note that even if the { bool && <Component /> } condition evaluates to false, it will still be passed to the parent component as a false value. So, in our case, it's passed as [false, KYCWall]. By wrapping them in a single fragment, it ensures that they are always passed as a single element.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting, but by just wrapping the KycWall in a fragment it looks like the error is gone, how does that work? Any idea?

Copy link
Contributor Author

@techievivek techievivek Oct 19, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah no, the user is alreadt on the gold wallet that's why this condition is not being called.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The error is still there. What you explained make sense now. Thanks 👍

@techievivek techievivek changed the title Add enable wallet state button if the submitter hasn't completed the kyc [Internal QA] Add enable wallet state button if the submitter hasn't completed the kyc Oct 18, 2023
Copy link
Contributor

@fedirjh fedirjh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code looks good. I just tested some hardcoded values and it seems to be working fine

CleanShot.2023-10-18.at.18.13.08-converted.mp4

src/pages/home/report/ReportActionItem.js Outdated Show resolved Hide resolved
src/pages/home/report/ReportActionItem.js Outdated Show resolved Hide resolved
) : null}
)}
{shouldShowEnableWalletButton && (
<KYCWall
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you referring to this error? I think wrapping the button inside a fragment should fix this warning. I will suggest the changes.

Screenshot 2023-10-18 at 6 19 25 PM

MariaHCD
MariaHCD previously approved these changes Oct 19, 2023
@MariaHCD
Copy link
Contributor

MariaHCD commented Oct 19, 2023

Reviewer Checklist

  • I have verified the author checklist is complete (all boxes are checked off).
  • I verified the correct issue is linked in the ### Fixed Issues section above
  • I verified testing steps are clear and they cover the changes made in this PR
    • I verified the steps for local testing are in the Tests section
    • I verified the steps for Staging and/or Production testing are in the QA steps section
    • I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I checked that screenshots or videos are included for tests on all platforms
  • I included screenshots or videos for tests on all platforms
  • I verified tests pass on all platforms & I tested again on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
    • MacOS: Desktop
  • If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
  • I verified proper code patterns were followed (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
    • I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
    • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
    • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
    • I verified the JSDocs style guidelines (in STYLE.md) were followed
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I verified that this PR follows the guidelines as stated in the Review Guidelines
  • I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
  • I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
  • I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
  • If a new component is created I verified that:
    • A similar component doesn't exist in the codebase
    • All props are defined accurately and each prop has a /** comment above it */
    • The file is named correctly
    • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
    • The only data being stored in the state is data necessary for rendering and nothing else
    • For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
    • Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
    • All JSX used for rendering exists in the render method
    • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
  • I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web
Screen.Recording.2023-10-19.at.11.46.58.AM.mov
Screen.Recording.2023-10-19.at.11.54.57.AM.mov
Mobile Web - Chrome
Screen.Recording.2023-10-19.at.11.56.57.AM.mov
Mobile Web - Safari
Screen.Recording.2023-10-19.at.12.06.15.PM.mov
Desktop
Screen.Recording.2023-10-19.at.11.55.35.AM.mov
iOS
Screen.Recording.2023-10-19.at.12.08.33.PM.mov
Android
Screen.Recording.2023-10-19.at.12.51.13.PM.mov

@MariaHCD
Copy link
Contributor

LGTM, we're going to address polish items in follow up PRs. Please final review, @fedirjh 🙏🏼

Copy link
Contributor

@fedirjh fedirjh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, just one little change and should be ready to get merged.

<Button
success
style={[styles.w100, styles.requestPreviewBox]}
text={props.translate('bankAccount.addBankAccount')}
onPress={() => BankAccounts.openPersonalBankAccountSetupView(props.report.reportID)}
pressOnEnter
/>
) : null}
)}
<>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This fragment should wrap both elements, the button and the KYCWall.

Copy link
Contributor

@fedirjh fedirjh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@melvin-bot melvin-bot bot requested a review from thienlnam October 19, 2023 13:20
@melvin-bot
Copy link

melvin-bot bot commented Oct 19, 2023

@thienlnam Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@melvin-bot
Copy link

melvin-bot bot commented Oct 19, 2023

🎯 @fedirjh, thanks for reviewing and testing this PR! 🎉

An E/App issue has been created to issue payment here: #29973.

@MariaHCD MariaHCD merged commit 9b032d2 into main Oct 19, 2023
16 checks passed
@MariaHCD MariaHCD deleted the techievivek_add_waiting_wallet_state branch October 19, 2023 13:21
@OSBotify
Copy link
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify
Copy link
Contributor

🚀 Deployed to staging by https://github.com/MariaHCD in version: 1.3.88-0 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify
Copy link
Contributor

🚀 Deployed to production by https://github.com/chiragsalian in version: 1.3.88-11 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 failure ❌
🕸 web 🕸 success ✅

@@ -588,6 +588,8 @@ export default {
duplicateWaypointsErrorMessage: 'Por favor elimina los puntos de ruta duplicados',
emptyWaypointsErrorMessage: 'Por favor introduce al menos dos puntos de ruta',
},
waitingOnEnabledWallet: ({submitterDisplayName}: WaitingOnBankAccountParams) => `nicio el pago, pero no se procesará hasta que ${submitterDisplayName} active su Billetera`,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@techievivek this should be Inició or inició, can you submit a PR to update please?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cead22 Added here: #30335

@techievivek techievivek mentioned this pull request Oct 25, 2023
57 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants