Remove hidden reports like threads from the global unread count #30013

marcaaron · 2023-10-19T18:14:01Z

cc @mountiny @chiragsalian

Details

When a user looks at a thread they will become a participant with a "hidden" notification preference.
These chats do not show up in the LHN
New messages can arrive and the report would be considered "unread"
However, since they are "hidden" we should not include these in the global unread count otherwise you will be totally confused about which reports are "unread". And think the app is lying to you.

Fixed Issues

$ https://github.com/Expensify/Expensify/issues/328038

Tests

Create a chat between User A and User B
As User A leave a comment and reply to it - creating a "thread"
As User B look at the thread, but do not leave any comments
As User B navigate to a different chat
As User A leave a comment on the thread to mark it as "unread" for the User B
As User B verify that the report is not in the LHN and that the global unread counter did not increment

Verify that no errors appear in the JS console

Offline tests

N/A

QA Steps

Same as tests

Verify that no errors appear in the JS console

PR Author Checklist

I linked the correct issue in the ### Fixed Issues section above
I wrote clear testing steps that cover the changes made in this PR
- I added steps for local testing in the Tests section
- I added steps for the expected offline behavior in the Offline steps section
- I added steps for Staging and/or Production testing in the QA steps section
- I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
I included screenshots or videos for tests on all platforms
I ran the tests on all platforms & verified they passed on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
I followed proper code patterns (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  - If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I followed the guidelines as stated in the Review Guidelines
I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
I verified that if a function's arguments changed that all usages have also been updated correctly
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- If we are not using the full Onyx data that we loaded, I've added the proper selector in order to ensure the component only re-renders when the data it is using changes
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

cloudflare-workers-and-pages · 2023-10-19T18:15:07Z

Deploying with Cloudflare Pages

Latest commit:	`8084b25`
Status:	✅ Deploy successful!
Preview URL:	https://3c4f0fb7.helpdot.pages.dev
Branch Preview URL:	https://marcaaron-fixglobalunreadind.helpdot.pages.dev

View logs

src/libs/UnreadIndicatorUpdater/index.js

OSBotify · 2023-10-19T23:41:21Z

🧪🧪 Use the links below to test this build in android and iOS. Happy testing! 🧪🧪

android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.amazonaws.com/android/30013/index.html	https://ad-hoc-expensify-cash.s3.amazonaws.com/ios/30013/index.html

desktop 💻	web 🕸️
https://ad-hoc-expensify-cash.s3.amazonaws.com/desktop/30013/NewExpensify.dmg	https://30013.pr-testing.expensify.com

mountiny · 2023-10-20T00:07:35Z

Down to just one now! 💪

but cannot find it in focus mode either :D

marcaaron · 2023-10-20T19:32:51Z

@mountiny Can you try debug and see which report it is?

mountiny · 2023-10-23T13:43:58Z

It the expensify SF lounge public room and I cannot find it in the LHN or even in the search, so something must be up with this. I am using most recent mode

marcaaron · 2023-10-23T21:20:48Z

Interesting. Maybe it's because it's a public room. I'll try to look into that one next. Thanks for spotting.

melvin-bot · 2023-10-25T02:37:09Z

@akinwale Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

marcaaron · 2023-10-25T02:37:21Z

Tested this one on all platforms and it's ready for review now.

mountiny

Code looks good to me! @akinwale are you able to prioritize this review and testing in coming day? thanks!

akinwale · 2023-10-25T19:17:48Z

Code looks good to me! @akinwale are you able to prioritize this review and testing in coming day? thanks!

Yes, I can do this.

akinwale · 2023-10-26T11:09:44Z

Reviewing now.

akinwale · 2023-10-26T11:54:34Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

Mobile Web - Chrome

Mobile Web - Safari

Desktop

iOS

Android

akinwale

LGTM.

Tests well.

melvin-bot · 2023-10-26T11:55:33Z

@srikarparsi Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

melvin-bot · 2023-10-26T11:55:38Z

🎯 @akinwale, thanks for reviewing and testing this PR! 🎉

An E/App issue has been created to issue payment here: #30430.

marcaaron · 2023-10-26T18:37:08Z

Got one approving review and checklist done so gonna merge this one!

OSBotify · 2023-10-26T18:48:06Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2023-10-26T22:59:08Z

🚀 Deployed to staging by https://github.com/marcaaron in version: 1.3.92-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-10-30T07:42:26Z

🚀 Deployed to production by https://github.com/Beamanator in version: 1.3.92-4 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-10-30T08:03:23Z

🚀 Deployed to staging by https://github.com/marcaaron in version: 1.3.93-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-10-31T21:36:32Z

🚀 Deployed to production by https://github.com/Beamanator in version: 1.3.93-1 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

marcaaron · 2023-11-09T19:58:12Z

This was fixed, but I think we need some issue to get @akinwale paid for the review. The issue linked here is in E/E so no BZ gets assigned.

I am going OOO next week so maybe @mountiny can help with this. Otherwise, @akinwale please remind me if I fail to follow up here!

akinwale · 2023-11-09T20:19:42Z

This was fixed, but I think we need some issue to get @akinwale paid for the review. The issue linked here is in E/E so no BZ gets assigned.

I am going OOO next week so maybe @mountiny can help with this. Otherwise, @akinwale please remind me if I fail to follow up here!

I already got paid for this. #30430

marcaaron · 2023-11-09T20:52:00Z

Ah ok thanks!

Remove hidden reports like threads from the global unread count

b4c0c1d

marcaaron self-assigned this Oct 19, 2023

mountiny added the Ready To Build label Oct 19, 2023

mountiny reviewed Oct 19, 2023

View reviewed changes

src/libs/UnreadIndicatorUpdater/index.js Outdated Show resolved Hide resolved

Switch to &&

8084b25

marcaaron removed the Ready To Build label Oct 19, 2023

marcaaron marked this pull request as ready for review October 25, 2023 02:37

marcaaron requested a review from a team as a code owner October 25, 2023 02:37

melvin-bot bot removed the request for review from a team October 25, 2023 02:37

melvin-bot bot requested a review from akinwale October 25, 2023 02:37

mountiny approved these changes Oct 25, 2023

View reviewed changes

akinwale approved these changes Oct 26, 2023

View reviewed changes

melvin-bot bot requested a review from srikarparsi October 26, 2023 11:55

melvin-bot bot mentioned this pull request Oct 26, 2023

[PAY ON NOV 7TH] Payment issue for E/App PR#30013 #30430

Closed

marcaaron merged commit e47a256 into main Oct 26, 2023
13 of 30 checks passed

marcaaron deleted the marcaaron-fixGlobalUnreadIndicator branch October 26, 2023 18:37

marcaaron removed the request for review from srikarparsi October 26, 2023 18:37

fedirjh mentioned this pull request Oct 26, 2023

Fix: Leave thread chat when has no comment #27849

Closed

59 tasks

OSBotify mentioned this pull request Oct 26, 2023

Deploy Checklist: New Expensify 2023-10-26 #30469

Closed

64 tasks

dukenv0307 mentioned this pull request Oct 30, 2023

[$500] Desktop - Unread count is incorrect when joining a thread #27512

Closed

6 tasks

OSBotify mentioned this pull request Oct 30, 2023

Deploy Checklist: New Expensify 2023-10-30 #30560

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Remove hidden reports like threads from the global unread count #30013

Remove hidden reports like threads from the global unread count #30013

marcaaron commented Oct 19, 2023 •

edited

Loading

cloudflare-workers-and-pages bot commented Oct 19, 2023 •

edited

Loading

OSBotify commented Oct 19, 2023

mountiny commented Oct 20, 2023

marcaaron commented Oct 20, 2023

mountiny commented Oct 23, 2023

marcaaron commented Oct 23, 2023

melvin-bot bot commented Oct 25, 2023

marcaaron commented Oct 25, 2023

mountiny left a comment

akinwale commented Oct 25, 2023

akinwale commented Oct 26, 2023

akinwale commented Oct 26, 2023

akinwale left a comment

melvin-bot bot commented Oct 26, 2023

melvin-bot bot commented Oct 26, 2023

marcaaron commented Oct 26, 2023

OSBotify commented Oct 26, 2023

OSBotify commented Oct 26, 2023

OSBotify commented Oct 30, 2023

OSBotify commented Oct 30, 2023

OSBotify commented Oct 31, 2023

marcaaron commented Nov 9, 2023

akinwale commented Nov 9, 2023

marcaaron commented Nov 9, 2023

Remove hidden reports like threads from the global unread count #30013

Remove hidden reports like threads from the global unread count #30013

Conversation

marcaaron commented Oct 19, 2023 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

cloudflare-workers-and-pages bot commented Oct 19, 2023 • edited Loading

Deploying with Cloudflare Pages

OSBotify commented Oct 19, 2023

mountiny commented Oct 20, 2023

marcaaron commented Oct 20, 2023

mountiny commented Oct 23, 2023

marcaaron commented Oct 23, 2023

melvin-bot bot commented Oct 25, 2023

marcaaron commented Oct 25, 2023

mountiny left a comment

Choose a reason for hiding this comment

akinwale commented Oct 25, 2023

akinwale commented Oct 26, 2023

akinwale commented Oct 26, 2023

Reviewer Checklist

Screenshots/Videos

akinwale left a comment

Choose a reason for hiding this comment

melvin-bot bot commented Oct 26, 2023

melvin-bot bot commented Oct 26, 2023

marcaaron commented Oct 26, 2023

OSBotify commented Oct 26, 2023

OSBotify commented Oct 26, 2023

OSBotify commented Oct 30, 2023

OSBotify commented Oct 30, 2023

OSBotify commented Oct 31, 2023

marcaaron commented Nov 9, 2023

akinwale commented Nov 9, 2023

marcaaron commented Nov 9, 2023

marcaaron commented Oct 19, 2023 •

edited

Loading

cloudflare-workers-and-pages bot commented Oct 19, 2023 •

edited

Loading