-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: add flags emojis support for Windows #32396
Conversation
Reviewer Checklist
Screenshots/VideosAndroid: NativeScreen.Recording.2023-12-03.at.7.06.58.PM.movAndroid: mWeb ChromeflagsAndroidmWebChrome.moviOS: NativeflagsiOSNative.moviOS: mWeb SafariflagsiOSSafari.movWindows: ChromeemojisWebWindows.mp4MacOS: DesktopflagsDesktop.mov |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
🚀 Cherry-picked to staging by https://github.com/yuwenmemon in version: 1.4.7-4 🚀
@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes. |
🚀 Deployed to staging by https://github.com/puneetlath in version: 1.4.8-0 🚀
|
🚀 Deployed to production by https://github.com/yuwenmemon in version: 1.4.8-3 🚀
|
🚀 Deployed to production by https://github.com/yuwenmemon in version: 1.4.8-3 🚀
|
Details
Add flags emoji support for Windows
Fixed Issues
$ #31717
PROPOSAL: #31717 (comment)
Tests
Offline tests
QA Steps
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)myBool && <MyComponent />
.src/languages/*
files and using the translation methodWaiting for Copy
label for a copy review on the original GH to get the correct copy.STYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Android: Native
31717_android_native.mp4
Android: mWeb Chrome
31717_android_chrome.mp4
iOS: Native
31717_ios_native.mp4
iOS: mWeb Safari
31717_ios_safari.mp4
Windows Chrome
31717_windows_chrome.mp4
MacOS: Desktop
31717_mac_desktop.mp4