[HOLD for payment 2024-01-04] [$125] Web - Emoji - Flag emoji category is missing

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: v1.4.17-1
Reproducible in staging?: y
Reproducible in production?: n
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Action Performed:

1. Go to any chat.
2. Open emoji picker.

Expected Result:

Flag emoji category is present.

Actual Result:

Flag emoji category is missing. It is present on production.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01c0b56adc8fc28c3f
• Upwork Job ID: 1739657472856895488
• Last Price Increase: 2023-12-26
• Automatic offers:
• aimane-chnaif | Reviewer | 28070186
• mkhutornyi | Contributor | 28070187

Issue Owner

Current Issue Owner: @JmillsExpensify

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @iwiznia (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[mkhutornyi]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Web - Emoji - Flag emoji category is missing

What is the root cause of that problem?

#32396 was reverted in #31479

What changes do you think we should make in order to solve the problem?

Add back changes in #32396
So just remove windows code here:

App/assets/emojis/index.ts

Lines 36 to 49 in de5a943

	// On windows, flag emojis are not supported
	const emojisForOperatingSystem =
	getOperatingSystem() === CONST.OS.WINDOWS
	? emojis.slice(
	0,
	emojis.findIndex((emoji) => {
	if (!('header' in emoji)) {
	return;
	}
	return emoji.header && emoji.code === 'flags';
	}),
	)
	: emojis;

[mountiny]

This is not a blocker and caused by two changes at the same time @TMisiukiewicz will handle this as a follow up to their PR, left a comment here https://github.com/Expensify/App/pull/31479/files#r1436483172

[mountiny]

Or given @TMisiukiewicz will be out til new year and given the change should be simple @mkhutornyi are you up for making this PR for $125?

[mkhutornyi]

sure

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01c0b56adc8fc28c3f

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @aimane-chnaif (External)

[melvin-bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.18-8 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• restore back windows flag emojis #33603

If no regressions arise, payment will be issued on 2024-01-04. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

• @mkhutornyi requires payment automatic offer (Contributor)

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@mountiny] The PR that introduced the bug has been identified. Link to the PR:
• [@mountiny] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@mountiny] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@mkhutornyi] Determine if we should create a regression test for this bug.
• [@mkhutornyi] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@JmillsExpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[melvin-bot]

@JmillsExpensify, @mountiny, @mkhutornyi Huh... This is 4 days overdue. Who can take care of this?

[mountiny]

this issue stemmed from incorrectly resolved conflicts and th author of the PR has already been notified, I think that is enough as far as the checklist goes here

Payment here is $125 to @mkhutornyi

[mountiny]

No regression test required for this either I think

[melvin-bot]

@JmillsExpensify, @mountiny, @mkhutornyi Still overdue 6 days?! Let's take care of this!

[melvin-bot]

@JmillsExpensify, @mountiny, @mkhutornyi 10 days overdue. I'm getting more depressed than Marvin.

[melvin-bot]

@JmillsExpensify, @mountiny, @mkhutornyi 12 days overdue now... This issue's end is nigh!

[mkhutornyi]

waiting for payment

[JmillsExpensify]

Payment made based on this summary!