-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[NoQA] Clean up - Rename next step to be singular #33249
Changes from 2 commits
7f95ad2
76ac9d6
7ff3a95
7eb84d4
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -567,7 +567,7 @@ export default { | |
settledElsewhere: 'Paid elsewhere', | ||
settleExpensify: ({formattedAmount}: SettleExpensifyCardParams) => (formattedAmount ? `Pay ${formattedAmount} with Expensify` : `Pay with Expensify`), | ||
payElsewhere: 'Pay elsewhere', | ||
nextSteps: 'Next Steps', | ||
nextStep: 'Next Steps', | ||
finished: 'Finished', | ||
requestAmount: ({amount}: RequestAmountParams) => `request ${amount}`, | ||
requestedAmount: ({formattedAmount, comment}: RequestedAmountMessageParams) => `requested ${formattedAmount}${comment ? ` for ${comment}` : ''}`, | ||
|
@@ -1429,7 +1429,7 @@ export default { | |
description: 'A day or two after you add your account to Expensify we send three (3) transactions to your account. They have a merchant line like "Expensify, Inc. Validation".', | ||
descriptionCTA: 'Please enter each transaction amount in the fields below. Example: 1.51.', | ||
reviewingInfo: "Thanks! We're reviewing your information, and will be in touch shortly. Please check your chat with Concierge ", | ||
forNextSteps: ' for next steps to finish setting up your bank account.', | ||
forNextStep: ' for next steps to finish setting up your bank account.', | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Same question |
||
letsChatCTA: "Yes, let's chat", | ||
letsChatText: 'Thanks for doing that. We need your help verifying a few pieces of information, but we can work this out quickly over chat. Ready?', | ||
letsChatTitle: "Let's chat!", | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -560,7 +560,7 @@ export default { | |
settledElsewhere: 'Pagado de otra forma', | ||
settleExpensify: ({formattedAmount}: SettleExpensifyCardParams) => (formattedAmount ? `Pagar ${formattedAmount} con Expensify` : `Pagar con Expensify`), | ||
payElsewhere: 'Pagar de otra forma', | ||
nextSteps: 'Pasos Siguientes', | ||
nextStep: 'Pasos Siguientes', | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Same question |
||
finished: 'Finalizado', | ||
requestAmount: ({amount}: RequestAmountParams) => `solicitar ${amount}`, | ||
requestedAmount: ({formattedAmount, comment}: RequestedAmountMessageParams) => `solicité ${formattedAmount}${comment ? ` para ${comment}` : ''}`, | ||
|
@@ -1452,7 +1452,7 @@ export default { | |
'Uno o dos días después de añadir tu cuenta a Expensify, te enviaremos tres (3) transacciones a tu cuenta. Tienen un nombre de comerciante similar a "Expensify, Inc. Validation".', | ||
descriptionCTA: 'Introduce el importe de cada transacción en los campos siguientes. Ejemplo: 1.51.', | ||
reviewingInfo: '¡Gracias! Estamos revisando tu información y nos comunicaremos contigo en breve. Consulta el chat con Concierge ', | ||
forNextSteps: ' para conocer los próximos pasos para terminar de configurar tu cuenta bancaria.', | ||
forNextStep: ' para conocer los próximos pasos para terminar de configurar tu cuenta bancaria.', | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Same question |
||
letsChatCTA: 'Sí, vamos a chatear', | ||
letsChatText: 'Gracias. Necesitamos tu ayuda para verificar la información, pero podemos hacerlo rápidamente a través del chat. ¿Estás listo?', | ||
letsChatTitle: '¡Vamos a chatear!', | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should it be renamed if it's corresponding to the text it means?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, good question. Let me ask @mountiny about it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is good now, the design has the plural name in it but in sake of consistency elsewhere I think its better ot keep the name singular here