-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[NoQA] Clean up - Rename next step to be singular #33249
[NoQA] Clean up - Rename next step to be singular #33249
Conversation
…ture/32286-rename-next-step
nextSteps: 'Next Steps', | ||
nextStep: 'Next Steps', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should it be renamed if it's corresponding to the text it means?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, good question. Let me ask @mountiny about it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is good now, the design has the plural name in it but in sake of consistency elsewhere I think its better ot keep the name singular here
@@ -1429,7 +1429,7 @@ export default { | |||
description: 'A day or two after you add your account to Expensify we send three (3) transactions to your account. They have a merchant line like "Expensify, Inc. Validation".', | |||
descriptionCTA: 'Please enter each transaction amount in the fields below. Example: 1.51.', | |||
reviewingInfo: "Thanks! We're reviewing your information, and will be in touch shortly. Please check your chat with Concierge ", | |||
forNextSteps: ' for next steps to finish setting up your bank account.', | |||
forNextStep: ' for next steps to finish setting up your bank account.', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same question
@@ -560,7 +560,7 @@ export default { | |||
settledElsewhere: 'Pagado de otra forma', | |||
settleExpensify: ({formattedAmount}: SettleExpensifyCardParams) => (formattedAmount ? `Pagar ${formattedAmount} con Expensify` : `Pagar con Expensify`), | |||
payElsewhere: 'Pagar de otra forma', | |||
nextSteps: 'Pasos Siguientes', | |||
nextStep: 'Pasos Siguientes', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same question
@@ -1452,7 +1452,7 @@ export default { | |||
'Uno o dos días después de añadir tu cuenta a Expensify, te enviaremos tres (3) transacciones a tu cuenta. Tienen un nombre de comerciante similar a "Expensify, Inc. Validation".', | |||
descriptionCTA: 'Introduce el importe de cada transacción en los campos siguientes. Ejemplo: 1.51.', | |||
reviewingInfo: '¡Gracias! Estamos revisando tu información y nos comunicaremos contigo en breve. Consulta el chat con Concierge ', | |||
forNextSteps: ' para conocer los próximos pasos para terminar de configurar tu cuenta bancaria.', | |||
forNextStep: ' para conocer los próximos pasos para terminar de configurar tu cuenta bancaria.', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same question
…ture/32286-rename-next-step
No need for c+ review |
…ture/32286-rename-next-step
Reviewer Checklist
Screenshots/VideosOnly code naming changes Android: NativeAndroid: mWeb ChromeiOS: NativeiOS: mWeb SafariMacOS: Chrome / SafariMacOS: Desktop |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for making this cleaner!
@mountiny looks like this was merged without a test passing. Please add a note explaining why this was done and remove the |
Not an emergency tests were passing from what I saw |
🚀 Deployed to staging by https://github.com/mountiny in version: 1.4.17-1 🚀
|
1 similar comment
🚀 Deployed to staging by https://github.com/mountiny in version: 1.4.17-1 🚀
|
🚀 Deployed to production by https://github.com/mountiny in version: 1.4.17-8 🚀
|
Details
We use
NextStep
andNextSteps
terminology and we decided only use the single variant, thats how its in backend.Fixed Issues
$ #32286
PROPOSAL: N/A
Tests
It is internal chore, so nothing new on UI/UX.
Offline tests
Same as "Tests".
QA Steps
Same as "Tests".
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)myBool && <MyComponent />
.src/languages/*
files and using the translation methodWaiting for Copy
label for a copy review on the original GH to get the correct copy.STYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)Design
label so the design team can review the changes.ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Android: Native
Not required.
Android: mWeb Chrome
Not required.
iOS: Native
Not required.
iOS: mWeb Safari
Not required.
MacOS: Chrome / Safari
Not required.
MacOS: Desktop
Not required.