-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[TS migration] Migrate 'ReportActionItemMoneyReportView.js' to Typescript #33255
[TS migration] Migrate 'ReportActionItemMoneyReportView.js' to Typescript #33255
Conversation
We replace the withWindowDimensions HOC with useWindowDimensions hook.
Hi @c3024! Need your advice with a Type issue coming from a different file: ProblemThe CSS style here is raising this typecheck error from this function: This is caused by the last term in the styles Error can be reproduced like this: Image: Alt way to reproduce errorWe remove Explanation:I've investigated this and it looks like this happens because of a type Mismatch in
Possible Solution:Adding it to the types does not fix the issue: Only way this check goes away is if TextStyle is the only style defined here: But this might not be what we want for this app, I'm not sure what we should do 🤔 |
@neonbhai Please include the suggested changes. |
Co-authored-by: Błażej Kustra <46095609+blazejkustra@users.noreply.github.com>
Co-authored-by: Błażej Kustra <46095609+blazejkustra@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Taking over @blazejkustra review since he is OOO now.
LGTM!
@neonbhai Please pull main
since we had some changes in src/styles/utils/index.ts
.
Also please upload the videos and complete the author checklist. |
This converts shouldShowBreakdown to boolean when rendering conditionally
All platforms tested! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good and tests well.
The reviewer checklist check is failing:
mind revising the checklist @cubuspl42? |
I think we meant to tag @c3024 |
Reviewer Checklist
Screenshots/Videos |
Don't know why it failed despite ticking all boxes. Filled the checklist afresh again. All checks have passed now. |
@amyevans friendly bump to merge this! |
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
🚀 Deployed to staging by https://github.com/amyevans in version: 1.4.17-0 🚀
|
🚀 Deployed to production by https://github.com/mountiny in version: 1.4.17-8 🚀
|
Details
Migrating ReportActionItem/MoneyReportView.js to Typescript
Fixed Issues
$ #31961
PROPOSAL: #31961 (comment)
Tests
Offline tests
Same as Tests Step
QA Steps
Same as Tests Step
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)myBool && <MyComponent />
.src/languages/*
files and using the translation methodWaiting for Copy
label for a copy review on the original GH to get the correct copy.STYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
MacOS: Desktop