-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add leave room report action to app #34694
Conversation
❗ Please, do not use Github auto-linking keywords such as these: close, closes, closed, fix, fixes, fixed, resolve, resolves or resolved. For more details, see the Contributing Guidelines, specifically Submit your pull request for a final review 📖. |
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
Hmmm, I did not ask for puller bear to request you @Gonals. Seems Melvin has an itchy trigger finger. Feel free to ignore this for now until I get my other PRs ready. |
I have read the CLA Document and I hereby sign the CLA |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
With these test steps I'm getting the following error: Policy rooms can not be created on personal policies
-- is there an extra step we need for the test steps to make sure th workspace isn't a personal workspace?
@Julesssss Ah yes I encountered that issue too. Its a bug that I believe is unrelated to this. Let me see if I can find the relevant slack thread. I might just need to merge in main to fix it. Are you selecting a workspace for when you create a room? That is the workaround that worked for me. Something happened I think such that we are allowed to create rooms without selecting workspace and that breaks the flow. Update: relevant slack thread |
I'm not sure tbh. Thanks for the link, it looks like it might be fixed today 🤞 |
@Gonals @Julesssss @jasperhuangg ready for review 🙂 |
We don't need reviewer checklist |
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
🚀 Cherry-picked to staging by https://github.com/francoisl in version: 1.4.33-5 🚀
@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes. |
🚀 Deployed to staging by https://github.com/Julesssss in version: 1.4.34-0 🚀
|
🚀 Deployed to staging by https://github.com/Julesssss in version: 1.4.34-0 🚀
|
🚀 Deployed to production by https://github.com/francoisl in version: 1.4.34-1 🚀
|
Details
Fixed Issues
related to #33574
cc: @jasperhuangg
Tests
Offline tests
QA Steps
Setup
For the private room:
For the workspace visibility room:
For the public room
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)myBool && <MyComponent />
.src/languages/*
files and using the translation methodWaiting for Copy
label for a copy review on the original GH to get the correct copy.STYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)Design
label so the design team can review the changes.ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
MacOS: Desktop