Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update validate page in VBA flow #5251

Merged
merged 6 commits into from
Sep 15, 2021
Merged

Update validate page in VBA flow #5251

merged 6 commits into from
Sep 15, 2021

Conversation

Julesssss
Copy link
Contributor

@Julesssss Julesssss commented Sep 14, 2021 •
edited
Loading

Details

Add a confirmation button to the VBA Validation page and remove the animation image.

Fixed Issues

$ https://github.com/Expensify/Expensify/issues/176433

Tests

  • Create a new user
  • Create workspace via the global create menu
  • Select 'Get Started' after the workspace is created
  • Go through VBA setup using the test credentials in (2), and arrive at Validate step
  • There should be no animated image
  • There should be a button at the bottom marked 'Got it'
  • Tapping the button should close the current page

QA Steps

Run above test

Tested On

  • Web
  • Mobile Web
  • Desktop
  • iOS
  • Android

Screenshots

Web

Screenshot 2021-09-14 at 14 47 27

Mobile Web

Simulator Screen Shot - iPhone 8 - 2021-09-15 at 12 18 18

Desktop

Screenshot 2021-09-15 at 11 34 09

iOS

Simulator Screen Shot - iPhone 8 - 2021-09-15 at 12 15 27

Android

Screenshot_1631705201

@Julesssss Julesssss self-assigned this Sep 14, 2021
@Julesssss Julesssss changed the title Jules update validate page in vba flow Update validate page in VBA flow Sep 14, 2021
@Julesssss Julesssss marked this pull request as ready for review September 15, 2021 11:33
@Julesssss Julesssss requested a review from a team as a code owner September 15, 2021 11:33
@MelvinBot MelvinBot requested review from Gonals and removed request for a team September 15, 2021 11:33
@ctkochan22
Copy link
Contributor

Merging. @Julesssss you need the bank to get to the "VERIFYING" state, which should be flow #1 on the stack overflow

@ctkochan22 ctkochan22 merged commit ac0dc7c into main Sep 15, 2021
@ctkochan22 ctkochan22 deleted the jules-updateValidatePageInVBAFlow branch September 15, 2021 20:30
@OSBotify OSBotify mentioned this pull request Sep 15, 2021
Closed
27 tasks
@OSBotify
Copy link
Contributor

🚀 Deployed to staging by @ctkochan22 in version: 1.0.98-3 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@kavimuru kavimuru mentioned this pull request Sep 16, 2021
Closed
@Julesssss Julesssss mentioned this pull request Sep 16, 2021
Closed
@isagoico
Copy link

@Julesssss We're good to check this PR off then?

@Julesssss
Copy link
Contributor Author

Yep, just doing that now.

@OSBotify
Copy link
Contributor

🚀 Deployed to production by @Jag96 in version: 1.0.99-4 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ctkochan22 ctkochan22 ctkochan22 approved these changes

@Gonals Gonals Awaiting requested review from Gonals

Assignees

@Julesssss Julesssss

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Julesssss @ctkochan22 @OSBotify @isagoico