Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert 'jules-updateValidatePageInVBAFlow' #5301

Closed
wants to merge 2 commits into from

Conversation

Julesssss
Copy link
Contributor

@Julesssss Julesssss commented Sep 16, 2021

Reverts this PR, which introduced this bug. As this is now a prod deploy blocker we need to merge this ASAP to unblock N6.

n6-hold is not relevant here, this revert PR resolves a deployBlocker which will delay n6.

Fixed Issues

$ #5290

Tests | QA Steps

N/A

@Julesssss Julesssss self-assigned this Sep 16, 2021
@Julesssss Julesssss marked this pull request as ready for review September 16, 2021 17:27
@Julesssss Julesssss requested a review from a team as a code owner September 16, 2021 17:27
@MelvinBot MelvinBot requested review from joelbettner and removed request for a team September 16, 2021 17:27
@Julesssss
Copy link
Contributor Author

CC @roryabraham & @AndrewGable, to ensure I'm following this guide correctly.

@Julesssss
Copy link
Contributor Author

@roryabraham this is the part that isn't clear to me:

If your PR has been deployed to staging Your PR is now a production deploy blocker. Report the issue on the PR and apply the DeployBlockerCash label.

Do I just need to mention that this is a revert PR? Don't I also need to add the cherry-pick label so this PR skips the deploy lock check?

@francoisl
Copy link
Contributor

francoisl commented Sep 16, 2021

@Julesssss to confirm, we should add the CP staging label, right?

Yep

@github-actions
Copy link
Contributor

⚠️ ⚠️ Heads up! This pull request has the CP Staging label. ⚠️ ⚠️
Merging it will cause it to be immediately deployed to staging, even if the open StagingDeployCash deploy checklist is locked.

@roryabraham
Copy link
Contributor

@Julesssss That SO is out-of-date, updating it now. We'll want to CP this.

1 similar comment
@roryabraham
Copy link
Contributor

@Julesssss That SO is out-of-date, updating it now. We'll want to CP this.

@francoisl
Copy link
Contributor

I resolved the conflict, can you review again please? + @roryabraham

@Julesssss
Copy link
Contributor Author

HOLD for now. There's a chance this revert was unnecessary. I'm looking into the possibility that the regression was already occurring here.

@Julesssss
Copy link
Contributor Author

Okay, we're now pretty certain that issue did already exist. Closing this PR, thanks for the help all!

@Julesssss Julesssss closed this Sep 17, 2021
@Julesssss Julesssss deleted the jules-revertValidatePageInVBAFlow branch September 17, 2021 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants