-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix chunk load error refresh #53861
Fix chunk load error refresh #53861
Conversation
@ahmedGaber93 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
Reviewer Checklist
Screenshots/VideosAndroid: NativeAndroid: mWeb Chromeaa.mp4iOS: NativeiOS: mWeb Safariii.mp4MacOS: Chrome / Safariww.mp4MacOS: Desktop20241210215035195.mp4 |
For testing, I simulate the case and force reject componentImport = () =>
new Promise((resolve1, reject1) => {
const error = new Error('Loading chunk 189 failed');
error.name = 'ChunkLoadError';
reject1(error);
}); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
🚀 Deployed to staging by https://github.com/marcaaron in version: 9.0.75-0 🚀
|
Can you run this internally? We are able to easily initiate the crash or reload to QA |
I don't actually think this PR can be reliably QA'd so we should just check it off. |
🚀 Deployed to production by https://github.com/luacmartins in version: 9.0.75-6 🚀
|
Explanation of Change
Wr should immediately refresh the page - when chunk loading was failed. Currently we allow user to click twice on r
efresh button
inSomething wrong page
- which does not make sense in current situation.Fixed Issues
$ #52312
PROPOSAL:
Tests
Issue is hard to test. Such case may happened if user will move away from web more than a few hours.
For the C+ easier test may be with using mock data like:
For C+:
Offline tests
No changes
QA Steps
Same as Tests section
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)src/languages/*
files and using the translation methodSTYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)Design
label and/or tagged@Expensify/design
so the design team can review the changes.ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Android: Native
android.mov
Android: mWeb Chrome
android-web.mov
iOS: Native
ios.mov
iOS: mWeb Safari
ios-web.mov
MacOS: Chrome / Safari
web.mov
MacOS: Desktop
desktop.mov