Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Snyk] Security upgrade react-native-svg from 12.1.0 to 12.3.0 #9932

Closed
wants to merge 1 commit into from

Conversation

joelbettner
Copy link
Contributor

This PR was automatically created by Snyk using the credentials of a real user.


Snyk has created this PR to fix one or more vulnerable packages in the `npm` dependencies of this project.

merge advice

Changes included in this PR

  • Changes to the following files to upgrade the vulnerable dependencies to a fixed version:
    • package.json
    • package-lock.json

Vulnerabilities that will be fixed

With an upgrade:
Severity Priority Score (*) Issue Breaking Change Exploit Maturity
high severity 696/1000
Why? Proof of Concept exploit, Has a fix available, CVSS 7.5
Regular Expression Denial of Service (ReDoS)
SNYK-JS-NTHCHECK-1586032
No Proof of Concept

(*) Note that the real score may have changed since the PR was raised.

Commit messages
Package name: react-native-svg The new version differs by 52 commits.

See the full diff

Check the changes in this PR to ensure they won't cause issues with your project.


Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open fix PRs.

For more information:
🧐 View latest project report

🛠 Adjust project settings

📚 Read more about Snyk's upgrade and patch logic


Learn how to fix vulnerabilities with free interactive lessons:

🦉 Learn about vulnerability in an interactive lesson of Snyk Learn.

@joelbettner joelbettner requested a review from a team as a code owner July 14, 2022 21:57
@melvin-bot melvin-bot bot requested review from aldo-expensify and removed request for a team July 14, 2022 21:57
@joelbettner joelbettner self-assigned this Jul 14, 2022
@joelbettner joelbettner reopened this Jul 14, 2022
@joelbettner
Copy link
Contributor Author

@flodnv I followed the instructions found here: https://stackoverflow.com/c/expensify/questions/3465

But it looks like the Snyk automated fix is trying to upgrade multiple different dependencies all at once. Let me know what you think.

@flodnv
Copy link
Contributor

flodnv commented Jul 15, 2022

It's upgrading several dependencies because they are dependencies of react-native-svg. We need to:

  1. Check the changelog
  2. Probably test whatever is using this package, on all platforms...

Feel free to turn this task into an External one (by adding the External label onto the original GH issue)

@joelbettner
Copy link
Contributor Author

I made the issue External. I'll go ahead and close this.

@joelbettner joelbettner closed this Aug 1, 2022
@flodnv flodnv deleted the snyk-fix-84418119231de12c0171a3bd1e12f816 branch February 17, 2023 19:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants