Monster remove ladder

[peonso]

I do not know if it's a bug but from what I tested here, a monster removed a ladder on their way
itemid 1386 a ladder

before

after

@diegorodriguesvieira

[diegorodriguesvieira]

[diegorodriguesvieira]

@peonso This error only happens in OTClient...

[diegorodriguesvieira]

Can anyone help me find this bug in OTClient? :/

[peonso]

edubart/otclient#597
edubart/otclient#418
edubart/otclient#410
https://otland.net/threads/7-x-stairs-ladders-disappear-if-when-i-kill-2-monsters-there.239617/

[diegorodriguesvieira]

Thanks man, I'll try to fix it...

[diegorodriguesvieira]

I found a fix, I don't know if it's the best...

Open tile.cpp and find:
g_game.FreeThing(oldSplash);

And add below:
onUpdateTile();

Find in method void Tile::__updateThing:
onUpdateTileItem(item, oldType, item, newType);

And add below:
onUpdateTile();

I found at: edubart/otclient#418 (comment)

[Anastaciaa]

This is not properly fix. It causes some screen jumps while getting hits.

[peonso]

@Anastaciaa in both OTClient and default one?

[Anastaciaa]

Yes

[diegorodriguesvieira]

@Anastaciaa How can I fix it?

[Anastaciaa]

@diegorodriguesvieira send me your skype ill contact you. I have to look on this through team viewer because it's abit complicated.

[diegorodriguesvieira]

Thank you @Anastaciaa for the help! My skype: diego.ldn

[wadbott]

TFS 1.3 SOLUTION FOR TIBIA 7.4 - 7.72

Open vc14/theforgottenserver.vcxproj

Open tile.cpp, hit CTRL + F and look for "//remove old splash if exists"

Above this phrase add
SpectatorHashSet spectators;
g_game.map.getSpectators(spectators, getPosition(), true, true);

Below postRemoveNotification(oldSplash, nullptr, 0); add
onUpdateTile(spectators);

[pasturryx]

@don-romano i tested your code , but the problem is that after the monter dies if i want to use the ladder, it doesn't allow/let me use it... there is a missing code , any ideas?
`

				SpectatorVec spectators; //7.4 sourceedit fix splash //7.4 sourceedit
				g_game.map.getSpectators(spectators, getPosition(), true, true);//7.4 sourceedit fix splash //7.4 sourceedit
				//remove old splash if exists
				for (ItemVector::const_iterator it = items->getBeginTopItem(), end = items->getEndTopItem(); it != end; ++it) {
					Item* oldSplash = *it;
					if (!Item::items[oldSplash->getID()].isSplash()) {
						continue;
					}

					removeThing(oldSplash, 1);
					oldSplash->setParent(nullptr);
					g_game.ReleaseItem(oldSplash);
					postRemoveNotification(oldSplash, nullptr, 0);
					onUpdateTile(spectators); //7.4 sourceedit fix splash //7.4 sourceedit
					break;`

@peonso