-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
1626 #1628
1626 #1628
Conversation
💚 Basic BGPD CI results: SUCCESS, 0 tests failedResults table
For details, please contact louberger |
Continuous Integration Result: FAILEDSee below for issues. This is a comment from an EXPERIMENTAL automated CI system. Get source and apply patch from patchwork: SuccessfulBuilding Stage: SuccessfulBasic Tests: FailedStatic analyzer (clang): Successful Topology tests on Ubuntu 16.04 amd64: FailedTopology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TOPOU1604-2301/test Topology Tests failed for Topology tests on Ubuntu 16.04 amd64:
see full log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-2301/artifact/TOPOU1604/ErrorLog/log_topotests.txt Topology Tests memory analysis: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-2301/artifact/TOPOU1604/MemoryLeaks/CLANG Static Analyzer Summary
No Changes in Static Analysis warnings compared to base21 Static Analyzer issues remaining.See details at |
Continuous Integration Result: SUCCESSFULCongratulations, this patch passed basic tests Tested-by: NetDEF / OpenSourceRouting.org CI System CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-2301/ This is a comment from an EXPERIMENTAL automated CI system. CLANG Static Analyzer Summary
No Changes in Static Analysis warnings compared to base21 Static Analyzer issues remaining.See details at |
@donaldsharp let's do these as separate PRs. merge #1626 then we'll do this one. |
(rfg->type == RFAPI_GROUP_CFG_VRF ? "" : "bgp "), | ||
afistr, | ||
rfg->plist_export_bgp_name | ||
[afi]); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You're commenting on a removed hunk
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yup, did the review off line and added the comment in wrong place. should have been on lines below (3974)
afistr, | ||
rfg->plist_redist_name | ||
[ZEBRA_ROUTE_BGP_DIRECT] | ||
[afi]); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same comment as above (won't repeat for other cases)
(rfg->type == RFAPI_GROUP_CFG_VRF ? "" : "bgp "), | ||
afistr, | ||
rfg->plist_export_bgp_name | ||
[afi]); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You're commenting on a removed hunk
bgpd/rfapi/bgp_rfapi_cfg.c
Outdated
if (rfg->routemap_redist_name | ||
[ZEBRA_ROUTE_BGP_DIRECT_EXT]) { | ||
if (rfg->plist_redist_name | ||
[ZEBRA_ROUTE_BGP_DIRECT_EXT][afi]) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not a fan of line breaks before indexes -- better to remove whitespace on the indent than to add white space that has semantic implications.
bgpd/rfapi/bgp_rfapi_cfg.c
Outdated
* protocols here | ||
*/ | ||
if (rfg->plist_redist_name[ZEBRA_ROUTE_BGP_DIRECT] | ||
[afi]) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same as above...
The bgp_rfapi-cfg_write function had some obvious reindentation changes that could be made. This should clean it up to be a bit more readable. Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com.
@louberger I have run clang-format over the changes as we talked about. |
Continuous Integration Result: FAILEDSee below for issues. This is a comment from an EXPERIMENTAL automated CI system. Get source and apply patch from patchwork: SuccessfulBuilding Stage: FailedDebian8 amd64 build: Successful Fedora24 amd64 build: FailedMake failed for Fedora24 amd64 build:
Fedora24 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-2332/artifact/CI015BUILD/config.status/config.status |
Cleanup the bgp_rfapi_cfg_write function after Lou's commit.