1626 #1628

donaldsharp · 2018-01-11T23:40:03Z

Cleanup the bgp_rfapi_cfg_write function after Lou's commit.

LabN-CI · 2018-01-12T00:03:13Z

💚 Basic BGPD CI results: SUCCESS, 0 tests failed

Results table

_	_
Result	SUCCESS git merge/1628 `6cd2253`
Date	01/11/2018
Start	18:40:09
Finish	19:03:11
Run-Time	23:02
Total	1808
Pass	1808
Fail	0
Valgrind-Errors	0
Valgrind-Loss	0
Details	vncregress-2018-01-11-18:40:09.txt
Log	autoscript-2018-01-11-18:40:45.log.bz2

For details, please contact louberger

NetDEF-CI · 2018-01-12T00:28:59Z

Continuous Integration Result: FAILED

See below for issues.
CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-2301/

This is a comment from an EXPERIMENTAL automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Get source and apply patch from patchwork: Successful

Building Stage: Successful

Basic Tests: Failed

Static analyzer (clang): Successful
IPv6 protocols on Ubuntu 14.04: Successful
CentOS 6 rpm pkg check: Successful
Ubuntu 16.04 deb pkg check: Successful
Ubuntu 12.04 deb pkg check: Successful
Fedora 24 rpm pkg check: Successful
Addresssanitizer topotest: Successful
Debian 8 deb pkg check: Successful
CentOS 7 rpm pkg check: Successful
Debian 9 deb pkg check: Successful
IPv4 protocols on Ubuntu 14.04: Successful
IPv4 ldp protocol on Ubuntu 16.04: Successful
Ubuntu 14.04 deb pkg check: Successful

Topology tests on Ubuntu 16.04 amd64: Failed

Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TOPOU1604-2301/test

Topology Tests failed for Topology tests on Ubuntu 16.04 amd64:

2018-01-11 16:01:08,885 ERROR: ******************************************************************************
2018-01-11 16:01:08,889 ERROR: Test Target Summary                                                  Pass Fail
2018-01-11 16:01:08,890 ERROR: ******************************************************************************
2018-01-11 16:01:08,890 ERROR: 6    r3     See R1s address +10.19 secs                              0    1
2018-01-11 16:01:08,890 ERROR: 17   r1     Remote Registration +10.36 secs                          0    1
2018-01-11 16:01:08,890 ERROR: 19   r4     Remote Registration +10.41 secs                          0    1
2018-01-11 16:01:08,891 ERROR: 24   ce2    Local and remote routes +10.45 secs                      0    1
2018-01-11 16:01:08,891 ERROR: 30   r1     VPN SAFI                                                 0    1
2018-01-11 16:01:08,891 ERROR: 31   r2     VPN SAFI                                                 0    1
2018-01-11 16:01:08,892 ERROR: 32   r3     VPN SAFI                                                 0    1
2018-01-11 16:01:08,892 ERROR: 33   r4     VPN SAFI                                                 0    1
2018-01-11 16:01:08,892 ERROR: ******************************************************************************
2018-01-11 16:01:08,892 ERROR: Total 49                                                             32   8
2018-01-11 16:01:08,893 ERROR: ******************************************************************************
2018-01-11 16:01:08,893 ERROR: See /tmp/topotests/bgp_direct_to_bgp_vpn.test_bgp_direct_to_bgp_vpn/output.log for details of errors
2018-01-11 16:01:08,901 ERROR: assert failed at "bgp_direct_to_bgp_vpn.test_bgp_direct_to_bgp_vpn/test_run_lu_tests": 8 tests failed
assert '8 tests failed' == 'See summary output above'
  - 8 tests failed
  + See summary output above

see full log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-2301/artifact/TOPOU1604/ErrorLog/log_topotests.txt

Topology Tests memory analysis: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-2301/artifact/TOPOU1604/MemoryLeaks/

CLANG Static Analyzer Summary

Github Pull Request 1628, comparing to Git base SHA c124004

No Changes in Static Analysis warnings compared to base

21 Static Analyzer issues remaining.

See details at
https://ci1.netdef.org/browse/FRR-FRRPULLREQ-2301/artifact/shared/static_analysis/index.html

NetDEF-CI · 2018-01-12T02:08:29Z

Continuous Integration Result: SUCCESSFUL

Congratulations, this patch passed basic tests

Tested-by: NetDEF / OpenSourceRouting.org CI System

CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-2301/

This is a comment from an EXPERIMENTAL automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

CLANG Static Analyzer Summary

Github Pull Request 1628, comparing to Git base SHA c124004

No Changes in Static Analysis warnings compared to base

21 Static Analyzer issues remaining.

See details at
https://ci1.netdef.org/browse/FRR-FRRPULLREQ-2301/artifact/shared/static_analysis/index.html

louberger · 2018-01-12T13:48:32Z

@donaldsharp let's do these as separate PRs. merge #1626 then we'll do this one.

qlyoung · 2018-01-12T20:21:51Z

bgpd/rfapi/bgp_rfapi_cfg.c

-						(rfg->type == RFAPI_GROUP_CFG_VRF ? "" : "bgp "),
-						afistr,
-						rfg->plist_export_bgp_name
-							[afi]);


You're commenting on a removed hunk

yup, did the review off line and added the comment in wrong place. should have been on lines below (3974)

louberger · 2018-01-12T15:06:35Z

bgpd/rfapi/bgp_rfapi_cfg.c

-						afistr,
-						rfg->plist_redist_name
-							[ZEBRA_ROUTE_BGP_DIRECT]
-							[afi]);


same comment as above (won't repeat for other cases)

qlyoung · 2018-01-12T20:21:51Z

bgpd/rfapi/bgp_rfapi_cfg.c

-						(rfg->type == RFAPI_GROUP_CFG_VRF ? "" : "bgp "),
-						afistr,
-						rfg->plist_export_bgp_name
-							[afi]);


You're commenting on a removed hunk

louberger · 2018-01-12T20:58:58Z

bgpd/rfapi/bgp_rfapi_cfg.c

-			if (rfg->routemap_redist_name
-				    [ZEBRA_ROUTE_BGP_DIRECT_EXT]) {
+			if (rfg->plist_redist_name
+			    [ZEBRA_ROUTE_BGP_DIRECT_EXT][afi]) {


I'm not a fan of line breaks before indexes -- better to remove whitespace on the indent than to add white space that has semantic implications.

louberger · 2018-01-12T20:59:29Z

bgpd/rfapi/bgp_rfapi_cfg.c

+			 * protocols here
+			 */
+			if (rfg->plist_redist_name[ZEBRA_ROUTE_BGP_DIRECT]
+			    [afi]) {


same as above...

The bgp_rfapi-cfg_write function had some obvious reindentation changes that could be made. This should clean it up to be a bit more readable. Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com.

donaldsharp · 2018-01-16T15:23:29Z

@louberger I have run clang-format over the changes as we talked about.

NetDEF-CI · 2018-01-16T15:36:37Z

Continuous Integration Result: FAILED

See below for issues.
CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-2332/

This is a comment from an EXPERIMENTAL automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Get source and apply patch from patchwork: Successful

Building Stage: Failed

Debian8 amd64 build: Successful
FreeBSD11 amd64 build: Successful
OpenBSD60 amd64 build: Successful
NetBSD6 amd64 build: Successful
CentOS7 amd64 build: Successful
Debian9 amd64 build: Successful
OmniOS amd64 build: Successful
CentOS6 amd64 build: Successful
NetBSD7 amd64 build: Successful
FreeBSD9 amd64 build: Successful
Ubuntu1604 amd64 build: Successful
Ubuntu1204 amd64 build: Successful
FreeBSD10 amd64 build: Successful
Ubuntu1404 amd64 build: Successful

Fedora24 amd64 build: Failed

Make failed for Fedora24 amd64 build:
(see full make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-2332/artifact/CI015BUILD/ErrorLog/log_make.txt)

In file included from ./lib/zebra.h:138:0,
                 from pimd/pim_assert.c:20:
/usr/include/linux/in.h:28:3: error: redeclaration of enumerator IPPROTO_IP
   IPPROTO_IP = 0,  /* Dummy protocol for TCP  */
   ^
/usr/include/netinet/in.h:42:5: note: previous definition of IPPROTO_IP was here
     IPPROTO_IP = 0,    /* Dummy protocol for TCP.  */
     ^~~~~~~~~~
/usr/include/linux/in.h:30:3: error: redeclaration of enumerator IPPROTO_ICMP

Fedora24 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-2332/artifact/CI015BUILD/config.status/config.status

donaldsharp mentioned this pull request Jan 11, 2018

bgp: don't show vnc response-lifetime config line when set to default… #1626

Merged

louberger requested changes Jan 12, 2018

View reviewed changes

qlyoung reviewed Jan 12, 2018

View reviewed changes

louberger reviewed Jan 12, 2018

View reviewed changes

bgpd: Cleanup indentation some in bgp_rfapi_cfg_write

fef3e59

The bgp_rfapi-cfg_write function had some obvious reindentation changes that could be made. This should clean it up to be a bit more readable. Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com.

donaldsharp force-pushed the 1626 branch from 6cd2253 to fef3e59 Compare January 16, 2018 15:18

louberger approved these changes Jan 16, 2018

View reviewed changes

donaldsharp closed this Jan 16, 2018

donaldsharp deleted the 1626 branch January 16, 2018 16:41

FRRouting deleted a comment from LabN-CI Jan 16, 2018

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

1626 #1628

1626 #1628

donaldsharp commented Jan 11, 2018

LabN-CI commented Jan 12, 2018

NetDEF-CI commented Jan 12, 2018

NetDEF-CI commented Jan 12, 2018

louberger commented Jan 12, 2018

qlyoung Jan 12, 2018

louberger Jan 12, 2018

louberger Jan 12, 2018

qlyoung Jan 12, 2018

louberger Jan 12, 2018

louberger Jan 12, 2018

donaldsharp commented Jan 16, 2018

NetDEF-CI commented Jan 16, 2018

1626 #1628

1626 #1628

Conversation

donaldsharp commented Jan 11, 2018

LabN-CI commented Jan 12, 2018

💚 Basic BGPD CI results: SUCCESS, 0 tests failed

NetDEF-CI commented Jan 12, 2018

Continuous Integration Result: FAILED

Get source and apply patch from patchwork: Successful

Building Stage: Successful

Basic Tests: Failed

Topology tests on Ubuntu 16.04 amd64: Failed

Topology Tests memory analysis: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-2301/artifact/TOPOU1604/MemoryLeaks/

CLANG Static Analyzer Summary

No Changes in Static Analysis warnings compared to base

21 Static Analyzer issues remaining.

NetDEF-CI commented Jan 12, 2018

Continuous Integration Result: SUCCESSFUL

CLANG Static Analyzer Summary

No Changes in Static Analysis warnings compared to base

21 Static Analyzer issues remaining.

louberger commented Jan 12, 2018

qlyoung Jan 12, 2018

Choose a reason for hiding this comment

louberger Jan 12, 2018

Choose a reason for hiding this comment

louberger Jan 12, 2018

Choose a reason for hiding this comment

qlyoung Jan 12, 2018

Choose a reason for hiding this comment

louberger Jan 12, 2018

Choose a reason for hiding this comment

louberger Jan 12, 2018

Choose a reason for hiding this comment

donaldsharp commented Jan 16, 2018

NetDEF-CI commented Jan 16, 2018

Continuous Integration Result: FAILED

Get source and apply patch from patchwork: Successful

Building Stage: Failed

Fedora24 amd64 build: Failed