Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Goldilocks controller is too noisy even at v1 #564

Closed
stevo-f3 opened this issue Dec 16, 2022 · 1 comment · Fixed by #613
Closed

Goldilocks controller is too noisy even at v1 #564

stevo-f3 opened this issue Dec 16, 2022 · 1 comment · Fixed by #613
Labels
enhancement Adding additional functionality or improvements stale Marked as stale by stalebot

Comments

@stevo-f3
Copy link

goldilocks/pkg/vpa/vpa.go

Line 324 in db7a6a8

klog.Infof("Updated VPA/%s in Namespace/%s", vpa.Name, vpa.Namespace)
is constantly emitting essentially nice to know info level messages. Please consider logging them on appropriate level so they can be turned off without disabling all logs.
@sudermanjr sudermanjr added the enhancement Adding additional functionality or improvements label Jan 17, 2023
@github-actions github-actions bot added the stale Marked as stale by stalebot label Mar 19, 2023
@lauraseidler
Copy link
Contributor

we have the same problem, would be nice to get this re-opened

@lauraseidler lauraseidler mentioned this issue Jun 19, 2023
Merged
2 tasks
sudermanjr pushed a commit that referenced this issue Jun 27, 2023
@lauraseidler
Increase verbose level for common operations (#613)
ccda8aa 
This addresses the issue described in #564, and increases the verbose
level for common operation logs to `2` (which is the default log level).
This allows to significantly reduce the noise of the logs by setting the
log level to `1`, without turning off logs completely or affecting default
functionality.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement Adding additional functionality or improvements stale Marked as stale by stalebot
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Increase verbose level for common operations
3 participants
@sudermanjr @lauraseidler @stevo-f3