feat: merge wasmd v0.27.0 #570

shiki-tak · 2022-06-21T06:13:16Z

Description

closes: #555

Motivation and context

How has this been tested?

Screenshots (if appropriate):

Checklist:

I followed the contributing guidelines and code of conduct.
I have added a relevant changelog to CHANGELOG.md
I have added tests to cover my changes.
I have updated the documentation accordingly.
I have updated API documentation client/docs/swagger-ui/swagger.yaml

This will not affect functionality whatsoever, it just makes for a more consistent code, as discussed in issue #616.

…fo query

* Implement PinCodes proposal cli * Implement UnpinCodes proposal cli * Fix descriptions * Apply suggestions from code review Co-authored-by: Alexander Peters <alpe@users.noreply.github.com> Co-authored-by: Alexander Peters <alpe@users.noreply.github.com>

codecov · 2022-06-24T05:08:47Z

Codecov Report

Merging #570 (dba039e) into main (1a15177) will decrease coverage by 0.04%.
The diff coverage is 45.57%.

@@            Coverage Diff             @@
##             main     #570      +/-   ##
==========================================
- Coverage   57.59%   57.54%   -0.05%     
==========================================
  Files         793      796       +3     
  Lines       86589    87814    +1225     
==========================================
+ Hits        49871    50534     +663     
- Misses      33558    34107     +549     
- Partials     3160     3173      +13

Impacted Files	Coverage Δ
x/params/types/subspace.go	`80.32% <ø> (ø)`
x/wasm/client/cli/gov_tx.go	`0.00% <0.00%> (ø)`
x/wasm/client/cli/query.go	`0.00% <0.00%> (ø)`
x/wasm/ibc.go	`0.00% <0.00%> (ø)`
x/wasm/ioutils/utils.go	`64.70% <ø> (ø)`
x/wasm/keeper/api.go	`77.77% <0.00%> (+16.66%)`	⬆️
x/wasm/keeper/ibc.go	`78.26% <ø> (ø)`
x/wasm/keeper/metrics.go	`10.71% <ø> (ø)`
x/wasm/types/params.go	`64.38% <0.00%> (-1.44%)`	⬇️
x/wasm/types/tx.go	`45.00% <ø> (+4.27%)`	⬆️
... and 59 more

shiki-tak · 2022-06-27T07:58:11Z

go.mod

@@ -62,5 +63,7 @@ require (
 replace (
 	github.com/99designs/keyring => github.com/cosmos/keyring v1.1.7-0.20210622111912-ef00f8ac3d76
 	github.com/gogo/protobuf => github.com/regen-network/protobuf v1.3.3-alpha.regen.1
+
+	github.com/line/wasmvm => github.com/shiki-tak/wasmvm v0.16.3-testing.0.20220624032404-3e5e9ef10a08


When the following PRs are merged, the latest version is applied.
Finschia/wasmvm#66

zemyblue

Please add this PR chagnes to the changelogs.md

zemyblue · 2022-06-28T09:57:53Z

simapp/simd/cmd/genaccounts.go

 			addr := sdk.AccAddress(args[0])
 			err := sdk.ValidateAccAddress(args[0])
 			if err != nil {
 				inBuf := bufio.NewReader(cmd.InOrStdin())
-				keyringBackend, _ := cmd.Flags().GetString(flags.FlagKeyringBackend)
+				keyringBackend, _ := cmd.Flags().GetString(flags.FlagKeyringBackend) //nolint:errcheck


There was an error checking feature on this line, but removed. any reason to remove it?

//nolint:errcheck was removed because it did not exist. Also, error check was not added here because it was not done in the original simd.

x/wasm/keeper/snapshotter.go

x/wasm/types/params.go

x/wasm/types/types.go

simapp/app.go

x/wasm/keeper/snapshotter.go

x/wasm/keeper/snapshotter_integration_test.go

zemyblue · 2022-06-30T11:19:53Z

@shiki-tak san, please merge as Merge pull request type when you merge this PR in order to we recognize the code history.

loloicci · 2022-07-01T11:44:41Z

docs/core/proto-docs.md

+| `run_as` | [string](#string) |  | RunAs is the address that is passed to the contract's environment as sender |
+| `contract` | [string](#string) |  | Contract is the address of the smart contract |
+| `msg` | [bytes](#bytes) |  | Msg json encoded message to be passed to the contract as execute |
+| `funds` | [cosmos.base.v1beta1.Coin](#cosmos.base.v1beta1.Coin) | repeated | Funds coins that are transferred to the contract on instantiation |


change the protobuf path (maybe it comes from from another file)

I think it is correct because it is the based cosmos proto file.

Sorry, I suggested changing cosmos -> lbm. Is it ok still to be "cosmos.base.v1beta1.Coin"?

As @zemyblue nim commented below, this place should have been changed to cosmos(#564), right?

loloicci · 2022-07-01T11:46:09Z

docs/core/proto-docs.md

+
+| Field | Type | Label | Description |
+| ----- | ---- | ----- | ----------- |
+| `pagination` | [cosmos.base.query.v1beta1.PageRequest](#cosmos.base.query.v1beta1.PageRequest) |  | pagination defines an optional pagination for the request. |


change the protobuf path (maybe it comes from from another file)

I think it is correct because it is the based cosmos proto file.

loloicci · 2022-07-01T11:46:20Z

docs/core/proto-docs.md

+| Field | Type | Label | Description |
+| ----- | ---- | ----- | ----------- |
+| `code_ids` | [uint64](#uint64) | repeated |  |
+| `pagination` | [cosmos.base.query.v1beta1.PageResponse](#cosmos.base.query.v1beta1.PageResponse) |  | pagination defines the pagination in the response. |


change the protobuf path (maybe it comes from from another file)

I think it is correct because it is the based cosmos proto file.

proto/lbm/wasm/v1/query.proto

loloicci · 2022-07-04T06:34:19Z

x/wasm/types/params.go

+	// This is tracked in https://github.com/CosmWasm/wasmd/issues/566 and https://github.com/CosmWasm/wasmd/issues/631.
+	// Gas adjustments are consensus breaking but may happen in any release marked as consensus breaking.
+	// Do not make assumptions on how much gas an operation will consume in places that are hard to adjust,
+	// such as hardcoding them in contracts.
 	//
 	// Please not that all gas prices returned to the wasmer engine should have this multiplied


missed the original change in this line.
62e976a55157c77f6bc2320a827d8851628e10e4

loloicci · 2022-07-04T07:42:58Z

x/wasm/types/proposal_test.go

@@ -804,40 +804,6 @@ func TestUnmarshalContentFromJson(t *testing.T) {
 	}
 }

-func TestProposalJsonSignBytes(t *testing.T) {


Why is this test deleted?

I think I deleted the test because it was duplicated in cherry-pick.

https://github.com/line/lbm-sdk/pull/570/files/aa6e12abed335fcfda88e52238e8fe394e8f6ec8..95f7d374ef53b288bb9736443183e9c80fdd00da#diff-f93e1bfff58369727113a783e468ed5b5bc5847006a9291d50863880590e4093L841

loloicci · 2022-07-04T16:07:45Z

x/wasm/keeper/proposal_integration_test.go

@@ -216,7 +216,7 @@ func TestMigrateProposal(t *testing.T) {
 }

 func TestExecuteProposal(t *testing.T) {
-	ctx, keepers := CreateTestInput(t, false, "staking")


Why is this change included in this commit?

This is because our CreateTestInput has four arguments, unlike the fork source.

loloicci · 2022-07-05T11:26:24Z

x/wasm/keeper/reflect_test.go

+	// now, try to build a protobuf query
+	protoRequest = wasmvmtypes.QueryRequest{
+		Stargate: &wasmvmtypes.StargateQuery{
+			Path: "/cosmos.tx.v1beta1.Service/GetTx",


cosmos -> lbm?

Is cosmos ok becase it is the following proto file?
https://github.com/line/lbm-sdk/blob/main/proto/cosmos/tx/v1beta1/service.proto

@loloicci, This proto path was changes in #564 .

loloicci · 2022-07-05T12:12:00Z

x/wasm/wasm_snapshotter.go

 		snapshot.WriteExtensionItem(protoWriter, wasmBytes)

 		return false
 	})

-	return nil
+	return rerr


shiki-tak · 2022-07-07T05:16:07Z

@zemyblue @tnasu @loloicci PTAL

x/ibc/core/24-host/validate.go

zemyblue

LGTM

go.mod

x/ibc/core/24-host/validate.go

ethanfrey and others added 30 commits June 7, 2022 15:17

Important: add iterator feature support

8e5f86d

Fix inconsistent return of contractAddress from keeper/init()

51db87b

This will not affect functionality whatsoever, it just makes for a more consistent code, as discussed in issue #616.

Handle contract info query

5eaa33d

Implement tx counter for transaction info

7596bc4

Treat all contracts as pinned for gas costs in reply

eba1387

Adjust gas prices in tests

40a4f52

Query all pinned code ids

566713c

Upgrade wasmvm-v1.0.0-soon2

a488fab

Benchmarks for gas pricing

f985d50

Update gas costs

c1d2cb5

fix: fix build error

4e90a9b

remove unused flags from cmd prompt

7ff106e

Add golangci lint check on pull requests

43d8345

Fix message representation for signing

5e4eb96

Add linter name and minor golint related updates

d247e9c

Fixed wrong error message when lastCodeID value is incorrect

763762e

Disable false positive

c62d0d9

Open read access to sequences

c2b8b3c

Limit simulation gas

aa6e12a

fix: build error

95f7d37

Return NoSuchContract system error instead of sdk error in ContractIn…

ac0957c

…fo query

Upgrade wasmvm to v1.0.0-beta5

dbf864e

Upgrade to cosmos-sdk v0.45.0

68a1a39

Proper systemerror follow-up

06c83fe

Failing test showing it was not currently pinned

86d0a86

And properly pin it on governance vote

c2c461e

Require --no-admin flag if no admin set

fa95a2f

Fix tests, handle genesis init as well

e1d1e12

Fixed error message capitalization

0fb3d3e

shiki-tak requested review from loloicci and tnasu June 21, 2022 08:01

shiki-tak self-assigned this Jun 21, 2022

chore: coverage up

f38b645

shiki-tak commented Jun 27, 2022

View reviewed changes

zemyblue mentioned this pull request Jun 28, 2022

Bump up to cosmos-sdk 0.45.6 #575

Closed

4 tasks

zemyblue reviewed Jun 28, 2022

View reviewed changes

shiki-tak mentioned this pull request Jun 29, 2022

chore(deps): Bump github.com/line/wasmvm from 0.16.3-0.9.0 to 1.0.0-0.10.0 #576

Closed

tnasu reviewed Jun 30, 2022

View reviewed changes

simapp/app.go Show resolved Hide resolved

x/wasm/keeper/snapshotter.go Show resolved Hide resolved

x/wasm/keeper/snapshotter_integration_test.go Show resolved Hide resolved

loloicci reviewed Jul 6, 2022

View reviewed changes

shiki-tak added 5 commits July 7, 2022 13:52

fix: change ContractAddrLen

cce1ef5

fix: fix protobuf path

c1d3995

fix: apply review

18ae5e2

fix: fix typo & missing commit

d704996

chore: adjust gas

7955f0b

shiki-tak commented Jul 7, 2022

View reviewed changes

x/ibc/core/24-host/validate.go Show resolved Hide resolved

zemyblue approved these changes Jul 7, 2022

View reviewed changes

tnasu reviewed Jul 7, 2022

View reviewed changes

go.mod Outdated Show resolved Hide resolved

go.mod Outdated Show resolved Hide resolved

x/ibc/core/24-host/validate.go Show resolved Hide resolved

chore: update go.mod

dba039e

shiki-tak mentioned this pull request Jul 8, 2022

Decide whether to import x/ibc from ibc-go and use it or update it. #585

Closed

tnasu approved these changes Jul 8, 2022

View reviewed changes

loloicci approved these changes Jul 8, 2022

View reviewed changes

shiki-tak merged commit df0f33b into Finschia:main Jul 8, 2022

zemyblue mentioned this pull request Sep 21, 2022

Check the changes of cosmwasm/wasmd v0.29 #684

Closed

4 tasks

zemyblue mentioned this pull request Oct 27, 2022

docs: release 0.46.0-rc9 #765

Merged

5 tasks

zemyblue mentioned this pull request Nov 28, 2022

Release lbm-sdk v0.46.0 #812

Merged

5 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: merge wasmd v0.27.0 #570

feat: merge wasmd v0.27.0 #570

shiki-tak commented Jun 21, 2022 •

edited

Loading

codecov bot commented Jun 24, 2022 •

edited

Loading

shiki-tak Jun 27, 2022

zemyblue left a comment

zemyblue Jun 28, 2022

shiki-tak Jul 7, 2022

zemyblue commented Jun 30, 2022 •

edited

Loading

loloicci Jul 1, 2022

shiki-tak Jul 6, 2022

loloicci Jul 7, 2022

shiki-tak Jul 7, 2022

loloicci Jul 1, 2022

shiki-tak Jul 6, 2022

loloicci Jul 7, 2022

loloicci Jul 1, 2022

shiki-tak Jul 6, 2022

loloicci Jul 7, 2022

loloicci Jul 4, 2022

loloicci Jul 4, 2022

shiki-tak Jul 6, 2022

loloicci Jul 4, 2022

shiki-tak Jul 7, 2022

loloicci Jul 5, 2022

shiki-tak Jul 6, 2022

zemyblue Jul 6, 2022

loloicci Jul 5, 2022

shiki-tak commented Jul 7, 2022

zemyblue left a comment

feat: merge wasmd v0.27.0 #570

feat: merge wasmd v0.27.0 #570

Conversation

shiki-tak commented Jun 21, 2022 • edited Loading

Description

Motivation and context

How has this been tested?

Screenshots (if appropriate):

Checklist:

codecov bot commented Jun 24, 2022 • edited Loading

Codecov Report

Choose a reason for hiding this comment

zemyblue left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

zemyblue commented Jun 30, 2022 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

shiki-tak commented Jul 7, 2022

zemyblue left a comment

Choose a reason for hiding this comment

shiki-tak commented Jun 21, 2022 •

edited

Loading

codecov bot commented Jun 24, 2022 •

edited

Loading

zemyblue commented Jun 30, 2022 •

edited

Loading