-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release/v0.33.3 0.1 #70
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
should force CircleCI to update the code cache Found a cache from build 100135 at go-src-v1-b215e07ecdc6ad5c363c3b420580aa6b52913feb Size: 65 MiB Cached paths: * /go/src/github.com/tendermint/tendermint/.git because we have v0.33.1-dev3 tag, bump-semver.py script is thinking the next tag should be v0.33.1, not v0.33.2: if re.match('[0-9]+$',patch) is None: patchfound = re.match('([0-9]+)',patch) patch = int(patchfound.group(1)) else: patch = int(patch) + 1 The last tag it finds is v0.33.1-dev3. So it hits the first branch. But the first branch only fetches the number, and doesn't increment it, so the result is v0.33.1. if there exists a patch tag like 1-dev3, then the next version should be 0.33.1. But in this case, 0.33.1 has already been released.
Remove unfit tag of README.md
Setup develop environment of circleCI
feat: store proof, round on block
…tate`. * Add hash function in `GenesisDoc` *
Add Random Sampling Function
Change the comment more clear.
fix: reactor test failure
Set resource for the circleci machine
Apply Tendermint 0.33.3
fix: skipped test
FIX: Skipped test cases in replay_test.go
Apply to Tendermint 0.33.3
* Add LINE version in Tendermint version
egonspace
approved these changes
Apr 27, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
- Error links are all origin Tendermint links
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Release v0.1 of LINE Tendermint based on 0.33.3 Tendermint.
(Display version is 0.33.3-0.1)