Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release/v0.33.3 0.1 #70

Merged
merged 107 commits into from
Apr 27, 2020
Merged

Release/v0.33.3 0.1 #70

merged 107 commits into from
Apr 27, 2020

Conversation

zemyblue
Copy link
Member

Description

Release v0.1 of LINE Tendermint based on 0.33.3 Tendermint.
(Display version is 0.33.3-0.1)

melekes and others added 30 commits March 11, 2020 13:55
should force CircleCI to update the code cache

Found a cache from build 100135 at go-src-v1-b215e07ecdc6ad5c363c3b420580aa6b52913feb
Size: 65 MiB
Cached paths:
* /go/src/github.com/tendermint/tendermint/.git

because we have v0.33.1-dev3 tag, bump-semver.py script is thinking the
next tag should be v0.33.1, not v0.33.2:

if re.match('[0-9]+$',patch) is None:
  patchfound = re.match('([0-9]+)',patch)
patch = int(patchfound.group(1))
  else:
  patch = int(patch) + 1

  The last tag it finds is v0.33.1-dev3. So it hits the first branch. But
  the first branch only fetches the number, and doesn't increment it, so
  the result is v0.33.1.

  if there exists a patch tag like 1-dev3, then the next version should be
  0.33.1. But in this case, 0.33.1 has already been released.
feat: store proof, round on block
…tate`.

* Add hash function in `GenesisDoc`
*
Change the comment more clear.
Copy link
Contributor

@egonspace egonspace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

- Error links are all origin Tendermint links
@zemyblue zemyblue merged commit 404d27a into master Apr 27, 2020
@zemyblue zemyblue deleted the release/v0.33.3-0.1 branch June 22, 2020 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants