Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: wrap result twice #33

Closed
loloicci opened this issue Apr 21, 2023 · 0 comments · Fixed by #35
Closed

bug: wrap result twice #33

loloicci opened this issue Apr 21, 2023 · 0 comments · Fixed by #35
Labels
bug Something isn't working

Comments

@loloicci
Copy link

return sdk.WrapServiceResult(ctx, res, err)

This code wraps the result which is already wrapped. It is a bug.

@loloicci loloicci added the bug Something isn't working label Apr 21, 2023
@da1suk8 da1suk8 removed their assignment Apr 21, 2023
loloicci added a commit to loloicci/wasmd that referenced this issue Apr 21, 2023
da1suk8 added a commit to da1suk8/wasmd that referenced this issue Apr 21, 2023
loloicci added a commit that referenced this issue Apr 24, 2023
…n plus handler (#35)

* fix: stop wrap twice non-plus wasm hander's response

fix #33

* test: add tests handling non-plus wasm messages

* docs: add this PR to CHANGELOG.md

* fix: reflect golangci-lint

* fix: simplify how to handle the message in wasmplus
loloicci added a commit that referenced this issue Jun 14, 2023
…#53)

* build: replace line repositories with finschia repositories (#30)

* build: replace line repositories with finschia repositories

* Update x/wasmplus/README.md

Co-authored-by: zemyblue <zemyblue@gmail.com>

* Update x/wasm/ibc_reflect_test.go

Co-authored-by: zemyblue <zemyblue@gmail.com>

* Update .github/dependabot.yml

Co-authored-by: jaeseung-bae <119839167+jaeseung-bae@users.noreply.github.com>

* Update CHANGELOG.md

Co-authored-by: jaeseung-bae <119839167+jaeseung-bae@users.noreply.github.com>

* Update CHANGELOG.md

Co-authored-by: jaeseung-bae <119839167+jaeseung-bae@users.noreply.github.com>

* docs: replace a comment contains line with finschia one

* build: replace line in Dockerfile with finschia

* docs: replace line in README.md with Finschia

* docs: update CHANGELOG

---------

Co-authored-by: zemyblue <zemyblue@gmail.com>
Co-authored-by: jaeseung-bae <119839167+jaeseung-bae@users.noreply.github.com>

* chore: update changelog for release v0.1.3 (#31)

* fix: stop wrap twice the response of handling non-plus wasm message in plus handler (#35)

* fix: stop wrap twice non-plus wasm hander's response

fix #33

* test: add tests handling non-plus wasm messages

* docs: add this PR to CHANGELOG.md

* fix: reflect golangci-lint

* fix: simplify how to handle the message in wasmplus

* chore: update notice (#44)

* chore: update notice

* chore: update changelog

* fix: delete unnecessary test (#43)

* fix: delete unnecessary test

* docs: add CHANGELOG

* feat: add admin-related events (#46)

* add admin-related events in docs
* fix ClearAdmin event
* cherry-pick upstream admin-related events update

* chore: update changelog for release v0.1.4 (#49)

* build: update depending wasmvm to v1.1.1-0.11.2-dynamiclink2 and update tests

---------

Co-authored-by: zemyblue <zemyblue@gmail.com>
Co-authored-by: jaeseung-bae <119839167+jaeseung-bae@users.noreply.github.com>
Co-authored-by: Daisuke Iuchi <42408108+da1suk8@users.noreply.github.com>
Co-authored-by: Jayden Lee <41176085+tkxkd0159@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants