fix: stop wrap twice the response of handling non-plus wasm message in plus handler #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
da1suk8
reviewed
Apr 24, 2023
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more Additional details and impacted files@@ Coverage Diff @@
## main #35 +/- ##
==========================================
- Coverage 60.83% 60.82% -0.01%
==========================================
Files 80 80
Lines 9879 9877 -2
==========================================
- Hits 6010 6008 -2
Misses 3553 3553
Partials 316 316
|
dudong2
approved these changes
Apr 24, 2023
zemyblue
reviewed
Apr 24, 2023
da1suk8
approved these changes
Apr 24, 2023
zemyblue
approved these changes
Apr 24, 2023
da1suk8
pushed a commit
to da1suk8/wasmd
that referenced
this pull request
Apr 24, 2023
This was referenced May 22, 2023
Merged
loloicci
added a commit
that referenced
this pull request
Jun 14, 2023
…#53) * build: replace line repositories with finschia repositories (#30) * build: replace line repositories with finschia repositories * Update x/wasmplus/README.md Co-authored-by: zemyblue <zemyblue@gmail.com> * Update x/wasm/ibc_reflect_test.go Co-authored-by: zemyblue <zemyblue@gmail.com> * Update .github/dependabot.yml Co-authored-by: jaeseung-bae <119839167+jaeseung-bae@users.noreply.github.com> * Update CHANGELOG.md Co-authored-by: jaeseung-bae <119839167+jaeseung-bae@users.noreply.github.com> * Update CHANGELOG.md Co-authored-by: jaeseung-bae <119839167+jaeseung-bae@users.noreply.github.com> * docs: replace a comment contains line with finschia one * build: replace line in Dockerfile with finschia * docs: replace line in README.md with Finschia * docs: update CHANGELOG --------- Co-authored-by: zemyblue <zemyblue@gmail.com> Co-authored-by: jaeseung-bae <119839167+jaeseung-bae@users.noreply.github.com> * chore: update changelog for release v0.1.3 (#31) * fix: stop wrap twice the response of handling non-plus wasm message in plus handler (#35) * fix: stop wrap twice non-plus wasm hander's response fix #33 * test: add tests handling non-plus wasm messages * docs: add this PR to CHANGELOG.md * fix: reflect golangci-lint * fix: simplify how to handle the message in wasmplus * chore: update notice (#44) * chore: update notice * chore: update changelog * fix: delete unnecessary test (#43) * fix: delete unnecessary test * docs: add CHANGELOG * feat: add admin-related events (#46) * add admin-related events in docs * fix ClearAdmin event * cherry-pick upstream admin-related events update * chore: update changelog for release v0.1.4 (#49) * build: update depending wasmvm to v1.1.1-0.11.2-dynamiclink2 and update tests --------- Co-authored-by: zemyblue <zemyblue@gmail.com> Co-authored-by: jaeseung-bae <119839167+jaeseung-bae@users.noreply.github.com> Co-authored-by: Daisuke Iuchi <42408108+da1suk8@users.noreply.github.com> Co-authored-by: Jayden Lee <41176085+tkxkd0159@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes the bug wrapping twice the response of handling non-plus wasm message in plus handler.
Description
wasmplus's handler returned a response that is wrapped twice (too much) when a non-plus wasm message is given.
This PR
closes: #33
closes: #34
closes: #32
How has this been tested?
Unit-tests are added in this PR.
Checklist:
CHANGELOG.mdclient/docs/swagger-ui/swagger.yaml(not needed)