Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possible failure to suspend instances on license expired #4772

Closed
hardillb opened this issue Nov 14, 2024 · 1 comment · Fixed by #4888
Closed

Possible failure to suspend instances on license expired #4772

hardillb opened this issue Nov 14, 2024 · 1 comment · Fixed by #4888
Assignees
Labels
bug Something isn't working size:M - 3 Sizing estimation point
Milestone

Comments

@hardillb
Copy link
Contributor

hardillb commented Nov 14, 2024

Current Behavior

User had trial EE license, went on vacation and license expired and instances marked as suspended.
on return applied new EE trial license, but could not restart existing instances.

Investigation at the k8s level showed Deployments/Service/Ingress still existed (but DB showed suspended).

Failed to start, because entries already exist.

Expected Behavior

Instances should actually be suspended and all K8s entries removed.

Steps To Reproduce

  • Deploy with EE license
  • Start instances
  • Expire license
  • Add new License
  • Try and restart existing instances

Environment

  • FlowFuse version: 2.8.0
  • Node.js version: 18.x
  • npm version: 9.x
  • Platform/OS: K8s
  • Browser: NA

Have you provided an initial effort estimate for this issue?

I have provided an initial effort estimate

@hardillb hardillb added bug Something isn't working needs-triage Needs looking at to decide what to do size:M - 3 Sizing estimation point labels Nov 14, 2024
hardillb added a commit that referenced this issue Nov 14, 2024
@joepavitt joepavitt moved this to In Progress in 🛠 Development Dec 4, 2024
@joepavitt joepavitt added this to the 2.12 milestone Dec 4, 2024
@joepavitt joepavitt removed the needs-triage Needs looking at to decide what to do label Dec 4, 2024
@hardillb
Copy link
Contributor Author

hardillb commented Dec 4, 2024

I've added more debug (#4773) to this, but it's going to be hard to test.

Best option I can think is to spin up a test instance on k8s and give it a license with only a day's life and then let it expire.

Will try and find a machine I can run single node k8s cluster on to test

@hardillb hardillb moved this from In Progress to Review in 🛠 Development Dec 9, 2024
@github-project-automation github-project-automation bot moved this from Review to Done in 🛠 Development Dec 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working size:M - 3 Sizing estimation point
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants