Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure Instance suspended on expired license #4888

Merged
merged 2 commits into from
Dec 10, 2024

Conversation

hardillb
Copy link
Contributor

@hardillb hardillb commented Dec 7, 2024

fixes #4772

Description

k8s driver needs the safeName to suspend and instance and it was missing from the fields return in the projectList

Related Issue(s)

#4772

Checklist

  • I have read the contribution guidelines
  • Suitable unit/system level tests have been added and they pass
  • Documentation has been updated
    • Upgrade instructions
    • Configuration details
    • Concepts
  • Changes flowforge.yml?
    • Issue/PR raised on FlowFuse/helm to update ConfigMap Template
    • Issue/PR raised on FlowFuse/CloudProject to update values for Staging/Production

Labels

  • Includes a DB migration? -> add the area:migration label

k8s driver needs the safeName to suspend and instance and it
was missing from the fields return in the projectList
@hardillb hardillb requested a review from knolleary December 7, 2024 07:49
@hardillb hardillb self-assigned this Dec 7, 2024
Copy link

codecov bot commented Dec 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.74%. Comparing base (a8478da) to head (6f512d8).
Report is 90 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4888   +/-   ##
=======================================
  Coverage   78.74%   78.74%           
=======================================
  Files         323      323           
  Lines       15221    15221           
  Branches     3496     3496           
=======================================
  Hits        11986    11986           
  Misses       3235     3235           
Flag Coverage Δ
backend 78.74% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hardillb
Copy link
Contributor Author

hardillb commented Dec 8, 2024

Tested on custom k8s rig over the weekend, works properly now

@knolleary knolleary merged commit 3483917 into main Dec 10, 2024
13 checks passed
@knolleary knolleary deleted the ensure-instances-suspended-on-expired-license branch December 10, 2024 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Possible failure to suspend instances on license expired
2 participants