-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ensure device logs always shown #4893
Conversation
fixes #4832 This triggers a publish of the logs history every time the tab is opened
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4893 +/- ##
==========================================
- Coverage 78.74% 78.70% -0.04%
==========================================
Files 323 323
Lines 15221 15230 +9
Branches 3496 3498 +2
==========================================
+ Hits 11986 11987 +1
- Misses 3235 3243 +8
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
running fine locally
This PR has broken the logs when you have more than one user access them. By triggering an unsubscribe when leaving the page, it stops log delivery to other users viewing the device. When you open the device log view it triggers the buffer to be resent and is received by all users viewing the log. This needs to be reverted. |
I believe this was already the case with the old way as well. Actually no, but it relied on a race between the keep alive and the log shutdown |
could we namespace the events to target a single user? |
The quick revert is to remove the publish from the |
fixes #4832
Description
This triggers a publish of the logs history every time the tab is opened. It does this by explicitly telling the device agent it has disconnected when navigating away from the tab.
Related Issue(s)
#4832
Checklist
flowforge.yml
?FlowFuse/helm
to update ConfigMap TemplateFlowFuse/CloudProject
to update values for Staging/ProductionLabels
area:migration
label